Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
System Settings
Commits
fbf85dcc
Commit
fbf85dcc
authored
Jan 21, 2021
by
Fabian Vogt
Browse files
Fix headers missing for non-KCM modules
parent
8e28113e
Changes
1
Hide whitespace changes
Inline
Side-by-side
core/ModuleView.cpp
View file @
fbf85dcc
...
...
@@ -443,17 +443,18 @@ void ModuleView::activeModuleChanged(KPageWidgetItem *current, KPageWidgetItem *
// We need to get the state of the now active module
stateChanged
();
KCModuleInfo
*
activeModuleInfo
=
activeModule
();
KCModuleProxy
*
activeModule
=
d
->
mPages
.
value
(
d
->
mPageWidget
->
currentPage
());
if
(
activeModule
)
{
if
(
activeModule
||
activeModuleInfo
)
{
// TODO: if we'll ever need statistics for kinfocenter modules, save them with an URL like "kinfo:"
if
(
d
->
mSaveStatistics
)
{
if
(
activeModule
&&
d
->
mSaveStatistics
)
{
KActivities
::
ResourceInstance
::
notifyAccessed
(
QUrl
(
QStringLiteral
(
"kcm:"
)
+
activeModule
->
moduleInfo
().
service
()
->
storageId
()),
QStringLiteral
(
"org.kde.systemsettings"
));
}
d
->
mCustomHeader
->
setText
(
activeModule
->
module
Info
().
moduleName
());
d
->
mCustomHeader
->
setText
(
activeModuleInfo
->
moduleName
());
const
bool
isQml
=
(
activeModule
->
realModule
()
&&
activeModule
->
realModule
()
->
inherits
(
"KCModuleQml"
));
const
bool
isQml
=
(
activeModule
&&
activeModule
->
realModule
()
&&
activeModule
->
realModule
()
->
inherits
(
"KCModuleQml"
));
d
->
mCustomHeader
->
setVisible
(
!
isQml
);
current
->
setHeaderVisible
(
!
isQml
);
...
...
Fabian Vogt
@fvogt
mentioned in commit
f2605e1e
·
Jan 25, 2021
mentioned in commit
f2605e1e
mentioned in commit f2605e1e944e9b08b9271d60a27cbb6923ccc12b
Toggle commit list
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment