Otherwise there'll be a blank spot.

BUG: 413178
FIXED-IN: 5.17.1

Differential Revision: https://phabricator.kde.org/D24818

Differential Revision: https://phabricator.kde.org/D24427

Tien Do Nam authored Sep 18, 2019 and Nate Graham committed Sep 18, 2019

Summary:
Add tooltips to the most used settings in the intro page

{F7375883}

Test Plan: Move your cursor on one of the most used settings, a tooltip will appear

Reviewers: #vdg, ngraham, GB_2

Reviewed By: #vdg, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24049

Summary:
{F7206388}
Also makes QML imports consistent.

Test Plan: Open the System Settings. Everything should still work.

Reviewers: #plasma, #vdg, ngraham, mart, broulik

Reviewed By: #plasma, #vdg, ngraham, broulik

Subscribers: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma

Tags: #plasma

Maniphest Tasks: T10862

Differential Revision: https://phabricator.kde.org/D22896

They are compiled but never used since it's all done in QML

Differential Revision: https://phabricator.kde.org/D20894

Summary:
KAboutData::setProgramIconName isn't used in the AboutData dialog box,
instead the generic QApplication icon name is used.

Therefore there's little point setting it. It was also used by classic
mode to create an icon in the config page that it has, but we can do
that directly.

Test Plan:
Compiles
Looked at module about data
Looked at settings page

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18489

Summary:
Tooltips are already shown for both categories as well as top-level items
at the category level (e.g. Printers). This patch makes the tooltips
show up for subcategory items as well.

FEATURE: 402651
FIXED-IN: 5.15.0

Test Plan: {F6515354, size=full}

Reviewers: #vdg, #plasma, mart, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17864

BUG:394553

BUG:394553

It shouldn't crash, but display exactly what the error was with its qml
BUG:394902

It shouldn't crash, but display exactly what the error was with its qml
BUG:394902

Summary:
When you switch module with unsaved changes the other modes prompt if
you want to save the changes. Sidebar mode did not.

BUG: 392160

Test Plan:
Made a change, clicked another module. Got a prompt.

Clicked apply, it applied then changed

Tried again

Clicked cancel, it didn't change

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12686

before comparing new and old row, map the new one to the source model

BUG:386454

Instead of duplicating the name and icon work, just bind it to the QAction itself.
Also respect visibility of actions for KIOSK restriction.

Differential Revision: https://phabricator.kde.org/D8358

Summary:
correct keyboard navigation in systemsettings, since there is a mix
of qwidgets and QQuickWidgets, when a QQW takes focus, then the
focus chain in the keyboard navigation should traverse it, then go
put of it and focus the next widget, being a normal qwidget or another
qqw in which case the same hack applies

Test Plan:
navigating in and out the sidebar and the intro page works

QML based kcms are still not managed, they will need a similar thing

Reviewers: #plasma

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8221

Caught a real bug, I think (URLs without scheme).

when we activate a category we need to know the actual index of the sorted first
menuproxymodel, not its source model which being sorted has different items at
different rows, so use a proxy to sort and another to filter

pressing esc is not supposed to close the module on this view

repopulate (or depopulate) the toolbar when the active view
changes (but its instance was already loaded)
BUG:380083

BUG:381701

Summary:
use kactivities to track the most used modules (kcmshell will need to as well)
and present them in the start page as 5 big icons

Test Plan:
empty kactivities db, show default set, after some usage, the most used modules come
on top

Reviewers: #plasma, #vdg

Subscribers: davidedmundson, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6061

don't remove/readd the page when we are just changing the model
of the page, make sure a signle model reset signal arrives to the view
to populate it all in one go