System Settings merge requestshttps://invent.kde.org/plasma/systemsettings/-/merge_requests2023-01-04T20:47:54Zhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/185Only use KWindowSystem::updateStartupId if we have frameworks >= 5.912023-01-04T20:47:54ZNate GrahamOnly use KWindowSystem::updateStartupId if we have frameworks >= 5.91That's the version when it was introduced, but Plasma 5.24 only
required 5.89 at launch.
BUG: 462795
FIXED-IN: 5.24.8
cc @fvogtThat's the version when it was introduced, but Plasma 5.24 only
required 5.89 at launch.
BUG: 462795
FIXED-IN: 5.24.8
cc @fvogt5.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/153Make sidebar tooltips respect the "Display informational tooltips" global set...2022-06-24T17:33:41ZAnthony HungMake sidebar tooltips respect the "Display informational tooltips" global settingBUG: 455073
FIXED-IN: 5.24.6BUG: 455073
FIXED-IN: 5.24.65.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/152Change window size limit after screen resolution is changed2022-06-28T08:30:15ZFushan WenChange window size limit after screen resolution is changedIt allows to show the button group at the bottom after the screen is
selected to use a smaller resolution.
![geometryChanged](/uploads/674b8dde0ac8b172615a5029b939c525/geometryChanged.mp4)It allows to show the button group at the bottom after the screen is
selected to use a smaller resolution.
![geometryChanged](/uploads/674b8dde0ac8b172615a5029b939c525/geometryChanged.mp4)5.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/142Fix activating running instance on Wayland2022-06-13T17:40:17ZNicolas FellaFix activating running instance on Wayland5.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/141Fix current index in subcategory list2022-05-12T14:51:52ZNicolas FellaFix current index in subcategory listWe bind currentIndex to activeSubCategoryRow, but when clicking on an item this binding is broken
Manually set the current index when the backend index changes
BUG: 453543
Fixed-In: 5.24.6We bind currentIndex to activeSubCategoryRow, but when clicking on an item this binding is broken
Manually set the current index when the backend index changes
BUG: 453543
Fixed-In: 5.24.65.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/132Don't let back arrow be re-colored to monochrome2022-05-17T11:35:24ZNate GrahamDon't let back arrow be re-colored to monochromeThe back button uses a custom content item with the icon being provided
by Kirigami.Icon. Unfortunately, Kirigami.Icon currently suffers from an
issue that causes colored icons that end with "-symbolic" to be forced
to monochrome. See ht...The back button uses a custom content item with the icon being provided
by Kirigami.Icon. Unfortunately, Kirigami.Icon currently suffers from an
issue that causes colored icons that end with "-symbolic" to be forced
to monochrome. See https://bugs.kde.org/show_bug.cgi?id=451538.
There is an open merge request to fix that
(https://invent.kde.org/frameworks/kirigami/-/merge_requests/511), but
the fix is in Frameworks, which means it will only get to people who use
rolling release distros or whose packagers backport the fix.
This commit targeted at the Plasma/5.24 branch only is a local
workaround intended to alleviate the situation for LTS distro users who
are less likely to get the frameworks fix, once it's merged. The master
branch doesn't need the workaround since we can hope that the
Frameworks fix will be merged before Plasma 5.25.
CCBUG: 451538
| Before, icon theme with a colored icon | After, icon theme with a colored icon |
| -------------------------------------- | ------------------------------------- |
| ![Before](/uploads/b31b7b428ea5c444dc8c3feacf4c4e65/Before.png) | ![After](/uploads/4e0aa84524af827f86390926ce70cd4b/After.png) |
cc @teams/usability @dobey @bednar5.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/131app/SettingsBase: Fix systemsettings unable to start when missing plugin2022-03-08T14:52:08ZFushan Wenapp/SettingsBase: Fix systemsettings unable to start when missing pluginSwitch to alternate view if the current view is missing on startup.
BUG: 451054
FIXED-IN: 5.24.3
Test: Switch to sidebar mode, close systemsettings and run `mv /usr/lib64/qt5/plugins/systemsettingsview/systemsettings_sidebar_mode.so{,....Switch to alternate view if the current view is missing on startup.
BUG: 451054
FIXED-IN: 5.24.3
Test: Switch to sidebar mode, close systemsettings and run `mv /usr/lib64/qt5/plugins/systemsettingsview/systemsettings_sidebar_mode.so{,.bak}`, and run systemsettings.5.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/130ModuleView: Simplify and fix custom headers logic2022-09-01T21:25:19ZIsmael AsensioModuleView: Simplify and fix custom headers logicApart from a minimum logic refactor, this introduces two fixes:
- Only affect custom header visiblity for current page
- Do not set customHeader text when not visible
When calling `KTitleWidget::setText()`, this would set the custom
hea...Apart from a minimum logic refactor, this introduces two fixes:
- Only affect custom header visiblity for current page
- Do not set customHeader text when not visible
When calling `KTitleWidget::setText()`, this would set the custom
header visible again. So do it only if we want it actually visible.
This fixes the issue in https://invent.kde.org/plasma/kscreen/-/issues/4, so the workarounds to show the OverlaySheet can be removed.
CC: @dominichayes @ngraham @xuetianweng5.24Ismael AsensioIsmael Asensiohttps://invent.kde.org/plasma/systemsettings/-/merge_requests/129sidebar: Load placeHolderWidget only when needed2022-02-19T13:09:39ZFushan Wensidebar: Load placeHolderWidget only when neededThis slightly reduces the startup time of the sidebar mode, and
potentially fixes the crash when switching from the icon mode to
the sidebar mode.
CCBUG: 449853This slightly reduces the startup time of the sidebar mode, and
potentially fixes the crash when switching from the icon mode to
the sidebar mode.
CCBUG: 4498535.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/127fixup! app/SettingsBase: Only load current view on startup2022-02-12T07:38:32ZFushan Wenfixup! app/SettingsBase: Only load current view on startupThank @ahmadsamirThank @ahmadsamir5.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/126app/SettingsBase: cherry-pick for 5.242022-02-11T00:06:21ZFushan Wenapp/SettingsBase: cherry-pick for 5.24It's unnecessary and takes too long time to load both Icon View and Sidebar View.
This greatly reduces the startup time when using Icon View.It's unnecessary and takes too long time to load both Icon View and Sidebar View.
This greatly reduces the startup time when using Icon View.5.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/125app/SettingsBase: Only load current view on startup2022-02-11T14:10:35ZFushan Wenapp/SettingsBase: Only load current view on startupIt's unnecessary and takes too long time to load both Icon View and Sidebar View.
This greatly reduces the startup time when using Icon View.It's unnecessary and takes too long time to load both Icon View and Sidebar View.
This greatly reduces the startup time when using Icon View.5.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/124app/SettingsBase: Show the main window before QML component is loaded2022-02-11T00:01:21ZFushan Wenapp/SettingsBase: Show the main window before QML component is loadedThe loading process usually takes a few seconds on slow machines, and
it even takes 1-2 seconds on my laptop (AMD Ryzen 4700U + SATA SSD), so
instead letting the user wait for nothing, we should show an empty window
to make the startup p...The loading process usually takes a few seconds on slow machines, and
it even takes 1-2 seconds on my laptop (AMD Ryzen 4700U + SATA SSD), so
instead letting the user wait for nothing, we should show an empty window
to make the startup process "feel" faster.
| Before | After |
| ------ | ------ |
| ![before](/uploads/1763ca65e5b080bc5a48bd48d0a02573/before.mp4) | ![after](/uploads/c43370bd94c5cc66e7994a30015b8866/after.mp4) |5.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/123Systemsettings runner: Increase relevance if we have an exact match in the ke...2022-02-12T14:29:34ZAlexander LohnauSystemsettings runner: Increase relevance if we have an exact match in the keywordsThis way we treat an exact match in the keywords like if the query is contained in the description.This way we treat an exact match in the keywords like if the query is contained in the description.5.24Alexander LohnauAlexander Lohnauhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/122Systemsettings Runner: Skip KCM that are not launchable2022-02-01T20:14:13ZAlexander LohnauSystemsettings Runner: Skip KCM that are not launchableThe old KServiceTypeTrader logic took care of that too.
Systemsettings filters them out by their parent category anyway, but we would still display
them in KRunner.
I noticed that a third-party KRunner KCM showed up in the search, whic...The old KServiceTypeTrader logic took care of that too.
Systemsettings filters them out by their parent category anyway, but we would still display
them in KRunner.
I noticed that a third-party KRunner KCM showed up in the search, which should of course not happen :)5.24Alexander LohnauAlexander Lohnauhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/121IconView: Fix vertical spacing2022-02-01T19:45:42ZIsmael AsensioIconView: Fix vertical spacingIconView: Fix header padding
We weren't setting the vertical spacing for the page's GridLayout,
so it took the standard 6px causing this extra padding on top and
bottom for every KCM.
The horizontal spacing is not needed, so that part ...IconView: Fix header padding
We weren't setting the vertical spacing for the page's GridLayout,
so it took the standard 6px causing this extra padding on top and
bottom for every KCM.
The horizontal spacing is not needed, so that part can be simplified.
~~QWidget headers are still shorter tham QML ones, but that's pre-existing~~
Edit: Better apply this margins to the title widget which is only shown
for iconview.
BUG: 449040
FIXED-IN: 5.24
|BEFORE|AFTER|
|---|---|
|![iconview_qml_before](/uploads/694926c955896b956a8001c4f91593e1/iconview_qml_before.png)|![iconview_qml_after](/uploads/da14c742e0d5905119474157e7e33004/iconview_qml_after.png)|
|![iconview_qwidgets_before](/uploads/8075ae0f58de14a9fa963d133190c40a/iconview_qwidgets_before.png)|![iconview_qwidgets_after](/uploads/71a132043373b4168c4b0a157811e3f2/iconview_qwidgets_after.png)|5.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/120ModuleView: Improve code for header updates2022-02-13T13:45:55ZIsmael AsensioModuleView: Improve code for header updatesClean-up and refactor around updatePageIconHeader() method and uses.
By moving the header logic into this method, we reduce some duplicity
present in different codepaths and make it less bug-prone, specially
on IconView.
BUG: 432093
FI...Clean-up and refactor around updatePageIconHeader() method and uses.
By moving the header logic into this method, we reduce some duplicity
present in different codepaths and make it less bug-prone, specially
on IconView.
BUG: 432093
FIXED-IN: 5.24
The diff can look a bit scary, but it's basically just moving things around and removing duplicates/unnecesary code5.24Nate GrahamNate Grahamhttps://invent.kde.org/plasma/systemsettings/-/merge_requests/119Do not show Help button if there's no help path defined2023-08-07T20:17:35ZIsmael AsensioDo not show Help button if there's no help path definedThe Help button would do nothing in this case.
This is speacially *unhelpful* on kinfocenter where for many modules
we show a whole button footer for just this Help button.
Also second commit fixes the button box visibility when button...The Help button would do nothing in this case.
This is speacially *unhelpful* on kinfocenter where for many modules
we show a whole button footer for just this Help button.
Also second commit fixes the button box visibility when buttons are externally hidden (as it is the case for kinfocenter)
| | BEFORE | AFTER |
|---|---|---|
|Energy Info|![before_energyinfo](/uploads/7b71b2df238ad1e272138e0ccd28647e/before_energyinfo.png)|![after_energyinfo](/uploads/a2f622ca1c2f7bc23f03ce1186862ffe/after_energyinfo.png)|
|Devices:PCI|![before_pci](/uploads/7d06eb9d136c5efe3f512f9d7ada59ee/before_pci.png)|![after_pci](/uploads/0836df0b7abdb279b4f818b331ed63ca/after_pci.png)|5.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/118Use a more familiar icon for the "Input Devices" category2022-01-24T22:09:38ZNate GrahamUse a more familiar icon for the "Input Devices" categoryRight now it uses the `preferences-desktop-peripherals` icon, which is
problematic on three levels:
- It is not sementically accurate since "peripherals" encompasses far
more than just input devices; printers fit under this term too.
-...Right now it uses the `preferences-desktop-peripherals` icon, which is
problematic on three levels:
- It is not sementically accurate since "peripherals" encompasses far
more than just input devices; printers fit under this term too.
- It looks like a graphics tablet, which is one of the least likely
input device for the user to have available, beaten out only by a
joystick. This makes its recognizability factor quite low.
- A graphics tablet has the same shape as a monitor, so there are two
icons right on top of each other with the same basic shape,
contributing to the "icon soup" effect.
To make the icon more recognizable to the majority of users, let's
change it to `preferences-desktop-mouse` which is an example of an input
device and is known to everybody and has a visually distinct shape.
BUG: 449056
FIXED-IN: 5.24
@teams/vdg
| Before | After |
| ------ | ----- |
| ![Before](/uploads/fe1acd5d7a39b84265c6e9f079fc140c/Before.png) | ![After](/uploads/ef68010ca4a4dc3342df262a306abfd5/After.png) |5.24https://invent.kde.org/plasma/systemsettings/-/merge_requests/116FooterToolbar: Match also padding to the modules' buttons2022-01-23T01:56:11ZIsmael AsensioFooterToolbar: Match also padding to the modules' buttonsSet the padding in the sidebar footer to match the value of the
breeze default padding (6px), so the "Highlight Changes" button
is consistent with the footer buttons in the modules.
The value is hardcoded for now, until we can get the m...Set the padding in the sidebar footer to match the value of the
breeze default padding (6px), so the "Highlight Changes" button
is consistent with the footer buttons in the modules.
The value is hardcoded for now, until we can get the margin values
from the QStyle (the same existent comment applies).
| BEFORE |![footer_before](/uploads/7ccc28ad71f29eca36a9a5a745c03eb6/footer_before.png)|
| ---|---|
| AFTER |![Screenshot_20220122_145735](/uploads/c879f898cb1651336da24a89c675c779/Screenshot_20220122_145735.png)|
@teams/vdg5.24