1. 19 Apr, 2020 1 commit
  2. 31 Mar, 2020 1 commit
  3. 10 Mar, 2020 1 commit
  4. 02 Mar, 2020 1 commit
  5. 25 Feb, 2020 1 commit
  6. 18 Feb, 2020 1 commit
  7. 17 Feb, 2020 1 commit
    • Filip Fila's avatar
      Have user-manager write to SDDM's new config file · b2d0e463
      Filip Fila authored
      Summary:
      user-manager still wants to write to sddm.conf and it's using sddm_kcm's function to do so, but this function no longer supports writing to sddm.conf
      
      That means auto-login settings are no longer getting saved anywhere.
      
      This patch tweaks user-manager to write to /etc/sddm.conf.d/kde_setings.conf, making the feature work again.
      
      Path specifying is removed on the user-manager side for writing, SDDM's auth helper does that now.
      
      BUG: 342722
      FIXED-IN: 5.18.1
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26813
      b2d0e463
  8. 06 Feb, 2020 1 commit
  9. 29 Jan, 2020 1 commit
    • Méven Car's avatar
      Fix new user creation · 184a544c
      Méven Car authored
      Summary:
      UserAdded was called only when other parameters were provided for a new user beside name and realname.
      Which could not happen since 2471fa7d and given the order the setData are called in accountinfo.cpp
      
      Alternative to D26977
      
      BUG: 416801
      FIXED-IN: 5.18
      
      Test Plan:
      Create a new user with a password
      in a terminal su new_user
      
      Reviewers: ngraham, davidedmundson, #plasma
      
      Reviewed By: davidedmundson, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26998
      184a544c
  10. 22 Jan, 2020 1 commit
    • Méven Car's avatar
      Consider empty email valid · 386f6771
      Méven Car authored
      Summary:
      BUG: 411736
      FIXED-IN: 5.18
      
      Test Plan:
      1. open system settings > account details > user manager
      2. type an email address to your user account
      3. click on "Apply" button, type your password and press enter/return to confirm
      4. close the User Manager and reopen it
      5. clear the email address field
      6. Apply
      
      The empty email is saved.
      
      Reviewers: #plasma, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26824
      386f6771
  11. 16 Jan, 2020 2 commits
  12. 26 Dec, 2019 2 commits
  13. 17 Dec, 2019 1 commit
  14. 16 Dec, 2019 1 commit
  15. 22 Nov, 2019 1 commit
    • Méven Car's avatar
      Don't CacheUser/UnCacheUser when editing Realname · a2f7d308
      Méven Car authored
      Summary:
      1d10226d and 83549151 introduced those lines to follow gnome-control-center example.
      Since then gnome-control-center does not call AccountService CacheUser UnCacheUser.
      
      BUG: 392943
      FIXED-IN: 5.18
      
      Test Plan:
      1. Open user-mananger `kcmshell5 user_manager`
      2. Ensure to set any picture for your user
      3. Add "1" to your Real name
      4. Click on Apply
      
      Before:
      The avatar for your account in the left list is resetted to default setting.
      
      After:
      Only the RealName has changed.
      
      Reviewers: ngraham, #plasma
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25439
      a2f7d308
  16. 21 Nov, 2019 1 commit
    • Méven Car's avatar
      Check values have changed before setting the model · b279882a
      Méven Car authored
      Summary:
      Only save data that needs to be saved and use sanitized data rather than raw text field input.
      
      BUG: 384894
      FIXED-IN: 5.18
      
      Test Plan:
      Edit Username -> have a PolicyKit password verification
      Edit Avatar -> no more password verification popup
      
      Reviewers: #plasma, ngraham, davidedmundson
      
      Reviewed By: #plasma, ngraham, davidedmundson
      
      Subscribers: ngraham, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25398
      b279882a
  17. 20 Nov, 2019 1 commit
  18. 07 Nov, 2019 1 commit
  19. 06 Nov, 2019 1 commit
  20. 05 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · b5da60d9
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      b5da60d9
  21. 13 Oct, 2019 1 commit
  22. 24 Sep, 2019 1 commit
  23. 19 Sep, 2019 3 commits
  24. 11 Sep, 2019 1 commit
  25. 10 Sep, 2019 1 commit
  26. 04 Sep, 2019 1 commit
  27. 23 Aug, 2019 1 commit
    • Méven Car's avatar
      Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses · 52ea204e
      Méven Car authored
      Summary:
      BUG: 328664
      
      The current behavior to change password is quite unfriendly to say the least.
      Clicking in a line field to open a dialog is not logical.
      Replace this with a much simpler button leading to the dialog.
      
      Test Plan:
      Compile
      kcmshell5 user_manager
      Tried changing your password
      Tried adding a user
      
      Before:
      {F7269649}
      
      After:
      
      {F7269690}
      
      Reviewers: #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
      
      Reviewed By: #plasma, ngraham, davidedmundson, #vdg, GB_2
      
      Subscribers: nicolasfella, GB_2, plasma-devel
      
      Tags: #plasma, #vdg
      
      Differential Revision: https://phabricator.kde.org/D23337
      52ea204e
  28. 22 Aug, 2019 1 commit
  29. 13 Aug, 2019 1 commit
  30. 05 Aug, 2019 1 commit
    • Harald Sitter's avatar
      use pwquality_strerror to get error strings · 29768b08
      Harald Sitter authored
      Summary:
      libpwquality has localized error string mappings, no need to reinvent
      the wheel here. the previous mapping was fairly incomplete resulting in
      cases where one would get the generic "use another password" option
      was shown, which is fairly meh as it can mean literally anything.
      
      should libpwquality for whatever reason fail to provide a string we will
      still fall back to the unfortunate generic default. better than nothing
      I suppose.
      
      also carry around auxerror. it contains data such as how many digits
      would have been reuired. auxerror doesn't need freeing it simply contains
      pointers to internals for the benefit of pwquality_strerror
      
      CHANGELOG: Password quality problems are better explained in the UI
      
      Test Plan: password 'a' now gets error'd as a palindrom rather than the generic error. other errors such as too-short, no-match continue to be reported properly as well
      
      Reviewers: #plasma, ltoscano
      
      Reviewed By: ltoscano
      
      Subscribers: rikmills, davidedmundson, ltoscano, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22122
      29768b08
  31. 03 Jul, 2019 2 commits
  32. 28 Jun, 2019 1 commit
  33. 23 Jun, 2019 2 commits
  34. 21 Jun, 2019 1 commit
    • Filip Fila's avatar
      Have more contrast in circle-style user avatars · 2d1514b4
      Filip Fila authored
      Summary:
      Our circular avatar currently don't have the best contrast between their background and main element, which is especially evident when using light themes.
      
      This patch raises the opacity of the background circle, making it more prominent.
      
      Test Plan:
      Before & After (Breeze):
      {F6920835}
      
      Before & After (Breeze Dark)
      {F6920836}
      
      Reviewers: #vdg, ngraham, ndavis
      
      Reviewed By: #vdg, ngraham, ndavis
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9910
      
      Differential Revision: https://phabricator.kde.org/D21926
      2d1514b4