1. 22 Nov, 2019 1 commit
    • Méven Car's avatar
      Don't CacheUser/UnCacheUser when editing Realname · a2f7d308
      Méven Car authored
      Summary:
      1d10226d and 83549151 introduced those lines to follow gnome-control-center example.
      Since then gnome-control-center does not call AccountService CacheUser UnCacheUser.
      
      BUG: 392943
      FIXED-IN: 5.18
      
      Test Plan:
      1. Open user-mananger `kcmshell5 user_manager`
      2. Ensure to set any picture for your user
      3. Add "1" to your Real name
      4. Click on Apply
      
      Before:
      The avatar for your account in the left list is resetted to default setting.
      
      After:
      Only the RealName has changed.
      
      Reviewers: ngraham, #plasma
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25439
      a2f7d308
  2. 20 Nov, 2019 1 commit
  3. 23 Aug, 2019 1 commit
    • Méven Car's avatar
      Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses · 52ea204e
      Méven Car authored
      Summary:
      BUG: 328664
      
      The current behavior to change password is quite unfriendly to say the least.
      Clicking in a line field to open a dialog is not logical.
      Replace this with a much simpler button leading to the dialog.
      
      Test Plan:
      Compile
      kcmshell5 user_manager
      Tried changing your password
      Tried adding a user
      
      Before:
      {F7269649}
      
      After:
      
      {F7269690}
      
      Reviewers: #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
      
      Reviewed By: #plasma, ngraham, davidedmundson, #vdg, GB_2
      
      Subscribers: nicolasfella, GB_2, plasma-devel
      
      Tags: #plasma, #vdg
      
      Differential Revision: https://phabricator.kde.org/D23337
      52ea204e
  4. 08 Jan, 2019 1 commit
  5. 19 Nov, 2018 1 commit
  6. 03 Sep, 2018 1 commit
  7. 03 Jul, 2018 1 commit
  8. 16 May, 2018 1 commit
    • Valeriy Malov's avatar
      Split replaceAccount from addAccountToCache · ff88e24e
      Valeriy Malov authored
      Summary:
      We were accidentally overwriting first account in the model with
      currently logged in user after polling AccountsService
      
      BUG: 336994
      
      Test Plan: check if kcmshell5 user_manager lists mutliple users on cold boot
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, ngraham, rdieter, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12837
      ff88e24e
  9. 15 May, 2018 1 commit
  10. 02 May, 2018 1 commit
    • Kirill Tatunov's avatar
      Enable anti-aliasing for user avatars · da05675b
      Kirill Tatunov authored
      Summary: By default, QT uses fast transformations when scaling pixmaps but it results in a very pixelated image. This patch fixes it for avatars in the user manager module.
      
      Test Plan:
      Resolution of the original avatar image is 256x256.
      Before: {F5819211}
      After: {F5819213}
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: abetts, davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12468
      da05675b
  11. 13 Dec, 2016 1 commit
    • David Edmundson's avatar
      Set Automatic login flag to adjust SDDM config directly · b154c752
      David Edmundson authored
      Summary:
      AccountsService is a bit weird, the automatic login flag adjusts a
      config file in /etc/gdm/
      
      This doesn't work for two reasons:
      1) SDDM (our Display Manager) obviously doesn't read this file
      2) AccountsService doesn't create the folder if it doesn't exist, so we
      can't even use if we tried.
      
      This patch adjusts UserManager to write /etc/sddm.conf directly. It's
      not ideal, but I think it's the only option we have, certainly in the
      short term.
      
      BUG: 363058
      
      Test Plan:
      Set automatic login on a user
      Restarted KCM, still set
      Set it on another user, config changed properly, old user was updated
      Unchecked it on my current user, config file was unset properly
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3658
      b154c752
  12. 06 Dec, 2016 1 commit
    • Harald Sitter's avatar
      Revert "Do not ask for root permissions when it's unnecessary" · f2c69db1
      Harald Sitter authored
      Summary:
      This reverts commit a6667121.
      
      This broke adding new users when not setting realname or adminflag (i.e.
      at present there is no way to create a !admin user at all).
      
      Distributions, as we are still 3 weeks away from 5.8.5 I'd advise patching
      this to restore working behavior for the time being.
      
      The problem in particular is that the model gobbles up setData requests to
      new rows and forwards them to newUserSetData which in turn caches them
      until username&realname&admin are present and only then forwards the call
      to accountsservice. By calling setData on-demand the three fields are not
      set unless they in fact all where "toggled" from their default.
      
      I suggest that the noop decision be moved into the setData itself. In there
      it should be possible to accurately decide whether or not the data
      actually changed and accountsservice needs to be called.
      
      (Ideally though IMO the collection in newUserSetData should be gotten
       rid of. I haven't had a close look, but creating the user with random
       data for everything but username and then manipulating it on the
       subsequent setData calls should be a more future-proof and reliable
       approach)
      
      BUG: 373276
      CCMAIL: kde-distro-packagers@kde.org
      CCMAIL: larrosa@kde.org
      PHAB: https://phabricator.kde.org/D3102
      
      Reviewers: davidedmundson, mart
      
      Subscribers: antlarr, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3605
      f2c69db1
  13. 24 Oct, 2016 1 commit
    • Antonio Larrosa Jimenez's avatar
      Do not ask for root permissions when it's unnecessary · a6667121
      Antonio Larrosa Jimenez authored
      Summary:
      Only save values that were really changed
      
      This allows to change settings without being asked for the root password
      to save things that weren't modified by the user, so the
      request for the root password was unnecessary.
      
      Remove unneeded UncacheUser/CacheUser calls
      
      Modifying the Real Name of the user was requesting the root password
      because of the calls to UncacheUser/CacheUser, since modifying the Real
      Name doesn't in fact need extra permissions. Also, none of the other
      properties call UncacheUser/CacheUser when they're being modified, so
      I tried removing the calls and it works much better here.
      
      Test Plan:
      I tested changing avatar and Real Name and looking at /etc/passwd and ~/.face
      that they were correctly changed while not getting any polkit dialog
      requesting the root password.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3102
      a6667121
  14. 21 Jul, 2016 1 commit
  15. 19 Jul, 2016 2 commits
  16. 31 Jul, 2015 1 commit
    • Jonathan Esk-Riddell's avatar
      Save settings with m_kEmailSettings as well to replace kcm_useraccounts · f4a899d5
      Jonathan Esk-Riddell authored
      add symlink in ~/.face.icon the file used by some login managers
      
      save settings with kemailsettings
      
      this allows us to stop shipping kcm_useraccounts which saved using
      this class to a file in ~/.config/emaildefaults
      
      also make an avatar link in ~/.face.icon which is used by some display managers
      
      BUG: 342631
      REVIEW: 124571
      f4a899d5
  17. 29 Jan, 2015 1 commit
  18. 26 Jun, 2014 1 commit
  19. 16 Feb, 2014 3 commits
  20. 22 Dec, 2013 5 commits
  21. 09 Oct, 2013 1 commit
  22. 04 Sep, 2013 1 commit
  23. 16 Aug, 2013 6 commits
  24. 10 Aug, 2013 1 commit
    • Àlex Fiestas's avatar
      Make the model emit dataChange on Face update · ed294e1f
      Àlex Fiestas authored
      In the model we are not updating the file, I don't
      see a clear way of doing this, so at the moment
      we are just notifying the change.
      
      This is a bit dirty. will clean once/if export
      the model.
      ed294e1f
  25. 18 Feb, 2013 1 commit
  26. 15 Feb, 2013 3 commits