1. 21 Nov, 2019 1 commit
    • Méven Car's avatar
      Check values have changed before setting the model · b279882a
      Méven Car authored
      Summary:
      Only save data that needs to be saved and use sanitized data rather than raw text field input.
      
      BUG: 384894
      FIXED-IN: 5.18
      
      Test Plan:
      Edit Username -> have a PolicyKit password verification
      Edit Avatar -> no more password verification popup
      
      Reviewers: #plasma, ngraham, davidedmundson
      
      Reviewed By: #plasma, ngraham, davidedmundson
      
      Subscribers: ngraham, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25398
      b279882a
  2. 20 Nov, 2019 1 commit
  3. 07 Nov, 2019 1 commit
  4. 06 Nov, 2019 1 commit
  5. 05 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · b5da60d9
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      b5da60d9
  6. 13 Oct, 2019 1 commit
  7. 24 Sep, 2019 1 commit
  8. 19 Sep, 2019 3 commits
  9. 11 Sep, 2019 1 commit
  10. 10 Sep, 2019 1 commit
  11. 04 Sep, 2019 1 commit
  12. 23 Aug, 2019 1 commit
    • Méven Car's avatar
      Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses · 52ea204e
      Méven Car authored
      Summary:
      BUG: 328664
      
      The current behavior to change password is quite unfriendly to say the least.
      Clicking in a line field to open a dialog is not logical.
      Replace this with a much simpler button leading to the dialog.
      
      Test Plan:
      Compile
      kcmshell5 user_manager
      Tried changing your password
      Tried adding a user
      
      Before:
      {F7269649}
      
      After:
      
      {F7269690}
      
      Reviewers: #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
      
      Reviewed By: #plasma, ngraham, davidedmundson, #vdg, GB_2
      
      Subscribers: nicolasfella, GB_2, plasma-devel
      
      Tags: #plasma, #vdg
      
      Differential Revision: https://phabricator.kde.org/D23337
      52ea204e
  13. 22 Aug, 2019 1 commit
  14. 13 Aug, 2019 1 commit
  15. 05 Aug, 2019 1 commit
    • Harald Sitter's avatar
      use pwquality_strerror to get error strings · 29768b08
      Harald Sitter authored
      Summary:
      libpwquality has localized error string mappings, no need to reinvent
      the wheel here. the previous mapping was fairly incomplete resulting in
      cases where one would get the generic "use another password" option
      was shown, which is fairly meh as it can mean literally anything.
      
      should libpwquality for whatever reason fail to provide a string we will
      still fall back to the unfortunate generic default. better than nothing
      I suppose.
      
      also carry around auxerror. it contains data such as how many digits
      would have been reuired. auxerror doesn't need freeing it simply contains
      pointers to internals for the benefit of pwquality_strerror
      
      CHANGELOG: Password quality problems are better explained in the UI
      
      Test Plan: password 'a' now gets error'd as a palindrom rather than the generic error. other errors such as too-short, no-match continue to be reported properly as well
      
      Reviewers: #plasma, ltoscano
      
      Reviewed By: ltoscano
      
      Subscribers: rikmills, davidedmundson, ltoscano, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22122
      29768b08
  16. 03 Jul, 2019 2 commits
  17. 28 Jun, 2019 1 commit
  18. 23 Jun, 2019 2 commits
  19. 21 Jun, 2019 2 commits
    • Filip Fila's avatar
      Have more contrast in circle-style user avatars · 2d1514b4
      Filip Fila authored
      Summary:
      Our circular avatar currently don't have the best contrast between their background and main element, which is especially evident when using light themes.
      
      This patch raises the opacity of the background circle, making it more prominent.
      
      Test Plan:
      Before & After (Breeze):
      {F6920835}
      
      Before & After (Breeze Dark)
      {F6920836}
      
      Reviewers: #vdg, ngraham, ndavis
      
      Reviewed By: #vdg, ngraham, ndavis
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9910
      
      Differential Revision: https://phabricator.kde.org/D21926
      2d1514b4
    • Noah Davis's avatar
      Add new Konqi avatars & remove classic, bluestyle, old konqi avatars · 8be2414e
      Noah Davis authored
      Summary: The Konqi mascots are so good, we might as well use them. Our existing avatars are not so good, so I'm removing them.
      
      Test Plan:
      {F6920004, size=full}
      
      1. Copy images to `/usr/share/user-manager/avatars/konqui/`
      2. Select a Konqi user icon from the gallery in the user_manager KCM.
      
      Reviewers: #vdg, #plasma, ngraham, filipf
      
      Reviewed By: #vdg, ngraham, filipf
      
      Subscribers: filipf, GB_2, ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9910
      
      Differential Revision: https://phabricator.kde.org/D21939
      8be2414e
  20. 19 Jun, 2019 1 commit
  21. 12 Jun, 2019 1 commit
  22. 03 Jun, 2019 2 commits
  23. 16 May, 2019 3 commits
  24. 12 May, 2019 1 commit
  25. 09 May, 2019 1 commit
  26. 21 Apr, 2019 1 commit
    • Björn Feber's avatar
      Rename colorful user gallery avatar · 774c4c62
      Björn Feber authored and Björn Feber's avatar Björn Feber committed
      Summary: In D20536 we rename the colorful user avatar to `user-man`. This patch changes that avatar to the name "Man" to match the new name.
      
      Test Plan: Open the avatar gallery.
      
      Reviewers: #plasma, #vdg, ngraham, afiestas, broulik, davidedmundson
      
      Reviewed By: #plasma, #vdg, ngraham, davidedmundson
      
      Subscribers: davidedmundson, ngraham, #vdg, plasma-devel, #plasma
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20564
      774c4c62
  27. 01 Mar, 2019 1 commit
  28. 16 Feb, 2019 1 commit
  29. 06 Feb, 2019 1 commit
    • Nate Graham's avatar
      Use colorful icon in KCM · a7141be3
      Nate Graham authored
      Summary:
      Use a nice new colorful icon.
      
      Master only since this icon is provided by a symlink created in Frameworks 5.56.
      
      CCBUG: 386748
      
      Test Plan:
      Before: {F6592327, size=full}
      After: {F6592328, size=full}
      
      Reviewers: #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18800
      a7141be3
  30. 17 Jan, 2019 3 commits