Commit 184a544c authored by Méven Car's avatar Méven Car
Browse files

Fix new user creation

Summary:
UserAdded was called only when other parameters were provided for a new user beside name and realname.
Which could not happen since 2471fa7d and given the order the setData are called in accountinfo.cpp

Alternative to D26977

BUG: 416801
FIXED-IN: 5.18

Test Plan:
Create a new user with a password
in a terminal su new_user

Reviewers: ngraham, davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26998
parent 386f6771
......@@ -334,13 +334,13 @@ bool AccountModel::newUserSetData(const QModelIndex &index, const QVariant& valu
m_newUserData.remove(Username);
m_newUserData.remove(RealName);
UserAdded(reply.value());
//If we don't have anything else to set just return
if (m_newUserData.isEmpty()) {
return true;
}
UserAdded(reply.value());
QHash<AccountModel::Role, QVariant>::const_iterator i = m_newUserData.constBegin();
while (i != m_newUserData.constEnd()) {
qCDebug(USER_MANAGER_LOG) << "Setting extra:" << i.key() << "with value:" << i.value();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment