Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 8defbd16 authored by David Edmundson's avatar David Edmundson

Don't show a region selector when selecting avatars from a gallery

Summary:
Prompting the user for a region makes sense when loading from a file,
but not from the gallery.

CreateAvatarJob does two things:
- copies from KIO
- goes via a KPixmapRegionSelector and saves to a local file

We know the gallery files are locally mounted, and we don't want the
region selector so we can just skip the job completely.

Test Plan:
Set avatar from file. Got prompt, saved properly
Set avatar from gallery. Skipped prompt, saved properly

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7686
parent 97bae15c
......@@ -405,10 +405,10 @@ void AccountInfo::openGallery()
return;
}
CreateAvatarJob *job = new CreateAvatarJob(this);
connect(job, &KJob::finished, this, &AccountInfo::avatarCreated);
job->setUrl(gallery->url());
job->start();
QString path = gallery->url().toLocalFile();
m_info->face->setIcon(QIcon(path));
m_infoToSave.insert(AccountModel::Face, path);
Q_EMIT changed(true);
}
QStringList AccountInfo::imageFormats() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment