Aleix Pol Gonzalez authored May 28, 2022 and Aleix Pol Gonzalez committed May 30, 2022

We were just forgetting about it.

Aleix Pol Gonzalez authored May 28, 2022 and Aleix Pol Gonzalez committed May 30, 2022

At the moment we had a global m_streams that we filled per request and
provided at bulk. If we had a running session and in parallel started
another one, we'd get both streams. Not good.

It contains an important workaround for attachments with Thunderbird

BUG: 454128

Harald Sitter authored May 23, 2022 and Aleix Pol Gonzalez committed May 23, 2022

snuck in with recent ui refinements I think, the i18n string has no %N
placeholder so the argument is superfluous

GIT_SILENT

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Sets it as active, otherwise it got buried in the extended view of the
system tray.

BUG: 452980

Qt6 requires the protocol file name matching the protocol name, otherwise
we end up with invalid code. This has been fixed in the latest Plasma
Wayland protocols.

Aleix Pol Gonzalez authored Apr 21, 2022 and Aleix Pol Gonzalez committed May 04, 2022

It will add an output in KWin with FullHD resolution at 1x scaling, it's
up to users to place it however they like. They'll get the OSD to place
it as desired.

Aleix Pol Gonzalez authored Apr 21, 2022 and Aleix Pol Gonzalez committed May 04, 2022

Instead of gathering all the possible states it could have, just pass it
the information it needs and let the caller decide how data should be
displayed.

This commit introduces a series of inter-related changes that combine
together to overhaul and modernize the UI, and make it more visually and
functionally consistent with other KDE UIs.

Here are the individual changes:

* Merge the top two pieces of text into one, and use it as the the
  dialog's title
* Move the search field and "show all apps" button to the top, since
  they're both scope selectors
* Make the search field filter all visible items in the view, not just
  non-preferred apps
* Mark the default app using bold text, not a background highlight that
  can mislead you into thinking it has keyboard focus (but it does not)
* When grid delegates are hovered, show a normal-style highlight effect
  rather than changing the cursor shape
* Move the "find more apps" message to the bottom to support a normal
  top-to-bottom flow: first you choose your scope (or not), then you
  look for the app, then if you don't find one, you can use Discover to
  search for more
* Add a placeholder message when the view is empty, either because
  no relevant apps are installed or because no apps matched the user's
  search text

It's only used once so we don't need to put it in a separate component
that's named but never explicitly referred to.

Otherwise it inherits the default value which looks similar to
Kirigami.Units.smallSpacing, but it's not exactly the same.

These are lighter weight and more future-proof.

The user always needs to choose.

This way we don't need to manufacture our own custom background that
won't respect the active theme.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

this actually was defective even with local urls...
as we pass files through the portal the sandbox gets irrelevant portal
paths a la /run/foo/bar/yolo.txt when the sandbox then gives us that
path back, the directory isn't meant to be written to, much less shown
to the user to begin with.

to deal with this scenario we now do a reverse resolution dance on
savefile. notably we first ask the portal to translate the portal file
name in /run to the actual file name underneath it. we then run that
path through kio-fuse in case it was fuse mounted

this renders /run to /home/foo/yolo.txt or when it was fuse mounted for
example smb:///foo/yolo.txt

the effective end result is that when you open a file in okular from a
samba share and then save-as, the file save dialog will show the smb://
url not the fake /run url

BUG: 452968

Minor build system changes, missing includes, a changed return type
of D-Bus type registration.

With this there is only one remaining issue, the generated screencast
Wayland client code is broken (same as in all other modules using this).

Error messages are now available as signal directly, considerably
simplifying this.

this ensures that the dialog goes away when the app disappears while the
dialog is still up (e.g. when ctrl-c'ing the app)

this simply refactors the existing Request code to correctly register on
the path and then emit the closerequest that gets routed to the ::reject
function of the dialog. for extra flexibility this is implemented as a
template such that the concrete type doesn't matter so long as it has a
reject slot.

BUG: 386385

this portal enables sandboxed applications to create desktop entries on
the host

BUG: 451510

so it may be used by more portals than just notification

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Currently, the view options are only saved when the user clicks OK or Cancel button. This MR makes the file dialog to write view options even if the user closes the window in any other way.