Skip to content

ScreenChooserDialog: enable arrow key navigation

Christoph Wolk requested to merge cwo/xdg-desktop-portal-kde:scd-keynav into master

The Cards in the Output and Applications tabs of the ScreenChooserDialog can be accessed with the tab key, but not using the arrow keys.

This change adds arrow key navigation within the card grid, and between the grid, the tab bar (if visible), and the checkbox at the bottom.

This MR makes arrow navigation work, but the ScrollView does not automatically follow keyboard focus yet. If frameworks/kirigami!1698 (merged) is merged, the ScrollViews could be replaced with ScrollablePages and the fix would be trivial; if not, porting the approach shouldn't be too hard either.

The handleArrowKeys function could be moved to Kirigami (maybe as a method of CardsLayout? Not sure where a good place would be); it's general enough that simple use of a CardsLayout that wants arrow key navigation could reuse most of it. Going by LXR though, there only seem to be two users of CardsLayout right now that might want this, and the implementation in Discover (discover!1004 (merged)) would need special handling for up/down anyway, as the Layout is much more complicated there. So I'm not sure how much benefit there is to adding API to Kirigami.

Merge request reports