Pranav Gade (e8db839c) at 10 Apr 05:18
refactored frame_p.h
Pranav Gade (65ac4039) at 09 Apr 15:21
moved vector creation to constructor
Using QVector<Polygon*>()
instead of *(new QVector<Polygon*>
) results in the following compiler error:
mark/src/video/videopainter.cpp:21:74: error: cannot bind non-const lvalue reference of type ‘QVector<Polygon*>&’ to an rvalue of type ‘QVector<Polygon*>’
21 | m_currentFrame = new Frame(m_parent->currentObject()->objClass(), 0, QVector<Polygon*>());
| ~^~~~~~~~~~~~~~~~~~~~
Could you highlight some places that need fixing?
I'll try and see how it looks. Meanwhile, can I squash the commits to prepare for merging?
Pranav Gade (f3034b58) at 07 Apr 17:57
refactoring
Ah I see, any ideas on how to design that? More buttons?
Since I will just write wrappers around QMap methods, this seems more efficient and less cluttered.
Is there anything wrong here?
Pranav Gade (ef06afb1) at 07 Apr 17:03
refactoring
I added buttons to change framerate, but I'm not good at design so I just added them to the right of the seekbar. Do let me know if you think they can be placed better elsewhere.
Okay, I updated it accordingly.
Pranav Gade (8abf585a) at 07 Apr 14:52
refactoring
Pranav Gade (5fbc623f) at 07 Apr 10:11
added options to change playback rate
Pranav Gade (64eb7286) at 07 Apr 05:33
made control buttons look better
Pranav Gade (e09c5ee7) at 07 Apr 05:09
added margin/spacing to buttons
Pranav Gade (de81af94) at 07 Apr 05:00
fixed edge case in exporting json
Ah I see what you mean! I do think that it would be unnecessary, as we will never use it as a MarkedObject, as we have(at most) one permanant map, and one temporary one. I also don't think that moving map manipulation into another method is necessary, as it is used only once, and isn't large enough to justify breaking into smaller methods.
Pranav Gade (0706f40a) at 06 Apr 19:28
refactored to use Frame instes of Vector
Ah I see. I had tried that, and it looked like it wasn't good for performance (it lagged quite a bit every time it had to draw a frame that had annotation data with it)
However, if you drag the seek bar, it does show the frames in that case.