1. 14 May, 2020 1 commit
  2. 12 May, 2020 3 commits
  3. 11 May, 2020 2 commits
  4. 06 May, 2020 2 commits
  5. 05 May, 2020 1 commit
  6. 29 Apr, 2020 2 commits
  7. 27 Apr, 2020 1 commit
    • Volker Hilsheimer's avatar
      Remove deprecated members from several QtGui classes · dccf28b7
      Volker Hilsheimer authored
      
      
      Those can be trivially removed as they have direct replacements, or
      are completely unused.
      
      The migration path for QCursor::bitmap and QCursor::mask is
      
      QBitmap *pb = c.bitmap(); // up to 5.15, warns in 5.15
      QBitmap vb = c.bitmap(Qt::ReturnByValue); // from 5.15, works in 6
      QBitmap b = c.bitmap(); // from 6.0 on
      
      Change-Id: I3b3acd1c7f09c4c8414e98b3ce11986f1ecd5eda
      Reviewed-by: default avatarShawn Rutledge <shawn.rutledge@qt.io>
      dccf28b7
  8. 17 Apr, 2020 1 commit
  9. 15 Apr, 2020 2 commits
  10. 09 Apr, 2020 2 commits
  11. 27 Mar, 2020 1 commit
    • Eirik Aavitsland's avatar
      Raster painting: fix dashing for separate lines · 533f7d7c
      Eirik Aavitsland authored
      
      
      When drawing multiple distinct (unconnected) lines (e.g. from
      QPainter::drawLines() or a QPainterPath with alternating
      movetos/linetos), the dash pattern should not continue from one to the
      next, as it should when drawing a connected line (e.g. polyline).
      Both the cosmetic stroker and the full stroker does it right, but the
      fast rasterizing codepath got it wrong.
      
      Fixes: QTBUG-83048
      Change-Id: I3d090f7121726755a0e53cb66b99a5563ac0e1c0
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      533f7d7c
  12. 25 Mar, 2020 1 commit
    • Giulio Camuffo's avatar
      Fix memory leak · b15ed929
      Giulio Camuffo authored
      
      
      When creating a new QColorSpacePrivate it must be reffed otherwise in
      the destructor the deref() will bring the count to -1 which is true
      and will not delete the d_ptr.
      
      Change-Id: Id569bae22134b56bf6ad37158d7079b495599fd7
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      (cherry picked from commit 20eabb72)
      b15ed929
  13. 24 Mar, 2020 1 commit
  14. 23 Mar, 2020 2 commits
    • Volker Hilsheimer's avatar
      Fix deprecation warnings from NSColor(Space) with macOS 10.14 SDK · c14f3dec
      Volker Hilsheimer authored
      
      
      The support for handling color spaces by names is deprecated in
      recent AppKit versions, and should be replaced by using
      NSColor.type, and operations on the type-specific properties of
      the color.
      
      Merge the two implementations from qcoregraphics.mm and
      qcocoacolordialoghelper.mm, which also fixes the inconsistent
      interpretation of color components as device dependent (in
      qcoregraphics) or generic (in qcocoacolordialoghelper). We now
      always populate the QColor with device independent components.
      
      Change-Id: Id79c609736ff1962bebe4bd7158781a6d1b4475e
      Reviewed-by: default avatarTor Arne Vestbø <tor.arne.vestbo@qt.io>
      c14f3dec
    • Giulio Camuffo's avatar
      Fix memory leak · 20eabb72
      Giulio Camuffo authored
      
      
      When creating a new QColorSpacePrivate it must be reffed otherwise in
      the destructor the deref() will bring the count to -1 which is true
      and will not delete the d_ptr.
      
      Change-Id: Id569bae22134b56bf6ad37158d7079b495599fd7
      Reviewed-by: default avatarAllan Sandfeld Jensen <allan.jensen@qt.io>
      20eabb72
  15. 20 Mar, 2020 2 commits
  16. 19 Mar, 2020 1 commit
    • Allan Sandfeld Jensen's avatar
      QDrawHelper cleanups · cfbe4818
      Allan Sandfeld Jensen authored
      
      
      We don't need to handle solid SourceOver logic directly, this was
      already handled by getOperator and changed composition to Source.
      
      Also removes some dead code and changes an assert in unreachable
      code to Q_UNREACHABLE.
      
      Change-Id: I66a6c1248bd34e31096023f1acb20385099932c9
      Reviewed-by: default avatarEirik Aavitsland <eirik.aavitsland@qt.io>
      cfbe4818
  17. 14 Mar, 2020 1 commit
  18. 12 Mar, 2020 2 commits
    • Tor Arne Vestbø's avatar
      macOS: Streamline QIcon to NSImage conversion · bee3d0fc
      Tor Arne Vestbø authored
      
      
      The conversion uses NSBitmapImageRep and correctly sets the display
      pixel ratio and size of the resulting image, reducing the need for
      clients to deal with this.
      
      It also propagates the isMask property of the icon to the NSImage.
      
      The function returns an auto-released object, as is customary for
      class-functions like these.
      
      Change-Id: If97f3d383959cd0f58a0d1249f5c26e52c1da9cd
      Reviewed-by: default avatarTimur Pocheptsov <timur.pocheptsov@qt.io>
      bee3d0fc
    • Tor Arne Vestbø's avatar
      macOS: Streamline QImage to NSImage conversion · 52e9c8b4
      Tor Arne Vestbø authored
      
      
      The conversion uses NSBitmapImageRep and correctly sets the display
      pixel ratio and size of the resulting image, reducing the need for
      clients to deal with this.
      
      The function returns an auto-released object, as is customary for
      class-functions like these.
      
      Change-Id: I5124d1d8145a7f5266921b22fda1987798771ec1
      Reviewed-by: default avatarTimur Pocheptsov <timur.pocheptsov@qt.io>
      52e9c8b4
  19. 09 Mar, 2020 1 commit
  20. 06 Mar, 2020 1 commit
  21. 28 Feb, 2020 2 commits
  22. 20 Feb, 2020 2 commits
  23. 17 Feb, 2020 1 commit
  24. 15 Feb, 2020 1 commit
  25. 12 Feb, 2020 1 commit
  26. 07 Feb, 2020 2 commits
    • Jarek Kobus's avatar
      Replace the QMatrix field of QTransform with qreal[3][3] · e14e5e10
      Jarek Kobus authored
      
      
      Remove temporarily the reference returned by QTransform::toAffine()
      since we don't keep the QMatrix object internally anymore.
      This is done in order to compile the rest of the code.
      The follow-up patch is going to remove that method completely.
      
      Task-number: QTBUG-81628
      Change-Id: If7140eedb7582d81ac8da529017cf792174e86ab
      Reviewed-by: default avatarLars Knoll <lars.knoll@qt.io>
      e14e5e10
    • Eskil Abrahamsen Blomfeldt's avatar
      Make text decorations consistent between ways of drawing text · 78da1028
      Eskil Abrahamsen Blomfeldt authored
      
      
      The drawGlyphRun() and drawStaticText() functions would calculate
      the horizontal origin of the decorations based on the left-most edge
      of the left-most glyph, in practice including the left bearing of
      that glyph in the position. But in drawText()/QTextLayout it will
      always be drawn from the position given as input by the user of the
      function.
      
      The inconsistency was detected in an upgrade of Harfbuzz NG, where
      the tests on macOS would get a -0.05 left bearing, and as a result
      the decorations would be painted one pixel to the left in
      drawGlyphRun()/drawStaticText() compared to QTextLayout.
      
      It is not a big deal in practice, but in order to get the Harfbuzz
      update in, we fix the inconsistency now, by passing the user-input
      position into the decoration function.
      
      This was also an opportunity to consolidate the two code paths, and
      to unexport the qt_draw_decoration_for_glyphs() symbol, which was
      exported in Qt 4 only to be usable by Qt Quick 1.
      
      Change-Id: I243404b2710ae378e84d7587efae719da3879944
      Reviewed-by: default avatarLars Knoll <lars.knoll@qt.io>
      78da1028
  27. 03 Feb, 2020 1 commit
    • Johan Klokkhammer Helsing's avatar
      Move backing store OpenGL support to the platformcompositor module · a13e8d66
      Johan Klokkhammer Helsing authored
      
      
      QPlatformBackingStore had a dependency on the QOpenGLTextureBlitter, which is a
      problem because we want to get rid of all the public QOpenGL* classes in the
      gui module.
      
      This splits the heavily QOpenGL dependent parts of the backing store
      implementation into a separate class and moves it to the platformcompositor
      module.
      
      qplatformbackingstore.cpp is now mostly free from OpenGL implementation
      details.
      
      Platform integrations now have to explicitly request backing store OpenGL
      support. This has been done for:
      
      - xcb
      - windows
      - cocoa
      - winrt
      - android
      - wasm
      - ios
      
      QPlatformGraphicsBufferHelper::lockAndBindToTexture is now exported so it can
      be used from other modules.
      
      Task-number: QTBUG-74409
      Change-Id: I42ad9250e5a424939cf751a8ad880c7381ede2ae
      Reviewed-by: default avatarLaszlo Agocs <laszlo.agocs@qt.io>
      Reviewed-by: default avatarQt CI Bot <qt_ci_bot@qt-project.org>
      a13e8d66