- 04 Feb, 2023 5 commits
-
-
Christian Ehrlicher authored
This ensures the tst_QSqlQuery::record() test passes when checking the tablename. Pick-to: 6.5 6.4 6.2 5.15 Change-Id: I146f9f627ea366c6813af61ce48b930ca1041b15 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Christian Ehrlicher authored
Cleanup the codebase a little bit: - move loop variable into for scope - use utils functions instead homebrew - avoid use of const_cast<> - simplify splitTableQualifier() Change-Id: I6962f01c94a6b4e0e38ad1b229cdf6e8b3308c78 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Christian Ehrlicher authored
Avoid an unneeded copy in toSQLTCHAR() when sizeof(SQLTCHAR) == 1 or 4 by directly writing the encoded data into the QVarLengthArray. Change-Id: Ic4180343764fa1ca175a9cdd444c5359d664c754 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Ahmad Samir authored
Change-Id: I158cb1a2c6245b07891201bd767f3a4398a885fb Reviewed-by:
Edward Welbourne <edward.welbourne@qt.io>
-
Axel Spoerl authored
QSettings was included but not needed. This patch removes the include. Pick-to: 6.5 Change-Id: I9da146312f26f87eb863d6409b90988603cf46d3 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@qt.io>
-
- 03 Feb, 2023 13 commits
-
-
Mikolaj Boc authored
Change-Id: I31c72bcfff62efb28672d7740bf1096878c88cae Reviewed-by:
Aleksandr Reviakin <aleksandr.reviakin@qt.io> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Mikolaj Boc authored
Change-Id: I37b8b4c4d6b717d5fcd32b0793c2209850747085 Reviewed-by:
Aleksandr Reviakin <aleksandr.reviakin@qt.io> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Friedemann Kleint authored
They cause clashes in CMake Unity (Jumbo) builds. Pick-to: 6.5 Task-number: QTBUG-109394 Change-Id: I3c51fb41d29e5c649537b999dced7e2d413b26a7 Done-with: Amir Masoud Abdol <amir.abdol@qt.io> Reviewed-by:
Axel Spoerl <axel.spoerl@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Amir Masoud Abdol <amir.abdol@qt.io>
-
Roland Pallai authored
The problem is `PropertyNotify` event generated by `xcb_delete_property()` at return could be reported as an actual timestamp at next call due to a missing `state` filter. Because `PropertyNotify` is generated even if an unchanged property value is set we can get rid of this delete event easily. This issue causes observable problems in kwin_x11 (KDE project) too. Fixes: QTBUG-56595 Pick-to: 5.15 6.2 6.4 6.5 Change-Id: Ice6cfa934e3769d86e9f7264e369dc5918c8542a Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> Reviewed-by:
Liang Qi <liang.qi@qt.io> Reviewed-by:
JiDe Zhang <zhangjide@uniontech.com>
-
Axel Spoerl authored
Failing test functions fastMove, moveAccross, moveInOutOverlapped seem to be stable in the meanwhile. This patch removes the blacklisting. Task-number: QTBUG-109036 Pick-to: 6.5 Change-Id: I9a2b015572e4d8a4eac196d3985c052030fd84e2 Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Morten Sørvig authored
The html accessibility elements are positioned relative to the window a11y container. Convert the global (screen) coordinates we get from QAccessibleIntreface::rect() to window coordinates. Pick-to: 6.5 Change-Id: Ifd4eb671def296b1eb418789b7ca85afa365e546 Reviewed-by:
Mikołaj Boc <Mikolaj.Boc@qt.io>
-
Morten Sørvig authored
The code was a assuming that an a11y interface always has a parent, which is not the case for the root interface. Also factor out to a getWindow() function, to prepare for re-use later on. Pick-to: 6.5 Change-Id: I52a841bf94c712deb9603e8b9c2c878820c5f117 Reviewed-by:
Mikołaj Boc <Mikolaj.Boc@qt.io>
-
Morten Sørvig authored
We don't want to make the top-level screen contenteditable, since that interferes with accessibility. Instead, make the canvas contenteditable and install clipboard event handlers there. Also move follow-up settings which counters some of the effects contenteditable (outline: none and inputmode: none), and move aria-hidden. Pick-to: 6.5 Change-Id: Ibe73d8d097acd948ba8920c781a2003db0a14f3d Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Mikolaj Boc authored
Since 32666691 , icons have been set manually on img elements. The css code assigning the icons to elements is now unused - remove it. Change-Id: I394f08371c80f0e374a5cc7e39d17bb6091d18dc Reviewed-by:
Aleksandr Reviakin <aleksandr.reviakin@qt.io> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
Edward Welbourne authored
The new name better matches the names of existing functions there. A comment on the old code noted that such a move should really be done, so as to correctly share the environment-mutex locking. In the process, move the (now three) time-related internal functions from qglobal_p.h to a new qtenvironmentvariables_p.h since that's the natural place for them given where they're defined (and the fact that they're for internal use only). Change-Id: Ib028baebaf31a806a2c0c97caaaba0a466c11cea Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Edward Welbourne authored
Experiment reveals that we needs to, despite hints in localtime_s()'s docs that seem to indicate it shouldn't be needed. In the process document that POSIX mandates that plain localtime() behaves as if it did call tzset(), since its branch of the #if-ery is now the odd one out. Pick-to: 6.5 Fixes: QTBUG-109974 Change-Id: Ic57753f246f14e183d2a56f131e8bed7347d2e20 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com> Reviewed-by:
Mårten Nordheim <marten.nordheim@qt.io>
-
Mårten Nordheim authored
Pick-to: 6.5 Task-number: QTBUG-110333 Change-Id: I741feee3a19d0a104496f543d35a1f311a7228d6 Reviewed-by:
Ievgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io> Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io>
-
Mikolaj Boc authored
QWasmWindow is now implementing the setMask method, which translates the received QRegion to a css clip path Fixes: QTBUG-73260 Change-Id: Ie934c1e6ab650426bfc32154bf9e49a4a2aeb45b Reviewed-by:
Aleksandr Reviakin <aleksandr.reviakin@qt.io> Reviewed-by:
Morten Johan Sørvig <morten.sorvig@qt.io>
-
- 02 Feb, 2023 22 commits
-
-
Tasuku Suzuki authored
Add QT_FEATURE_SETTINGS to the android deployment conditions. Pick-to: 6.5 6.4 Change-Id: I7721a06733becba65b6d1e8112fa8afb0b64e120 Reviewed-by:
Axel Spoerl <axel.spoerl@qt.io> Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org>
-
Marc Mutz authored
Fix several issues in 72c2cdbc , which I was too slow to review before it went in: - use the correct feature macro, not __cplusplus - use the correct signature (return T*, not void) - don't make the function static - add a comment mentioning the material difference to std::construct_at - drop unneeded <qxptype_traits.h> include Pick-to: 6.5 Task-number: QTBUG-109394 Change-Id: I39d1908f565b1c1a31d5741924ac173447ec9057 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Marc Mutz authored
Unlike Q_GLOBAL_STATIC, a Q_APPLICATION_STATIC can be destroyed and re-created multiple times (if QCoreApplication is, too). This means we're basically in the std::optional case and require std::launder() to avoid UB when the payload type has either of the following: - a const member - a reference member - a vtable and different derived classes might be occupying the same space at different times While we can probably exclude the latter, because we always construct the same type, PlainType, in the storage, the first two can easily happen. Fix by adding the missing std::launder(). As a drive-by, remove the uneeded casting (and now launder()ing) of &storage when passing to innerFunction(), which anyway takes its argument as void*. Amends 81a31bee , which changed Q_APPLICATION_STATIC to use inline aligned_union storage instead of the original implementation's unique_ptr. Pick-to: 6.5 6.4 Change-Id: I065bd33812a40195109bf11d5bc79975f2f87cd5 Reviewed-by:
Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Friedemann Kleint authored
They cause clashes in CMake Unity (Jumbo) builds. Pick-to: 6.5 Task-number: QTBUG-109394 Change-Id: I5f1fbee07872a742a78adc9864fe00c710ca24d0 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Thiago Macieira authored
Pick-to: 6.4 6.5 Change-Id: I570832c9ac8b4e03bde8fffd173f7e743f42f22b Reviewed-by:
David Faure <david.faure@kdab.com>
-
Thiago Macieira authored
We must check that the path is an actual file on the filesystem before using native APIs. This regression was introduced by commit 047d8f36 . [ChangeLog][QtCore][QMimeDatabase] Fixed a regression from 6.4.0 that made certain QMimeDatabase functions that inspected file contents to fail on Unix systems, if the file was not a native file (e.g., a Qt resource). Fixes: QTBUG-110707 Pick-to: 6.4 6.5 Change-Id: I570832c9ac8b4e03bde8fffd173f7b4c6b164192 Reviewed-by:
Igor Kushnir <igorkuo@gmail.com> Reviewed-by:
David Faure <david.faure@kdab.com>
-
Thiago Macieira authored
This test is calling mimeTypeForFileNameAndData(), so it doesn't actually use the files. Change-Id: I570832c9ac8b4e03bde8fffd173f77f138ef3434 Reviewed-by:
Igor Kushnir <igorkuo@gmail.com> Reviewed-by:
David Faure <david.faure@kdab.com>
-
David Faure authored
BEFORE: 0.21 msecs per iteration (total: 56, iterations: 256) 801,946 CPU cycles per iteration (total: 801,946, iterations: 1) AFTER: 0.084 msecs per iteration (total: 87, iterations: 1024) 300,259 CPU cycles per iteration (total: 300,259, iterations: 1) Change-Id: I5b2703c217bb25e18f1d9f6a1eda19c60e1edcb0 Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-
Tor Arne Vestbø authored
The location permissions database in /var/db/locationd/clients.plist ties the location permission to the bundle identifier (among other things), so a missing bundle identifier will result in the app asking repeatedly for the location permission, as the permission is never saved. Pick-to: 6.5 Change-Id: I64ab5b8f8762804869c0f97debd97da817787808 Reviewed-by:
Juha Vuolle <juha.vuolle@qt.io>
-
Mårten Nordheim authored
It gets hard to read like that. And update mentions of 'SSL' to 'TLS' in the message while we're there. Task-number: QTBUG-108874 Pick-to: 6.5 Change-Id: Ia7b27bfb3d99391b14ed396ca9a6400621022bf6 Reviewed-by:
Marc Mutz <marc.mutz@qt.io>
-
Alexey Edelev authored
This reverts commit d7e8d5bb . Reason for revert: Found a working solution for the issue. Change-Id: Ia720cc63ece9dfb1a24067cdd9c3d79d4edbe3be Reviewed-by:
Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by:
Assam Boudjelthia <assam.boudjelthia@qt.io>
-
Jan Arve Sæther authored
Guidelines: https://wiki.qt.io/Qt6/Example-Guideline Pick-to: 6.5 Change-Id: I12c65ae11e7906fd2e9dfb449072199560488aed Reviewed-by:
Oliver Eftevaag <oliver.eftevaag@qt.io>
-
Edward Welbourne authored
Change-Id: I43bf3bf448792bfac05dccb8b57047b264dfb269 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Ulf Hermann authored
When calling a ctor this way, an object is created in the memory pointed to by _a[0] using the other arguments for the ctor. This allows separate allocation and initialization of an object through the metaobject system. Fixes: QTBUG-108879 Change-Id: Ifb154373ee42faab281cfb62aa14334980ec6b7d Reviewed-by:
Fabian Kosmale <fabian.kosmale@qt.io>
-
Ahmad Samir authored
The QChar::toLatin1() args in: str.replace(index, len, QChar(after[0]).toLatin1()) s2.replace(ch.toLatin1(), after, cs) will be converted to QChar, so it's always calling the same QString overload, I argue that we're not testing QChar implicit conversions here. Change-Id: I3962cab2b34684f970638575e6bd15dd1067a8c6 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Santhosh Kumar authored
Windows theme in dark mode set dark palettes for checkbox, radiobutton, menu, menubar explicitly. The fix added as part of a2518b41 (to use light palette for windows style) overrides only system palette and widget specific palettes are still with dark palettes. In this patch, the windows style overwrite dark with light palette for widgets that are explicitly set with dark palette in windows theme. Fixes: QTBUG-110432 Pick-to: 6.5 Change-Id: I2af0e517d62981f062244eeab8f1b5e5442cc451 Reviewed-by:
Volker Hilsheimer <volker.hilsheimer@qt.io>
-
Laszlo Agocs authored
...as suggested by review comments. Switching to std::function implies that we cannot easily do the install-remove pattern anymore as there is no way to compare an std::function to something other than null. Instead of making it more complicated by returning a key or something like that, change the remove function to a clear (that now clears both the legacy VK_EXT_debug_report and the new VK_EXT_debug_utils callback lists). Also add a missing call that registers the new-style callbacks that are installed before create(). Pick-to: 6.5 Change-Id: I66c1dd8e8dcc8eee0f5eb9671f94c2c80319dcaf Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Kristoffer Skau <kristoffer.skau@qt.io> Reviewed-by:
Christian Strømme <christian.stromme@qt.io>
-
Ahmad Samir authored
Also change isAsciiDigit() to take a char32_t, so that something like this works: QChar ch; isAsciiDigit(ch.unicode()) casting char16_t to uchar is narrowing, and gives weird results. C.f. QSettingsPrivate::iniEscapedKey() and the QSettings unittests which uses some unicode characters. Task-number: QTBUG-110403 Change-Id: Id978a6b2874bc6869ae3ffb28d1887d932c37782 Reviewed-by:
Thiago Macieira <thiago.macieira@intel.com>
-
Sze Howe Koh authored
The previous fix attempt at 8ba8d134 does not work when C++20 mode is enabled. MSVC optimizes away the "else" block but triggers warning C4702 on "return true". Moving the return line into the "else" block ensures that it is optimized away too. Change-Id: I9ef02cd3631ff78091530b6fb2b91c2eddcbab5d Pick-to: 6.5 6.4 Fixes: QTBUG-104836 Reviewed-by:
Marc Mutz <marc.mutz@qt.io> Reviewed-by:
Yuhang Zhao <yuhangzhao@deepin.org>
-
Marc Mutz authored
We can always add it back later, but for now, it's pointless overhead (no Q_PROPERTYs, no Q_INVOCABLEs). Found in API review. Pick-to: 6.5 Change-Id: I1e30fbda997e6576a3e94cbae0387a3188c27728 Reviewed-by:
Timur Pocheptsov <timur.pocheptsov@qt.io> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-
Marc Mutz authored
Ensure that the classes using ShortData have the same size (already done) and alignment (this patch) as classes that just have a d-pointer. Pick-to: 6.5 Change-Id: If30352a0bc4beb4b505d6e0eab5077c9c16456ba Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by:
Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-
Marc Mutz authored
The fact that read-access is always included makes a bool readWrite property a little awkward to document and explain. An AccessMode enum with values ReadOnly and ReadWrite is much easier, and will also lend itself more easily as a constructor argument than a boolean. Found in API review. Pick-to: 6.5 Change-Id: I4f20dbe9f19c7bdb52248a6e544e36d731d5a2ee Reviewed-by:
Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by:
Tor Arne Vestbø <tor.arne.vestbo@qt.io>
-