Skip to content

Initialize m_exclusive in QGtk3MenuItem constructor

Andreas Sturmlechner requested to merge asturmlechner/qtbase:initialize-m_exclusive into kde/5.15

Problem detected while investigating a crash of a program using QT, valgrind was used to detect errors and valgrind reported "Conditional jump or move depends on uninitialised value(s)" due to m_exclusive being uninitialized.

Not sure to what extent this fix matters in practice, the crash turned out to be caused by something else outside QT. But anyway it seems good to initialize m_exclusive like other things, in the constructor, and it helps avoiding such warnings from valgrind, that will make it easier to detect other problems using valgrind or similar tools.

Amends ac8a1787 where it looks like initialization of this member was simply forgotten.

Pick-to: 6.3 6.2 5.15 Change-Id: I3d1637a00b7899eded61c2e4f5f9a1c5041e4f45 Reviewed-by: Marc Mutz marc.mutz@qt.io Reviewed-by: Volker Hilsheimer volker.hilsheimer@qt.io Reviewed-by: Elias Rudberg mail@eliasrudberg.se (cherry picked from commit 0c59723e)

Merge request reports