Skip to content

Ignore window icon in XCB when its size exceeds maximum request length

Andreas Sturmlechner requested to merge asturmlechner/qtbase:QTBUG-102628 into kde/5.15

When setting a window icon with its data size exceeding the value returned by xcb_get_maximum_request_length(), the application fails with XCB error code 4 (Maximum allowed requested length exceeded). This patch adds a check if icon_data.size() exceeds xcb_get_maximum_request_length(). If that is the case the icon is being ignored and a warning is logged.

Fixes: QTBUG-102628 Pick-to: 6.3 6.2 5.15 Change-Id: Id47a0833efd16cd29b030e8c880acb416cbc500b Reviewed-by: Liang Qi liang.qi@qt.io (cherry picked from commit ebdaf8ef)

Merge request reports