1. 24 Oct, 2021 2 commits
  2. 22 Oct, 2021 4 commits
    • Nate Graham's avatar
      kcm/users: Move "Name" field into the FormLayout · 5902959b
      Nate Graham authored
      This allows it to be aligned with other form field, which is not
      possible at the moment since it exists outside of the FormLayout in a
      Row:ayout with the avatar. Fixing this would require adding API to
      Kirigami.FormLayout to let its right side align to elements not in
      another FormLayout, or port away from FormLayout and use a big
      GridLayout instead. Both are messy. Instead, let's put the Name field
      in the form layout and center the avatar above it.
      5902959b
    • Nate Graham's avatar
      kcms/users: Polish fingerprint UI on details page · 83c8939a
      Nate Graham authored
      Now the button begins with a verb and ends with an ellipsis in
      conformance with the HIG, and there's also a little message that tells
      the user what works and what doesn't. This should help to manage
      expectations a bit.
      83c8939a
    • Nate Graham's avatar
      kcms/users: clean up whitespace in fingerprint files · e114297e
      Nate Graham authored
      GIT_SILENT
      e114297e
    • Julius Zint's avatar
      KCM Touchpad: Load config for touchpad on init · 8be9929b
      Julius Zint authored
      Otherwise the UI will be initialized with the default values of constant
      properties like supportsClickMethodAreas or
      supportsClickMethodClickfinger. This leads to available configuration
      options being invisible, even though they are supported by the touchpad.
      
      BUG: 443011
      FIXED-IN: 5.23.2
      8be9929b
  3. 21 Oct, 2021 5 commits
    • Alexander Lohnau's avatar
      Remove defunct check for proxyAction in foldermodel · 2a7c1c73
      Alexander Lohnau authored
      If we press the shortcut directly on the desktop the proxy action is still the del action,
      because the context menu was not opened and the selection did not change after we pressed shift.
      
      If we have the context menu open the proxyAction is properly updated.
      
      TestPlan:
      Pressing delete with selected fle opens "Move to trash" dialog
      Pressing shift+delete with selected file opens "Delete Permanently" dialog
      
      Same with the context menu open.
      
      BUG: 444128
      2a7c1c73
    • Fushan Wen's avatar
      taskmanager: Show highlight before ToolTipInstance starts loading for grouped tooltips · 818b1b29
      Fushan Wen authored and Nate Graham's avatar Nate Graham committed
      For grouped tooltips, if there are many windows in a group, it could
      take a long time before all ToolTipInstances are loaded.
      
      Show highlight before ToolTipInstance starts loading to make user feel
      less unresponsive.
      
      Note: Will not work when a tooltip is already visible (move directly
      from a task to a grouped task)
      
      CCBUG: 433907
      818b1b29
    • Eugene Popov's avatar
      Fix updating apps model · 87f5b468
      Eugene Popov authored and Nate Graham's avatar Nate Graham committed
      There is no need to check if the model of the current item is not empty, since the current item may be not only a category.
      
      BUG: 444101
      
      
      (cherry picked from commit 27e5f4e4)
      87f5b468
    • Eugene Popov's avatar
      Fix pinned applet closes · 1d0ec8b2
      Eugene Popov authored and Nate Graham's avatar Nate Graham committed
      Check if the applet is pinned before closing it.
      
      BUG: 443589
      
      
      (cherry picked from commit 3686fea5)
      1d0ec8b2
    • Fushan Wen's avatar
      taskmanager: Prevent useless component creation/destruction for grouped tooltips · 12373d31
      Fushan Wen authored
      The binding of "model" property of DelegateModel in ToolTipDelegate.qml
      will trigger useless component creation/destruction when "rootIndex" is
      changed but is not undefined. Make the ternary operator depend on
      "hasRootIndex" bool property to avoid that.
      
      In Task.qml, only assign different values to "parentTask" and "rootIndex"
      to avoid unnecessary component creation/destruction for the second time
      hovering on the same task.
      
      CCBUG: 433907
      CCBUG: 444001
      12373d31
  4. 20 Oct, 2021 5 commits
  5. 19 Oct, 2021 8 commits
  6. 18 Oct, 2021 7 commits
  7. 17 Oct, 2021 1 commit
  8. 16 Oct, 2021 3 commits
    • Ismael Asensio's avatar
      kcm/automounter: Simplify UI · f27e6618
      Ismael Asensio authored
      Give the device list view a more prominent place at the top,
      removing the frames around it.
      
      Two of the options are moved into the device list view since those
      are tightly coupled: if you enable automounting for all devices
      you no longer need to select each one individually.
      f27e6618
    • Ismael Asensio's avatar
      92989775
    • Ismael Asensio's avatar
      kcm/automounter: Refactor some methods · e159d90d
      Ismael Asensio authored
      To split refactoring and logic changes on following-up
      commits
      
      - Use an enum for DeviceModel rows
      
      - Refactor DeviceAutomounterKCM::updateForgetDevice()
      
      - Refactor DeviceModel::rowCount()
      - Refactor DeviceModel::index()
      - Refactor DeviceModel::flags()
      - Refactor DeviceModel::setData()
      - Refactor DeviceModel::data()
      e159d90d
  9. 15 Oct, 2021 1 commit
  10. 14 Oct, 2021 2 commits
    • Nate Graham's avatar
      Folder View: Don't cancel multi-selection with right-click · 2b828c60
      Nate Graham authored
      Right-clicking on multiple things is a real use case which got broken
      in plasma/plasma-desktop!591
      while fixing the bug of un-clicked-on items remaining selected after
      clicking one of them.
      
      This commit fixes that.
      
      BUG: 443743
      FIXED-IN: 5.23.1
      2b828c60
    • David Edmundson's avatar
      [applets/kicker] Explicitly set visible property when opacity is 0 · 7881fdf5
      David Edmundson authored and Nate Graham's avatar Nate Graham committed
      The Dashboard representation contains 3 views stacked on top of each
      other with one visible at a time with an opacity animation.
      
      Enabled was used (presumably) to ensure that only the active
      representation gets input events.
      
      Unfortunately this has a side effect. When switching views the icons on
      the inactive view all get enabledChanged events. This triggers a redraw
      with a greyed out effect on all icons. This is a very slow path,
      especially for something not even visible!
      
      Setting visible also stops input events, without the side effect.
      7881fdf5
  11. 13 Oct, 2021 2 commits
    • Bharadwaj Raju's avatar
      [kcms/keyboard] Redesign "Add Layout" dialog · fde20aa4
      Bharadwaj Raju authored and Nate Graham's avatar Nate Graham committed
      Instead of having a three-part language+layout+variant design, it now
      has a single list of layouts + search.
      
      The new design is far simpler, and much better reflects how people actually
      look for layouts: they don't usually know in which "Layout" category their
      language is going to be, and a lot of major languages don't even appear in
      the "Language" combobox (like Hindi or Telugu, for example). A lot of users
      probably thought their language just wasn't supported because they looked
      for it in the "Language" combobox and didn't find it, because they didn't
      know it wasn't an exhaustive list of all languages offered in all the
      variants. It was just misleading.
      
      With the new design, they just type in the name of their language and done.
      fde20aa4
    • Benjamin Navarro's avatar
      Add move to activity entry in taskmanager context menu · 85bc1171
      Benjamin Navarro authored and David Edmundson's avatar David Edmundson committed
      85bc1171