1. 04 Aug, 2019 1 commit
    • Karl Ove Hufthammer's avatar
      Ensure that checkboxes are shown in menus · 7d106501
      Karl Ove Hufthammer authored
      The old code tried to add an icon for all menu items, even for
      empty icon names. Most themes (including the default ‘Fusion’ theme,
      but not KDE’s ‘Breeze’) don’t display checkboxes when a menu item
      already has an icon. The result was that unchecked checkboxes
      were invisible and checked checkboxes looked strange (like large,
      empty rectangles).
      
      With this commit, icons are only added for actions that actually
      *have* icons, and the checkboxes are thus correctly displayed no matter
      what theme the user has.
      7d106501
  2. 05 Dec, 2018 2 commits
  3. 29 Nov, 2018 1 commit
    • Boudewijn Rempt's avatar
      add a createActions method to KoToolFactoryBase · 5f91230f
      Boudewijn Rempt authored
      Actions created by a tool instance only exist if there's an open
      document, which means they cannot be configured or placed in
      toolbars. We should only have per-window actions, not per-action
      actions.
      
      Creating the actions in the toolfactory instead of the tool when
      the window is created fixes that: now the tools will retrieve
      the actions from the global action collection on activations
      and de-activation, like the freehand tool already did for increase
      and decrease brush size.
      
      Note: this commit breaks the following tools because it's not
      worth porting hidden tools in any case:
      
      * artistic text tool
      * odf text tool
      * connection tool
      
      BUG:365222
      
      CMAIL:kimageshop@kde.org
      5f91230f
  4. 15 Mar, 2018 1 commit
    • Boudewijn Rempt's avatar
      Load the tags in a separate step after loading all resources · 69d8a5e1
      Boudewijn Rempt authored
      This also refactors KoTagStore to remove two methods the use
      of which has disappeared in the mists of time, and that
      prevented some tags to be loaded for default resources.
      
      Now all Deevad's tags are loaded; all system tags used for
      custom resources in 3.3 are kept; all custom tags created
      in 3.3 are kept.
      
      The regression from the previous commit, where the krita 3
      bundle was loaded even if disabled is also fixed...
      
      Items 1, 2 and 4 of 391576 are resolved now, at least as
      far as I can see. I haven't dared look at item 3 yet...
      
      CCBUG:391576
      69d8a5e1
  5. 18 Jan, 2018 1 commit
  6. 04 Jan, 2018 1 commit
  7. 29 Dec, 2017 1 commit
  8. 14 Sep, 2017 1 commit
    • Boudewijn Rempt's avatar
      FEATURE: a touch docker · d2d8f2ed
      Boudewijn Rempt authored
      The touch docker is for people with 2:1 devices without real buttons.
      It mimics the wacom tablet buttons/rocker switch, a bit. The top 6
      buttons and the "rocker switch" buttons aren't configurable, the
      other 8 buttons can be configured by adding a line to kritarc
      
      touchdockermapping=action1,action2,action3,action4,action5,action6,action7,action8
      
      Note that the default configuration is useful, but shows a bad lack
      of icons.
      
      To figure out: how to toggle modifiers, like shift, ctrl and alt,
      so pressing buttons configured with those keys actually apply
      the modifier keys to all events until toggled off.
      d2d8f2ed
  9. 07 Jun, 2017 1 commit
  10. 09 Dec, 2016 1 commit
    • Dmitry Kazakov's avatar
      All shortcuts should be configurable when no document is open · aeced4a1
      Dmitry Kazakov authored
      The problem happens because some actions are created/added-to-collection
      only after a document is created. Now we workaround it by faking the
      absent actions and deleting them together with KisActionsSnapshot.
      
      Another problem is that some of the actions, e.g. "show_color_history",
      is created long before it is added to the global action collection. It
      is _created_ right at the start of Krita, but _added_ only when a new document
      is constructed. If we change the shortcut between these two events, then
      the changed value will be lost. Now we workaround this problem by connecting
      to the action collection, listening to 'inserted()' signal and updating
      shortcuts when an action is added to the collection.
      
      BUG:370720
      aeced4a1
  11. 08 Dec, 2016 3 commits
    • Dmitry Kazakov's avatar
      Added a sanity check for actions, fixed composition actions · 413c1900
      Dmitry Kazakov authored
      To enable sanity check, uncomment the corresponding define in
      KisActionsSnapshot.cpp
      413c1900
    • Dmitry Kazakov's avatar
      Fix formatting and unused variables · f85b84fe
      Dmitry Kazakov authored
      There should be no extra semicolon after functions in C++
      f85b84fe
    • Dmitry Kazakov's avatar
      Fixed multiple shortcuts bugs · e1d0a836
      Dmitry Kazakov authored
      1) Standard actions, like Copy/Paste are now propertized as well.
         Otherwise, their custom shortcuts were never used.
      
      2) ActionInfoItem now has a special field showing that the action
         is explicitly reset to null. This way we will not break it
         accidentally, when refactoring empty strings in the future
         (like it happened this time).
      
      3) Split up KisActionRegistry and KisActionsSnapshot. The former
         is a singleton and used for propertizing the actions, but the
         latter one is just a snapshot used for filling up the settings
         dialog.
      
      BUG:373184,372198
      e1d0a836
  12. 14 Nov, 2016 1 commit
  13. 31 Oct, 2016 1 commit
  14. 22 Oct, 2016 1 commit
    • Frederik Gladhorn's avatar
      Cleanup usage of empty strings · ad15727c
      Frederik Gladhorn authored
      There is no need to explicitly initialize QString in constructurs.
      Using "" for an empty string is actually less type safe and more costly
      than using QString() which returns an empty shared null string, so it's
      always preferable to signify empty QStrings that way.
      ad15727c
  15. 14 Oct, 2016 1 commit
  16. 09 May, 2016 2 commits
  17. 05 May, 2016 1 commit
  18. 02 May, 2016 1 commit
    • Michael Abrahams's avatar
      Fix saving shortcuts · 932bcb70
      Michael Abrahams authored
      Be more careful setting "defaultShortcuts." KActionCollection compares
      shortcut editor settings with defaultShortcuts property and only saves
      if they are different.
      
      Maniphest Tasks: T1244
      
      BUG: 362341
      932bcb70
  19. 27 Apr, 2016 1 commit
  20. 26 Apr, 2016 3 commits
  21. 25 Apr, 2016 1 commit
  22. 23 Apr, 2016 1 commit
    • Michael Abrahams's avatar
      Fix saving empty custom shortcuts · 55bbe231
      Michael Abrahams authored
      Ensure that defaultShortcut for an action with no default shortcut is an
      empty list, not a list containing a single item, QKeySequence("")
      
      Maniphest Tasks: T1244
      BUG: 361911
      55bbe231
  23. 14 Mar, 2016 1 commit
    • Michael Abrahams's avatar
      Move shortcut settings into "Configure Krita" menu · e3219f02
      Michael Abrahams authored
      Summary:
      This is desirable because it lessens the confusion of having "Canvas Input Settings" and "Shortcut Settings." Users can see at a glance that both pages are available. I think it looks nicer, too.
      
      Class renaming and documentation updates can be done in a separate patch.
      
      Reviewers: #krita:_next, dkazakov
      
      Reviewed By: #krita:_next, dkazakov
      
      Subscribers: dkazakov
      
      Differential Revision: https://phabricator.kde.org/D1121
      e3219f02
  24. 22 Jan, 2016 1 commit
    • Boudewijn Rempt's avatar
      Serialize loading resources · bcc44a76
      Boudewijn Rempt authored
      This might affect startup time, but it's, until we implement a database
      system for resources the only way to make the tagging system reliable.
      bcc44a76
  25. 03 Jan, 2016 2 commits
  26. 19 Dec, 2015 2 commits
  27. 10 Dec, 2015 4 commits
  28. 03 Dec, 2015 1 commit
  29. 26 Nov, 2015 1 commit