1. 13 Oct, 2021 1 commit
    • Sergio Martins's avatar
      Remove inefficient-qlist check, the issue has been fixed in Qt6 · d86b9dc6
      Sergio Martins authored
      Newer project can use Qt6.
      Old Qt5 projects shouldn't be doing such invasive changes.
      
      If this check was about uncovering bugs instead of reducing
      performance pessimisation then we could keep it for Qt5 code in
      production, that's not the case however.
      
      BUG: 443399
      d86b9dc6
  2. 27 Jul, 2021 1 commit
  3. 25 Jul, 2021 1 commit
    • Waqar Ahmed's avatar
      add check: Use Static QRegularExpression · 43161934
      Waqar Ahmed authored
      This check checks for cases like:
      
      ```
      if (QString.contains(QRegularExpression("[a-z]")) { ... }
      ```
      
      and suggests to use a `static` `QRegularExpression` instance because
      `QRegularExpression` will compile the pattern each time which can be
      really bad for performance.
      43161934
  4. 23 Jul, 2021 2 commits
  5. 03 Jun, 2021 1 commit
  6. 21 May, 2021 1 commit
  7. 15 May, 2021 1 commit
    • Sergio Martins's avatar
      fully-qualified-moc-types: Explain why Q_PROPERTY warns on moc output only · b183b331
      Sergio Martins authored
      Q_PROPERTY is a macro that doesn't expand to anything. It won't appear in
      the AST. The properties only appear in the moc output.
      
      It will warn that your Q_PROPERTY needs to be fully qualified when you do
      a full build with clazy as the compiler, but probably not in QtCreator's
      inline warnings.
      
      Working at the Lexer level without a code model would not
      only be hardwork but would be flaky with many corner cases and false-positives.
      
      BUG: 423780
      b183b331
  8. 25 Feb, 2021 2 commits
  9. 21 Feb, 2021 1 commit
    • Christian Schärf's avatar
      Split range-loop check in range-loop-detach and range-loop-reference. · edf24fea
      Christian Schärf authored
      Implements #431870
      
      Previously, the range-loop check warned about range-based loops over COW Qt containers that might detach
      as well as places where the container elements where used by value instead of const reference.
      These cases are splitted into separate checks so they can be selected separately.
      edf24fea
  10. 15 Feb, 2021 1 commit
  11. 22 Dec, 2020 2 commits
  12. 13 Nov, 2020 3 commits
  13. 06 Nov, 2020 4 commits
  14. 27 Oct, 2020 1 commit
  15. 13 Oct, 2020 1 commit
  16. 09 Oct, 2020 3 commits
  17. 05 Oct, 2020 1 commit
  18. 02 Oct, 2020 1 commit
  19. 26 Aug, 2020 2 commits
  20. 24 Aug, 2020 1 commit
  21. 06 Aug, 2020 1 commit
  22. 19 Jul, 2020 1 commit
  23. 20 Jun, 2020 1 commit
  24. 04 May, 2020 1 commit
  25. 24 Apr, 2020 1 commit
    • Nicolas Fella's avatar
      Initial check for invalid JNI method signatures · 579779bd
      Nicolas Fella authored
      Summary:
      When using QAndroidJniObject to call Android API one needs to specify method signatures using strings. This is error-prone and errors are usually only detected at runtime.
      This check searches for a set of known methods that take such signatures and validates them using a regular expression. If a signature is invalid a warning is emitted.
      
      To be able to verify Android-specific code with a desktop clang we need some include path hackery. QAndroidJniObject required jni.h, which is shipped in the Android NDK. We therefore need to amend the include paths. In order to do that we rely on $ANDROID_NDK being set and print an error if not.
      
      Test Plan: Ran tests
      
      Reviewers: smartins
      
      Reviewed By: smartins
      
      Differential Revision: https://phabricator.kde.org/D28887
      579779bd
  26. 13 Apr, 2020 1 commit
  27. 28 Dec, 2019 1 commit
  28. 26 Nov, 2019 1 commit
  29. 14 Oct, 2019 1 commit