Commit 0fa050b9 authored by Alexander Lohnau's avatar Alexander Lohnau 💬
Browse files

Remove unneeded QOverload for QProcess::finished signal

By excluding deprecated API, the signal is no longer overloaded

Task: https://phabricator.kde.org/T14370
parent 1a4f24c9
Pipeline #118360 failed with stage
in 46 seconds
......@@ -93,7 +93,7 @@ FileViewBazaarPlugin::FileViewBazaarPlugin(QObject* parent, const QList<QVariant
connect(m_logAction, &QAction::triggered,
this, &FileViewBazaarPlugin::log);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &FileViewBazaarPlugin::slotOperationCompleted);
connect(&m_process, &QProcess::errorOccurred,
this, &FileViewBazaarPlugin::slotOperationError);
......
......@@ -100,7 +100,7 @@ FileViewGitPlugin::FileViewGitPlugin(QObject* parent, const QList<QVariant>& arg
m_logAction->setText(xi18nd("@action:inmenu", "<application>Git</application> Log..."));
connect(m_logAction, &QAction::triggered, this, &FileViewGitPlugin::log);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &FileViewGitPlugin::slotOperationCompleted);
connect(&m_process, &QProcess::errorOccurred,
this, &FileViewGitPlugin::slotOperationError);
......
......@@ -100,7 +100,7 @@ HgCloneDialog::HgCloneDialog(const QString &directory, QWidget *parent):
connect(m_browse_source, &QAbstractButton::clicked,
this, &HgCloneDialog::slotBrowseSourceClicked);
connect(&m_process, &QProcess::started, this, &HgCloneDialog::slotCloningStarted);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &HgCloneDialog::slotCloningFinished);
connect(&m_process, &QProcess::readyReadStandardOutput,
this, &HgCloneDialog::slotUpdateCloneOutput);
......
......@@ -25,14 +25,14 @@ HgWrapper::HgWrapper(QObject *parent) :
// re-emit QProcess signals
connect(&m_process, &QProcess::errorOccurred,
this, &HgWrapper::errorOccurred);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &HgWrapper::finished);
connect(&m_process, &QProcess::stateChanged,
this, &HgWrapper::stateChanged);
connect(&m_process, &QProcess::started,
this, &HgWrapper::started);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &HgWrapper::slotOperationCompleted);
connect(&m_process, &QProcess::errorOccurred,
this, &HgWrapper::slotOperationError);
......
......@@ -52,7 +52,7 @@ void HgServeWrapper::startServer(const QString &repoLocation, int portNumber)
connect(&server->process, &QProcess::started,
this, &HgServeWrapper::started);
connect(&server->process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&server->process, &QProcess::finished,
this, &HgServeWrapper::slotFinished);
connect(server, &ServerProcessType::readyReadLine,
this, &HgServeWrapper::readyReadLine);
......
......@@ -123,7 +123,7 @@ public:
this, &ServerProcessType::slotAppendOutput);
connect(&process, &QProcess::readyReadStandardError,
this, &ServerProcessType::slotAppendRemainingOutput);
connect(&process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&process, &QProcess::finished,
this, &ServerProcessType::slotFinished);
}
......
......@@ -45,13 +45,13 @@ void HgSyncBaseDialog::setup()
this, &HgSyncBaseDialog::slotUpdateBusy);
connect(&m_main_process, &QProcess::stateChanged,
this, &HgSyncBaseDialog::slotUpdateBusy);
connect(&m_main_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_main_process, &QProcess::finished,
this, &HgSyncBaseDialog::slotOperationComplete);
connect(&m_main_process, &QProcess::errorOccurred,
this, &HgSyncBaseDialog::slotOperationError);
connect(&m_process, &QProcess::errorOccurred,
this, &HgSyncBaseDialog::slotOperationError);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &HgSyncBaseDialog::slotChangesProcessComplete);
connect(this, &QDialog::finished, this, &HgSyncBaseDialog::slotWriteBigSize);
}
......
......@@ -124,7 +124,7 @@ FileViewSvnPlugin::FileViewSvnPlugin(QObject* parent, const QList<QVariant>& arg
connect(m_cleanupAction, &QAction::triggered,
this, &FileViewSvnPlugin::cleanupDialog);
connect(&m_process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
connect(&m_process, &QProcess::finished,
this, &FileViewSvnPlugin::slotOperationCompleted);
connect(&m_process, &QProcess::errorOccurred,
this, &FileViewSvnPlugin::slotOperationError);
......
......@@ -47,7 +47,7 @@ void SvnProgressDialog::connectToProcess(QProcess *process)
process->terminate();
m_svnTerminated = true;
} );
m_conCompeted = connect(process, QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished), this, &SvnProgressDialog::operationCompeleted);
m_conCompeted = connect(process, &QProcess::finished, this, &SvnProgressDialog::operationCompeleted);
m_conProcessError = connect(process, &QProcess::errorOccurred, this, [this, process] (QProcess::ProcessError) {
const QString commandLine = process->program() + process->arguments().join(' ');
appendErrorText(i18nc("@info:status", "Error starting: %1", commandLine));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment