Commit 2714be04 authored by Kwon-Young Choi's avatar Kwon-Young Choi Committed by Elvis Angelaccio
Browse files

Automatically mount directory after attaching loop device

After attaching a loop device, the device needs to be mounted on directory to
be accessible. This can be done manually by clicking on the newly appeared
device in dolphin side bar. This patch automatize this by automatically
mounting the loop device to a directory using Solid after attaching the loop

The way this is done a little bit hacky since the plugin needs to wait for UDisks2 to send a signal to Solid to update its device database. The wait is done using a nested QEventLoop by waiting on Solid::DeviceNotifier::deviceAdded signal.

BUG: 424413
FIXED-IN: 20.11.80
parent 77792fbc
......@@ -33,10 +33,13 @@
#include <QDBusReply>
#include <QDBusUnixFileDescriptor>
#include <QDebug>
#include <QEventLoop>
#include <QIcon>
#include <QMap>
#include <QObject>
#include <QProcess>
#include <QString>
#include <QTimer>
#include <QVariant>
#include <KLocalizedString>
......@@ -44,7 +47,10 @@
#include <Solid/Block>
#include <Solid/Device>
#include <Solid/DeviceInterface>
#include <Solid/DeviceNotifier>
#include <Solid/GenericInterface>
#include <Solid/StorageAccess>
#include <Solid/StorageVolume>
K_PLUGIN_CLASS_WITH_JSON(MountIsoAction, "mountisoaction.json")
......@@ -117,6 +123,47 @@ void mount(const QString &file)
if (!reply.isValid()) {
qWarning() << "Error mounting " << file << ":" << reply.error().name()
<< reply.error().message();
// Need to wait for UDisks2 to send a signal to Solid to update its database
auto notifier = Solid::DeviceNotifier::instance();
// The following code can not be put into a slot because the MountIsoAction object is destroyed
// as soon as this function ends
QEventLoop loop;
QTimer timer;
QObject::connect(&timer, &QTimer::timeout, &loop, &QEventLoop::quit);
QObject::connect(notifier, &Solid::DeviceNotifier::deviceAdded, &loop, &QEventLoop::quit);
int i = 0, maxDeviceRace = 4;
Solid::Device device;
while (i < maxDeviceRace) {
timer.start(5000); // 5s timeout
device = Solid::Device(reply.value().path());
if (!<Solid::StorageVolume>()) {
} else {
if (i == maxDeviceRace) {
// Something really wrong happened
auto storageVolume =<Solid::StorageVolume>();
const QString uuid = storageVolume->uuid();
QList<Solid::Device> devices = Solid::Device::listFromQuery(
QStringLiteral("[ StorageVolume.uuid == '%1' AND IS StorageAccess ]").arg(uuid));
for (auto dev : devices) {
auto storageAccess =<Solid::StorageAccess>();
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment