1. 27 Apr, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      Fix 'SVN Log...' crash while watching history in the unversioned directory.... · c64770b9
      Nikolai Krasheninnikov authored
      Fix 'SVN Log...' crash while watching history in the unversioned directory. Added checks m_log variable contains anything.
      
      Summary:
      This commits adds checks of m_log variable contains anything before using it.
      More appropriate is not showing 'SVN Log...' as available action at all, this should go in a further commits.
      Anyway checks for a m_log variable is a must.
      
      Test Plan: Run 'SVN Log...' in unversioned directory make sure it doesn't crash any more and showes empty history.
      
      Reviewers: #dolphin, meven, elvisangelaccio
      
      Reviewed By: #dolphin, meven, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D29043
      c64770b9
  2. 25 Apr, 2020 1 commit
  3. 12 Apr, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      [svn] Fixed items status inside unversioned directory. · f691f024
      Nikolai Krasheninnikov authored
      Summary:
      Added special checks for items inside unversioned dirs.
      Previously those items was indicated as normal revision with a capability to launch SVN commands on it (SVN Delete, for example). Those commands ends up with an error.
      
      Unversioned item is a special case because in any other cases 'svn status' will mark every file or dir as added, removed, conflicted and so on.
      
      Test Plan:
      Inside a repo create dir with a following structure:
      {F8225757}
      
      1) Check any SVN actions available only for "dir", selecting other dirs and files causes no actions available.
      2) Check items status showing correct.
      3) Do 'SVN Add' for dir, 'SVN Revert' for dir2.
      4) Check dir (with dir1.txt, file1.txt) and dir/dir1 (with file2.txt) and dir/dir1/dir2 has SVN Actions while dir/dir1/dir2/dir3 don't.
      5) Check items status showing correct.
      
      Reviewers: meven, elvisangelaccio, #dolphin
      
      Reviewed By: meven, elvisangelaccio, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28681
      f691f024
  4. 01 Apr, 2020 1 commit
  5. 27 Mar, 2020 1 commit
  6. 22 Mar, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      Dolphin-SVN: code update · 2833d015
      Nikolai Krasheninnikov authored
      Summary:
      1) Pointers initialized with 'nullptr' instead of '0'.
      2) Moved to a modern Qt-way of connecting signals and slots without SIGNAL() and SLOT() macros.
      3) Class SVNCommands renamed to SvnCommands for consistency with other class names.
      
      Test Plan: Ensure everything is correct, try some basic actions.
      
      Reviewers: meven, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D28170
      2833d015
  7. 19 Mar, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      SVN: added SVN Log dialog · d7de9444
      Nikolai Krasheninnikov authored
      Summary:
      Added SVN Log dialog. Dialog looks and behaves similar to a TortoiseSVN one.
      Dialog supports:
      - update repo to specified revision;
      - revert repo to specified revision;
      - revert file to a specified revision;
      - show changes against previois commit;
      - show changes against working copy.
      Everything is done by the context menu.
      
      {F8181378}
      
      Test Plan: Run SVN Log dialog and check update works, revert works, revert file works, show changes and show changes against working copy works.
      
      Reviewers: #vdg, meven, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: yurchor, anthonyfieroni
      
      Differential Revision: https://phabricator.kde.org/D28102
      d7de9444
  8. 17 Mar, 2020 1 commit
  9. 10 Mar, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      Added SVN add/delete/revert directory. · 3fb84565
      Nikolai Krasheninnikov authored
      Summary:
      Added "SVN Add" on directory addition with appropriate "SVN Revert" action.
      Also for directories already under VCS control added "SVN Delete" action.
      
      Test Plan:
      1. Create empty directory.
      2. Try "SVN Add" on it: it should be added.
      3. Try "SVN Revert" on it: it should be reverted.
      4. Try "SVN Add", then "SVN Commit". It should be commited fine.
      5. Try "SVN Delete", then "SVN Commit". It should be deleted from CVS and commited fine.
      6. Try the same with a dir with an empty file in it right-clicking on the directory name and inside directory.
      
      Reviewers: meven, elvisangelaccio
      
      Reviewed By: meven
      
      Differential Revision: https://phabricator.kde.org/D27652
      3fb84565
  10. 09 Mar, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      SVN commit dialog now supports diff, add and revert actions. · 31c122b6
      Nikolai Krasheninnikov authored
      Summary:
      Added SVN commit dialog actions for diff file, add file and revert file.
      This is done by commit dialog context menu actions.
      SVN commit dialog is now a separate class and moved to a separate file.
      Also added SVNCommands class with static methods to access basic SVN actions like geting revision or geting remote URL path for a file.
      Also added ItemVersion::MissingVersion control for SVN plugin.
      
      {F8134979}
      
      Test Plan: Run SVN commit dialog and check diff file works, revert works and add works.
      
      Reviewers: #vdg, elvisangelaccio, meven, ngraham
      
      Reviewed By: #vdg, meven, ngraham
      
      Subscribers: ngraham
      
      Differential Revision: https://phabricator.kde.org/D27641
      31c122b6
  11. 18 Feb, 2020 2 commits
  12. 17 Feb, 2020 1 commit
  13. 04 Feb, 2020 1 commit
  14. 26 Dec, 2019 1 commit
  15. 23 Dec, 2019 1 commit
  16. 21 Dec, 2019 2 commits
  17. 24 Nov, 2019 1 commit
  18. 20 Nov, 2019 2 commits
  19. 16 Nov, 2019 1 commit
  20. 11 Nov, 2019 1 commit
  21. 10 Nov, 2019 1 commit
    • Maciej Dems's avatar
      Fixed git status retrieval splitting entries · 2cf2d4d0
      Maciej Dems authored
      Summary:
      
      Sometimes, for large repositories the status is messed up (which in unlucky case causes `Commit..` command to disappear).
      
      The reason for this is that `FileViewGitPlugin::beginRetrieval` method cannot correctly parse the `git status` output. The reason for this is that `FileViewGitPlugin::readUntilZeroChar` does not return complete entry, because it is not provided fast enough.
      
      The idea of this patch is to allow the `FileViewGitPlugin::readUntilZeroChar` to wait for the remaining data.
      
      Test Plan:
      The bug depends on the race condition between the plugin code and executed `git` code. Hence it is hard to test. To fake the issue make fake git process that pauses mid entry. In such case the loop in `FileViewGitPlugin::beginRetrieval` should parse eg:
      
          !! ABCDEFGH\0x00
      
      Instead it gets:
      
          !! AB\0x00
          CDEFGH\0x00
      
      which results in two entries for non-existent files.
      
      The patch solves this issue.
      
      BUG: 413870
      FIXED-IN: 19.11.80
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D25187
      2cf2d4d0
  22. 04 Oct, 2019 1 commit
  23. 25 Sep, 2019 1 commit
  24. 14 Sep, 2019 2 commits
  25. 04 Sep, 2019 1 commit
  26. 01 Sep, 2019 1 commit
  27. 25 Aug, 2019 1 commit
  28. 23 Aug, 2019 1 commit
  29. 15 Aug, 2019 1 commit
  30. 14 Aug, 2019 1 commit
  31. 13 Aug, 2019 1 commit
  32. 12 Aug, 2019 1 commit
  33. 10 Aug, 2019 1 commit
  34. 08 Aug, 2019 3 commits