1. 21 Dec, 2019 1 commit
    • Nikolai Krasheninnikov's avatar
      Fixed broken SVN Commit dialog. · e8f6c72a
      Nikolai Krasheninnikov authored
      Summary:
      SVN commit dialog was showing incorrectly because QDialogBox buttons were not attached to the dialog window.
      Also fixing memory leak on QDialogButtonBox creating.
      
      Reviewers: #dolphin, elvisangelaccio, meven, ngraham
      
      Reviewed By: #dolphin, elvisangelaccio, meven, ngraham
      
      Subscribers: ngraham, meven
      
      Differential Revision: https://phabricator.kde.org/D26115
      e8f6c72a
  2. 20 Nov, 2019 1 commit
  3. 10 Nov, 2019 1 commit
    • Maciej Dems's avatar
      Fixed git status retrieval splitting entries · 2cf2d4d0
      Maciej Dems authored
      Summary:
      
      Sometimes, for large repositories the status is messed up (which in unlucky case causes `Commit..` command to disappear).
      
      The reason for this is that `FileViewGitPlugin::beginRetrieval` method cannot correctly parse the `git status` output. The reason for this is that `FileViewGitPlugin::readUntilZeroChar` does not return complete entry, because it is not provided fast enough.
      
      The idea of this patch is to allow the `FileViewGitPlugin::readUntilZeroChar` to wait for the remaining data.
      
      Test Plan:
      The bug depends on the race condition between the plugin code and executed `git` code. Hence it is hard to test. To fake the issue make fake git process that pauses mid entry. In such case the loop in `FileViewGitPlugin::beginRetrieval` should parse eg:
      
          !! ABCDEFGH\0x00
      
      Instead it gets:
      
          !! AB\0x00
          CDEFGH\0x00
      
      which results in two entries for non-existent files.
      
      The patch solves this issue.
      
      BUG: 413870
      FIXED-IN: 19.11.80
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D25187
      2cf2d4d0
  4. 04 Oct, 2019 1 commit
  5. 25 Sep, 2019 1 commit
  6. 14 Sep, 2019 2 commits
  7. 04 Sep, 2019 1 commit
  8. 01 Sep, 2019 1 commit
  9. 25 Aug, 2019 1 commit
  10. 23 Aug, 2019 1 commit
  11. 15 Aug, 2019 1 commit
  12. 14 Aug, 2019 1 commit
  13. 13 Aug, 2019 1 commit
  14. 12 Aug, 2019 1 commit
  15. 10 Aug, 2019 1 commit
  16. 08 Aug, 2019 4 commits
  17. 07 Aug, 2019 1 commit
  18. 17 Jul, 2019 1 commit
  19. 16 Jul, 2019 1 commit
  20. 16 Mar, 2019 1 commit
  21. 25 Feb, 2019 1 commit
  22. 24 Jan, 2019 1 commit
  23. 21 Jan, 2019 1 commit
  24. 11 Dec, 2018 2 commits
  25. 14 Oct, 2018 2 commits
  26. 10 Oct, 2018 1 commit
  27. 07 Sep, 2018 1 commit
  28. 14 Aug, 2018 6 commits
  29. 13 Aug, 2018 1 commit