Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
D
Dolphin Plugins
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SDK
  • Dolphin Plugins
  • Merge Requests
  • !25

Merged
Opened Jan 04, 2021 by Kai Uwe Broulik@broulik🍇Developer

[Mount ISO Action] Optimize getDeviceFromBackingFile

  • Overview 4
  • Commits 1
  • Changes 1

Only query for StorageAccess as only this device type can be mounted, safes around 2/3 of needlessly created Devices significantly speeding up the lookup.

Also use property() instead of allProperties(), the latter of which does an explicit GetAll DBus query. Effectively, will probably not do much because it will be the first time the Device properties are queried but it's still slightly convoluted.


@bruns @kchoi

Right-clicking ISO files is still slow but a lot less so.

Mounting and unmounting (and determining whether it's mounted) an ISO file still works.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: sdk/dolphin-plugins!25
Source branch: work/kbroulik/optimizedisodevicequery