Commit 90ead1d8 authored by Yuri Chornoivan's avatar Yuri Chornoivan
Browse files

Fix minor EBN issues

parent 1a733bb4
......@@ -35,7 +35,7 @@ public:
// no "explicit": we want implicit conversion
Addr(uint64 v) { _v = v; }
// Interpretes char data at s as hex (without "0x" prefix)
// Interprets char data at s as hex (without "0x" prefix)
// and return number of interpreted chars.
int set(const char *s);
bool set(FixString& s);
......
......@@ -84,17 +84,17 @@ public:
* attribute is requested (e.g. by subCost()).
* Has to be overwritten by subclasses when the cost influences costs of
* other cost items. If only one item depends on the cost of this item,
* it can by set with setDependant() without a need for overwriting.
* it can by set with setDependent() without a need for overwriting.
*/
virtual void invalidate();
/**
* Sets a dependant to be invalidated when this cost is invalidated.
* Sets a dependent to be invalidated when this cost is invalidated.
* Call this function directly after the constructor.
*/
void setDependant(CostItem* d) { _dep = d; }
void setDependent(CostItem* d) { _dep = d; }
CostItem* dependant() { return _dep; }
CostItem* dependent() { return _dep; }
/**
* If this item is from a single profile data file, position
......
......@@ -3143,10 +3143,10 @@ int TraceData::load(QStringList files)
_traceName += QLatin1String("/callgrind.out");
}
files = dir.entryList(QStringList() << prefix + "*", QDir::Files);
files = dir.entryList(QStringList() << prefix + '*', QDir::Files);
QStringList::Iterator it = files.begin();
for (; it != files.end(); ++it ) {
*it = dir.path() + "/" + *it;
*it = dir.path() + '/' + *it;
}
}
......
......@@ -1463,7 +1463,7 @@ public:
void update() override;
// invalidates all cost items dependant on active state of parts
// invalidates all cost items dependent on active state of parts
void invalidateDynamicCost();
// cycle detection
......
......@@ -112,7 +112,7 @@ private:
/* Custom item delegate for function list:
* show tooltip for function name if truncated.
* (thanks to http://www.mimec.org/node/337)
* (thanks to https://www.mimec.org/blog/tooltips-for-truncated-items-in-a-qtreeview)
*/
class AutoToolTipDelegate : public QStyledItemDelegate
{
......
......@@ -417,7 +417,7 @@ QString SubPartItem::text(int textNo) const
if (!_partCostItem)
return QObject::tr("(unknown)");
return _partCostItem->dependant()->prettyName();
return _partCostItem->dependent()->prettyName();
}
if (textNo != 1)
......@@ -518,9 +518,9 @@ QColor SubPartItem::backColor() const
{
PartAreaWidget* w = (PartAreaWidget*)widget();
if (w->visualization() == PartAreaWidget::Inclusive)
return w->groupColor((TraceFunction*)(_partCostItem->dependant()));
return w->groupColor((TraceFunction*)(_partCostItem->dependent()));
return GlobalGUIConfig::groupColor(_partCostItem->dependant());
return GlobalGUIConfig::groupColor(_partCostItem->dependent());
}
......@@ -461,7 +461,7 @@ void QCGTopLevel::createActions()
this, &QCGTopLevel::toggleExpanded);
_expandedToggleAction->setChecked(GlobalConfig::showExpanded());
_splittedToggleAction = new QAction(tr("Splitted Visualization"), this);
_splittedToggleAction = new QAction(tr("Split Visualization"), this);
_splittedToggleAction->setCheckable(true);
_splittedToggleAction->setStatusTip(
tr("Show visualization of two cost items"));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment