Commit e05ffc93 authored by Albert Astals Cid's avatar Albert Astals Cid

Don't die when finding an unknown email

Nowadays with phabricator, etc. it's very common to have commits whose author is not a committer and thus not listed in the accounts file.

Instead of die-ing collect all those emails and print them in the summary, the script will just work fine

Subscribers: svuorela, ostroffjh, jriddell, mwolff, dfaure

Differential Revision:
parent 34617a5f
......@@ -412,6 +412,7 @@ my %secondary_mail_addresses = (
my %ruletable;
my %blacklist;
my %whitelist;
my %unknown_authors;
my @blacklist_revs;
foreach my $who (keys %old_license_table) {
......@@ -485,7 +486,7 @@ sub resolveEmail($) {
$resolved = $secondary_mail_addresses{$email};
if (not defined $resolved) {
die "Could not find $email in $accountfile\n";
$unknown_authors{$email} = 1;
return $email;
return $resolved;
......@@ -636,6 +637,14 @@ if (-f $file) {
if (%unknown_authors) {
print "The following emails do not appear in the accounts file:\n\n";
foreach my $who(keys %unknown_authors) {
print "$who\n";
print "\n";
if (defined (keys %blacklist)) {
print "Need permission for licensing:\n\n";
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment