GitLab

I was off by a few days but 20.06 feels better than 20.07, so here we
go anyways. It's cosmetic only at this point anyways.

With the advent of Qt6 development, the pace of Qt5 has slowed enough
that we can now rely on distribution packages being available and up to
date for Plasma development.

Since Qt5 remains a significant pain point for kdesrc-build users, we
shouldn't inflict this requirement by default for new users.

gpgme 1.13.1 (released in 2019) works fine.

Previously we incurred additional network I/O due to git pull (for reasons to do with a bug in certain git versions).
However, with the new stash logic we can assume a clean checkout and so an update should always be a simple fast-forward to the remote HEAD.

This attempt takes the "simpler is better" approach:

 - Always attempt to stash (including untracked files as well)
 - Warn if it turns out that something was actually stashed
 - Never pop stashes
 - Leave it up to the user to recover the stashed changes and fold them into the updated clone.

Essentially kdesrc-build becomes a lot more opinionated/strict about using --no-src.
Previously, there were various situations where --no-src was not strictly necessary to build with local changes, now these have all been eliminated.
There should really be no way anymore to build with a dirty checkout/clone now, except via --no-src.

Issues: #42

KHelpCenter isn't needed for a minimal desktop build. When khelpcenter
is not installed, the various "Help" buttons in apps will simply open
the online version of the documentation in the default browser.

Previously -release mode was the implied default, with this change it is explicitly selected for.
Additionally -optimized-tools is removed because the Qt configure log notes that this is redundant.

Eliminates the only dependency on doxygen in the build, thus simplifying
the environment setup.

libdbusmenu-qt is also the only thing we pull from Launchpad with bzr.
Upstream appears to be dead, so it would be good to import the code into
invent.kde.org to further simply the build process.

This was changed awhile back but we neglected to update our sample
xsession script. Thanks to Feng Chao for the report and patch!

Differential Revision: https://phabricator.kde.org/D29855

polish: split off Qt5 debug info from the main ELF files to avoid super large ELFs in case of QtWebengine and friends.

libnm-glib/libnm-util were dropped quite a while ago and so the
NetworkManager.pc file does no longer exist on openSUSE Tumbleweed.

Applications run by kdesrc-run alias could not pass command line arguments
This was solved by passing the --flags rather than only parsing first arg

These modules are required for KDE PIM and potentially other modules.

The sysadmins have migrated kde-build-metadata into repo-metadata (under
/dependencies for now). This helps with project management and reduces
the risk of having kdesrc-build in an inconsistent state based on when
repo-metadata is updated vs. kde-build-metadata.

Update kdesrc-build to look for the dependency graph and
branch/branch-group information in the updated location so that we can
adapt to the move.

This passes test suite and has been tested by an actual short set of
compile jobs here.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

boost is needed for kactivities
intltool is needed for kaccounts

The output "linux distribution" doesn't make sense when it's actually
FreeBSD; shuffle the message a little and put the identifier that
comes back from os-release in parenthesis. This makes the output
on FreeBSD consistent and won't scare weird-distro people (they
know it's a linux, right?)

When run on FreeBSD, with os-release saying that this is a FreeBSD
system, since there's no distro-match it ends up being called a Linux.
This changes the fallback / generic return from bestDistroMatch()
to handle non-Linuxes (leaves space for haiku or openBSD).

```
 - Installing system packages for freebsd...
    Installing packages for freebsd/12.0
```

As FreeBSD demonstrated (with the bug in truthiness-of-$fh)
it's not an error to have no os-release, it's just inconvenient:
the system type is recognized as a generic linux and you
don't have a useful initial-setup setup of packages.

On FreeBSD (prior to 13), os-release is installed by a port (so it
may be missing -- but it's an installation requirement for all KDE
and possibly Qt ports, so it is going to be there if whoever is using
kdesrc-build has any other KDE software at all). The file ends up
in */usr/local/etc* because */etc* is for base-system things.

Add that candidate location to the checks.

`open($fh, ...)` associates a filehandle with `$fh`, even when
`open()` fails. The `$fh` is truthy, even when the filehandle is closed.

On FreeBSD, */etc/os-release* does not exist (in versions prior
to 13, at least), but the code tries to open that; `open()`
returns undefined so the `last` doesn't trigger, but `$fh`
is now associated with something, and is truthy: the while-loop
ends, `croak_runtime()` is skipped, and a closed filehandle
is read. There's no lines in there, and os-release detection
ends up thinking generic-Linux.

The warning that perl prints is

    readline() on closed filehandle $fh at
    kdesrc-build/modules/ksb/OSSupport.pm line 147.

(line number modulo some debug-hacking of mine). By setting
`$fh` back to undefined the while-loop will actually try all
of the possibilities.

- Effectively, this prevents FreeBSD from using kdesrc-build,
  since there is no os-release (and that's apparently fatal).
- This **might** be a perl 5.30.2 issue? I don't know how truthy
  older filehandles are, nor whether `open()` sets them on failure.

For starter, it is in wrong place, and for second bit, it is
unmaintained

If this all works this would allow us to migrate this functionality to
improve how we handle git-stash as in issue #42.

In my testing, it works at least. I'll show example output in the
corresponding merge request for tracking.

This is intended to support some of the git-stash improvement we want in
issue #42 but it will obviously have wider application.

The hard part is that in the normal mode of operations (asynchronous)
the update process is off in a separate subprocess and will not have
access to the ksb::Module that we would want to print the messages from
at the end of the main process.

As with the similar problems I've run into here, my solution is to pass
the info over the IPC class. This will be easier in the make_it_mojo
branch but on the other hand it will need implemented differently in
that branch.

This field is effectively obsolete, and sysadmin is looking to remove it.
Previously there used to be metadata files on the 'group' level that had
this flag disabled, but such files are now all gone. The sanity check
never triggers for the metadata files anymore since the move to Gitlab.

My git version 2.26.2 returns an error code 1 and doesn't rebase
in a fast-forward scenario. I have to admit that I'm surprised by
this myself. But `git pull --rebase` does what we want, so apparently
that should be used instead? Or is this some local configuration
issue?

When I run kdesrc-build without this patch I get:

```
        Updating sysadmin-repo-metadata using existing branch master
log_command(): Module sysadmin-repo-metadata, Command: git checkout master
# kdesrc-build running: 'git' 'checkout' 'master'
# from directory: /home/milian/projects/kf5/src/sysadmin/repo-metadata
Already on 'master'
Your branch is behind 'origin/master' by 105 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
log_command(): Module sysadmin-repo-metadata, Command: git rebase origin/master
# kdesrc-build running: 'git' 'rebase' 'origin/master'
# from directory: /home/milian/projects/kf5/src/sysadmin/repo-metadata
error: nothing to do
Logfile for sysadmin-repo-metadata is git-rebase.log
        Unable to update the source code for sysadmin-repo-metadata
```

Indeed, I can also easily reproduce this issue outside of kdesrc-build
directly in my shell:

```
$ git --version
git version 2.26.2
$ cd /home/milian/projects/kf5/src/sysadmin/repo-metadata
$ git status
On branch master
Your branch is behind 'origin/master' by 105 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

nothing to commit, working tree clean
$ git rebase origin/master
error: nothing to do
$ echo $?
1
```

A `git pull --rebase origin master` fast-forwards my local checkout
as intended. This is what this patch does now too, thereby fixing all
the errors/warnings in kdesrc-build (and properly updating my local
checkouts again).

We *always* use HTTPS to fetch new objects from git.

We *can support* setting the git "push URL" to HTTPS also, and some
users will need this. But this complicates the existing practice of
using git + SSH to push changes to the KDE git infrastructure, so revert
this part of the change.

Also: x-invent-push-urls is now the only way to go, the feature toggle is no longer useful.

This addresses the bug causing kdesrc-build to warn repeatedly about a
git remote having moved (because it was comparing against a persistent
option set the normal way).

Unfortunately the persistent option update feature in the IPC code has
probably never worked properly as far as I can tell, so this may also
fix other minor bugs.

What I'd like to do before merging this all is to find a way to
integrate into the test suite somehow.