Members of the KDE Community are recommended to subscribe to the kde-community mailing list at to allow them to participate in important discussions and receive other important announcements

Commit fa6d0d8a authored by Piotr Wójcik's avatar Piotr Wójcik Committed by Michael Reeves

Make valid filter for all files

Fix filter so files can be actually listed and opened from file dialog.
On occasion, make filter translatable.

Test Plan: Run `kdiff3`, click "File…" button, try to select any file in dialog.

Reviewers: mreeves

Reviewed By: mreeves
This issue does not seem to impact my test machine but the change causes no problems.

Differential Revision:
parent 3d2eb091
......@@ -231,8 +231,8 @@ void OpenDialog::selectURL(QComboBox* pLine, bool bDir, int i, bool bSave)
currentUrl = QUrl::fromUserInput(current, QString(), QUrl::AssumeLocalFile);
QUrl newURL = bDir ? QFileDialog::getExistingDirectoryUrl(this, i18n("Open Directory"), currentUrl)
: bSave ? QFileDialog::getSaveFileUrl(this, i18n("Select Output File"), currentUrl, QLatin1Literal("all/allfiles"))
: QFileDialog::getOpenFileUrl(this, i18n("Open File"), currentUrl, QLatin1Literal("all/allfiles"));
: bSave ? QFileDialog::getSaveFileUrl(this, i18n("Select Output File"), currentUrl, i18n("All files (*)"))
: QFileDialog::getOpenFileUrl(this, i18n("Open File"), currentUrl, i18n("All files (*)"));
if(!newURL.isEmpty()) {
Since we are selecting a directory open in the parent directory
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment