GitLab

Currently this has no effect as the only use of FirstNonEmpty  instantiates with QString

*createLocalCopy already does this

Correct handling of blank file name.

Much less headache to keep track of and read.

*KIO uses the posix access codes on windows.

This function is tricky to use right in KDiff3. Our local "urls" don't always
have a scheme. This is fine since KDiff3 doen't deal with relative remote urls.

*set m_url from absolute path
*drop obsolete special handling from FileAccess::url
 -We now always have m_url setup.

This enables linting for missed values.

Modern compilers warning for unchecked enum values in a switch.  Don't
short-circuit this with a runtime assert.

QCOMPARE will show the actual result not just validate it.

Much more bullet-proof than trying to play games with the linker.

*Don't setup bogus FileAccess records if FileAccessJobHandler::stat fails.
*Also don't set m_bValidData = true for such cases.

This reverts commit 2803806a.