1. 15 May, 2022 1 commit
  2. 07 May, 2022 1 commit
  3. 01 May, 2022 1 commit
  4. 12 Apr, 2022 1 commit
  5. 06 Apr, 2022 1 commit
  6. 01 Apr, 2022 1 commit
  7. 23 Mar, 2022 1 commit
  8. 12 Mar, 2022 1 commit
  9. 11 Mar, 2022 3 commits
  10. 27 Feb, 2022 3 commits
  11. 02 Feb, 2022 1 commit
  12. 31 Jan, 2022 2 commits
  13. 29 Jan, 2022 1 commit
  14. 28 Jan, 2022 3 commits
  15. 03 Jan, 2022 3 commits
  16. 09 Dec, 2021 2 commits
  17. 07 Dec, 2021 2 commits
    • Oleg Solovyov's avatar
      Fix stack overflow · 18c8b7d5
      Oleg Solovyov authored and Albert Astals Cid's avatar Albert Astals Cid committed
      We get an infinite recursion when we perform search with no files found.
      See below:
      
      void FileSearchTab::performSearch()
      {
          if (m_searchFileListView->files().isEmpty()) { // <= assume true
              addFilesToSearch(doScanRecursive(QDir(Project::instance()->poDir()))); // <= arg is an empty list
      	if (m_searchFileListView->files().isEmpty()) // <= unreachable, see below
      	[...]
      }
      
      void FileSearchTab::addFilesToSearch(const QStringList& files)
      {
          m_searchFileListView->addFiles(files); // <= files.isEmpty() == true
          performSearch(); // <= m_searchFileListView->files().isEmpty() == true
      }
      
      Steps to reproduce:
      1) Project -> Create software translation project -> Save
      2) RMB -> Search in files
      3) Wait ~1 minute until crash
      
      (cherry picked from commit 9b82f864)
      18c8b7d5
    • Oleg Solovyov's avatar
      Fix stack overflow · 9b82f864
      Oleg Solovyov authored
      We get an infinite recursion when we perform search with no files found.
      See below:
      
      void FileSearchTab::performSearch()
      {
          if (m_searchFileListView->files().isEmpty()) { // <= assume true
              addFilesToSearch(doScanRecursive(QDir(Project::instance()->poDir()))); // <= arg is an empty list
      	if (m_searchFileListView->files().isEmpty()) // <= unreachable, see below
      	[...]
      }
      
      void FileSearchTab::addFilesToSearch(const QStringList& files)
      {
          m_searchFileListView->addFiles(files); // <= files.isEmpty() == true
          performSearch(); // <= m_searchFileListView->files().isEmpty() == true
      }
      
      Steps to reproduce:
      1) Project -> Create software translation project -> Save
      2) RMB -> Search in files
      3) Wait ~1 minute until crash
      9b82f864
  18. 02 Dec, 2021 1 commit
  19. 28 Nov, 2021 1 commit
  20. 22 Nov, 2021 1 commit
  21. 08 Nov, 2021 2 commits
  22. 01 Nov, 2021 1 commit
  23. 31 Oct, 2021 1 commit
  24. 13 Oct, 2021 1 commit
  25. 04 Oct, 2021 2 commits
  26. 03 Oct, 2021 1 commit
  27. 23 Sep, 2021 1 commit