GitLab

> [...]
> Proposed fix: Do the switchover to a new diagram on mouse button _release_
> not on _press_.
> Then, the release event could occur elsewhere than in the tree view; for
> example, on a note widget in the diagram area.

This would create behaviour that is not in line with the rest of Umbrello.
Rather than changing the press/release semantics, here is an implementation
for Copy from UMLListview and Paste onto NoteWidget in diagram:

umbrello/widgets/notewidget.h
- Add static NoteWidget *s_pCurrentNote.
  Putting this here instead of in UMLApp to reduce coupling.

umbrello/clipboard/umldragdata.cpp
- In function decodeClip2(), call UMLDragData::decodeObjects() only if
  NoteWidget::s_pCurrentNote is NULL.
- In function decodeViews() while-loop, if NoteWidget::s_pCurrentNote is non
  NULL then extract attribute "xmi.id" from diagramElement and call
  NoteWidget::s_pCurrentNote->setDiagramLink() with the extracted ID.

umbrello/clipboard/umlclipboard.cpp function pasteClip2()
- After call to UMLDragData::decodeClip2(), if NoteWidget::s_pCurrentNote is
  non NULL then reset it to NULL instead of adding the views to the UMLDoc.

umbrello/listpopupmenu.cpp
- In ctor ListPopupMenu(QWidget*,WidgetBase*,bool,WidgetBase::WidgetType),
  if object is a Note and UMLListView::startedCopy() is true then assign
  object to NoteWidget::s_pCurrentNote and setActionEnabled(mt_Paste, true).

umbrello/widgets/notewidget.cpp
- In function setDiagramLink() add missing final call to update() for
  display of new text.

CCBUG:67062

- In function contextMenuEvent() downgrade uError() on !parentMenu to
  uDebug(). This is a nominal operating condition (user escapes out.)

Related commit is 5bcb5337.
CCMAIL: okellogg@users.sourceforge.net

Related commit is 5bcb5337.
CCMAIL: okellogg@users.sourceforge.net

Compile Umbrello with -DQT_NO_CAST_FROM_ASCII and -DQT_NO_CAST_TO_ASCII.

- In function loadFromXMI() fix loading of attribute "showpubliconly".

CCBUG:330018

It was required to refactor the newly added 'doNotSearch' Import_Utils::createUMLObject()
parameter to a real 'searchInParentPackageOnly' strategy.

This enables classes with the same name in different name spaces.

CCBUG:330018
CCBUG:368810

The root cause for this issue is that CmdSetVisibility requires to have
the uml object in the document uml object list, which is not the case for
newly created attributes or operations on import.

CCBUG:337031

-DQT_NO_CAST_TO_ASCII, https://git.reviewboard.kde.org/r/119106/

Up next: umbrello/widgets/, umbrello/ main dir.

Example:
	class Bar {
	public:
	    typedef Bar* (*Foo)();
	};

CCBUG:330018

The fix prevents a ObjectWidget/MessageWidget signal/slot loop by using setPos()
instead of setY().

CCBUG:336997

- Store toolbar actions into action collection of class KXMLGUIClient,
  which is required to be listed in the shortcuts settings dialog.
  To be able to access tool bar actions with tbb_... constants, save
  tool bar actions in WorkToolBar::m_actions, which makes WorkToolBar::m_toolButtons
  and class ToolButton obsolate; tool bar related cursors are stored in
  WorkToolBar::m_cursors.
- Save changed shortcuts in [Shortcuts] section of umbrello settings file 'umbrellorc'
- Show tool bar button shortcut in button tooltip.

CCBUG:124804

It turns out that Umbrello do not use the arrow from umbrello icons for the default cursor.

This commit is a preparation for the tool bar icons shortcut support.

CCBUG:124804

- At calls to QDomElement::attribute() remove "" when given as optional arg

- Remove bogus test of m_pObjectNodeWidget->state() against NULL.
  ObjectNodeWidget::state() returns QString.

CCBUG:336810

- In function setGenerator() revert part of commit ea25b643 which returns
  preexisting m_codegen if (m_codegen->language() == pl).

umbrello/codegenerators/codegenerator.{h,cpp}
- New virtual function finalizeRun() with empty default implementation can
  be reimplemented by concrete code generators to perform additional
  cleanups or other actions that can only be performed once all code has
  been written. The function is called in writeCodeToFile() after return
  from writeListedCodeDocsToFile().

umbrello/codegenerators/simplecodegenerator.cpp
- In function writeCodeToFile(), utilize writeCodeToFile(concepts) for
  minimizing code duplication.
- In function writeCodeToFile(UMLClassifierList&),
  - do not writeClass(c) if Model_Utils::isCommonDataType(c->name());
  - call finalizeRun() after foreach loop over `concepts'.

umbrello/codegenerators/ada/adawriter.{h,cpp}
- Add `static' on declaration of functions isOOClass() and packageName().
- New function declareClass() factors trunk of Ada declaration which is
  common to partial (public) and full (private) view.
- Reimplement function finalizeRun() from CodeGenerator: Cumulative
  generation of the private part is moved from writeClass() to here.
- New member m_pkgsGenerated is required for closing opened files in
  finalizeRun().
- New member m_classesGenerated is required for ensuring that order of code
  generation is consistent with order of dependencies among classifiers in
  the package.

umbrello/codegenerators/ada/adawriter.cpp function writeClass()
- Return immediately without further action if `c' is already present in
  m_classesGenerated.
- If `pkg' is found in m_pkgsGenerated then do not open file / write
  initial declarations but instead use the value() of the PackageFileMap::
  iterator found for `file'.
- If `pkg' is found in m_pkgsGenerated then:
  - Open file and write initial declarations; in loop over `imports', do not
    write "with" if packageName(con) does not match `pkg'.
  - Assign `file' into m_pkgsGenerated[pkg].
- Before declaring the Ada type mapped from `c', loop over
  c->getSuperClasses() and ensure that superclasses in same package are
  written beforehand.
- Move all aggregation/composition/attribute handling to finalizeRun().

umbrello/codegenerators/ada/adawriter.cpp function reservedKeywords()
- Add Ada2005 reserved word "interface".

BUG:336933

- In function writeClassDecl() remove extraneous generated ';' after closing
  of namespace.

The problem was, that Import_Utils::createUMLObject() tries to find an object
in different namespaces and only creates an uml object if not found.

In the case of parsing a c++ import class specification we simply need
to create the related uml class object in the current namespace, which
is provided by the additional parameter "doNotSearch".

Related test case is https://bugs.kde.org/show_bug.cgi?id=336810#c10

CCBUG:368810

PHP5 writer fix: Exclude realization to self, which creates additional wrong 'implement' methods on interface classes.

It is currently unknown why there is an realization to self, which may also affect other code generators.

CCBUG:336889

For currently unknown reason a ClassifierWidget instance may
have an associated UMLPackage object instead of an UMLClassifier
object. Casting the UMLPackage instance to UMLClassifier
returns a zero pointer, which has to be guarded.

php5 generator fix: Hide misleading warning when using single inheritance and multiple implementations which is supported by php5.

CCBUG:336889

umbrello/dialogs/dialog_utils.{h,cpp}
- Move function insertStereotypesSorted() from ClassGeneralPage to
  Dialog_Utils.

umbrello/dialogs/pages/associationgeneralpage.{h,cpp}
- Allow for selection of stereotype in place of name.