Simon Redman (22bb17f6) at 25 Mar 22:24
@mintsoft , gentle ping - There's a linter error which is preventing this from merging.
This is an update similar to 8fed0728. 23.08.1 is the latest version I found under https://download.kde.org/Attic/release-service/. The sha256 checksum and the file size is copied from https://download.kde.org/Attic/release-service/23.08.1/windows/kdeconnect-kde-23.08.1-1463-windows-cl-msvc2019-x86_64.exe.mirrorlist.
Since 24.02 is now available, I have started the process of cutting a stable release from that, so I will close this MR.
As a follow up from review in !345 this is now a separated merge request to fix timestamps not being updated when content observer observes changes
I bundled this into !351 (merged) - Closing this MR.
By having one notification for all received files we loose features such as image preview and share action. The notifications are added to a group so even if there are a lot it only takes up minimal space initially and can be expanded on demand. For this the ShareNotification is split up into 1 progress notification for all files and a finished Notification for each file
Closing this since it has been idle for awhile and IIRC we decided to not go forward with it.
I missed the integration of VoIP apps with KDE connect. Therefore I made a setup using a plugin.
The plugin functionality in short:
I have tested myself:
Working:
Not working yet:
To Be tested:
I would like to ask you to test as many other VoIP apps as possible.
Closing this since it has been idle for awhile. Please feel free to update and reopen it if you want to pick it back up.
The initial sync is just too slow that causes the desktop SMS app to fail when sending and replying to message threads because the first message is never available in time for the conversation id to populate, or https://invent.kde.org/network/kdeconnect-kde/-/blob/master/plugins/sms/conversationsdbusinterface.cpp#L193 this fails when sending a SMS from the SMS app since conversationID
is missing. Using a threaded environment seems to really speeds up the initial first messages sync.
Sync when receiving and sending SMS fails in conversations because in sendLatestMessage() the latest timestamp is always reported as 0, so the desktop SMS app never receives any updates when new messages are sent / received, adds a method to resolve the latest message timestamp whenever the ContentObserver receives a change in status of new incoming and outgoing SMS.
I think the interesting part sof this were handled in !351 (merged) and !352 (closed), so I'm going to close this MR.
Yes, adding a plugin like that would be possible.
As Matthijs said above, the chosen implementation in this case was to annotate notifications with a property to indicate to the client whether they should disturb the user or not. This works in all desktop environments, etc.
Please add these questions and answers to the test plan
SharePlugin inherits from the base Plugin, which has an OnCreate method. The SharePlugin could override this with its customer behavior, which would get executed every time the plugin is created (which happens every time the devices are connected). Putting it there would be cleaner than having this plugin-specific implementation in the daemon.
Checking at the time the notification is created would be tricky. What do you do if the setting changes after the notification is posted?
Yes, the button calls ClipboardListener.onClipboardChanged
. This is the same path as the automatic sync would call, so you can't just check whether the setting is set there, otherwise you would break this new feature you're trying to add.
My suggestion was to add some kind of "force update" parameter, which could be set by the buttons, so when the user manually clicks something, it could bypass the settings check. that's not a very nice workaround, but you know this code area better than I do at this point, so you might be able to find a better way.
A recent (couple of weeks ago?) change to the Invent policies requires that we use a docker image from an allow list.
The cleanest fix is to just use the Ubuntu base image and install the JDK, which is approximately what we had before.
We considered the Sysadmin Android image (https://invent.kde.org/sysadmin/ci-images/-/blob/master/android-qt66/Dockerfile?ref_type=heads), but we use a newer version of the SDK tools and a newer version of the JDK, at which point we may as well just install those since those are the only dependencies. We could consider building another custom docker image in the future if we see value to doing so.
CI fails with:
ERROR: The "eclipse-temurin:17-jdk-focal" image is not present on list of allowed images:
- invent-registry.kde.org/sysadmin/ci-images/*:*
- ubuntu:*
- debian:*
- fedora:*
- centos:*
- opensuse/*:*
- python:*
- ruby:*
- fsfe/reuse:*
- quay.io/podman/stable:*
Build passes and drops .apk
Simon Redman (2b785979) at 17 Mar 17:43
Try headless OpenJDK
Simon Redman (549212f1) at 17 Mar 17:36
Update .gitlab-ci.yml