1. 27 Feb, 2019 1 commit
    • Simon Redman's avatar
      [SMS App] Add highlighting to ConversationList view · f148ec7a
      Simon Redman authored
      Summary: Let the ListView use its default highlighting (did I not notice before?) and keep the currently-selected chat highlighted at all times
      
      Test Plan:
       - Launch app
       - Use mouse or arrow keys to select a conversation. The highlight should follow the selected conversation
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17612
      f148ec7a
  2. 23 Jan, 2019 3 commits
  3. 22 Jan, 2019 3 commits
  4. 21 Jan, 2019 1 commit
    • Simon Redman's avatar
      Cache and delete old ConversationsDbusInterfaces to avoid memory leak · 74ba660c
      Simon Redman authored
      Summary:
      After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
      
      This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?
      
      Test Plan:
      - Run daemon
      - Hopefully experience no crashes after many phone reconnects
      
      Reviewers: #kde_connect, apol, albertvaka
      
      Reviewed By: #kde_connect, apol, albertvaka
      
      Subscribers: apol, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16553
      74ba660c
  5. 19 Jan, 2019 1 commit
    • Matthijs Tijink's avatar
      Add description of bluetooth multiplexing protocol · e77c1c87
      Matthijs Tijink authored
      Summary:
      As mentioned on telegram, there are some fundamental issues with bluetooth. The only approach I could get working was multiplexing: manually sending multiple streams of data over a single connection.
      
      This is the description of that multiplexing protocol. I have an implementation of this protocol, but I'd first like some feedback to see if this is what we're going to use before finishing up those patches.
      
      See the document itself for more details. I make the protocol forward-compatible, although I don't expect we will need ever that.
      
      Test Plan: None, this is just a description.
      
      Reviewers: #kde_connect, andyholmes, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17987
      e77c1c87
  6. 18 Jan, 2019 1 commit
    • Nicolas Fella's avatar
      Allow newer TLS versions · 1b20ecec
      Nicolas Fella authored
      Summary:
      Instead of mandating TLS V1.0 use 1.0 or later.
      BUG: 400338
      
      Test Plan: Phone connects
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: thomasp, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D18217
      1b20ecec
  7. 16 Jan, 2019 1 commit
    • Erik Duisters's avatar
      Just set UDSEntry::UDS_NAME to the actual directory name instead of the... · 4834b635
      Erik Duisters authored
      Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all
      
      Summary: There is no reason to set UDSEntry::UDS_NAME to "folder" and then override it with UDSEntry::UDS_DISPLAY_NAME
      
      Test Plan:
      Apply patch, click android device in dolphin's Devices list
      Verify phones sdcards are listed as befor
      
      Reviewers: #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D18223
      4834b635
  8. 14 Jan, 2019 1 commit
  9. 09 Jan, 2019 1 commit
  10. 06 Jan, 2019 2 commits
    • Erik Duisters's avatar
      Do not close m_socket in socketError() · 9f5cdf1a
      Erik Duisters authored
      Summary:
      When android closes the payload socket (cancel share) calling m_socket.close() results
      in a recursive call to onError eventually leading to a segmentation violation
      
      Test Plan:
      Install D16491, share a large file from desktop to android and cancel the share on Android through
       the notification. kdeconnectd crashes almost 100% of the time. (It doesn't crash when it detects
       a disconnect in sendNextPacket)
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17628
      9f5cdf1a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 71c5a1b2
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      71c5a1b2
  11. 02 Jan, 2019 1 commit
    • Simon Redman's avatar
      Implement Drag n Drop file transfer on the plasmoid · bafbc344
      Simon Redman authored
      Summary:
      A DropArea has been added to the ListItem representing a device in the
      plasmoid based on what is done in the Quickshare plasmoid. This enables
      Drag n Drop of files onto a section of the plasmoid to transfer files.
      
      The DropArea has the size of the ListItem which is a rectangle
      including the title of the device down to the button to share text.
      Additionally, there is a tooltip area covering the DropArea to indicate
      that it is possible to drop a file to send it to the device. Multiple files
      can be sent at once.
      
      Ref T8288
      
      Test Plan: Drag and Drop one or many files onto the widget, the files should be transferred to the connected device.
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: sredman, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8288
      
      Differential Revision: https://phabricator.kde.org/D17611
      bafbc344
  12. 31 Dec, 2018 1 commit
    • Matthijs Tijink's avatar
      Add handling for the identity packet to be split across two messages. · 97551d09
      Matthijs Tijink authored
      Summary: If the identity packet is split across two packets, then save it until we get a notification that more data is available for reading over the bluetooth link.
      
      Test Plan: Connect a phone and laptop over Bluetooth, and verify that both the phone and laptop are able to see each other, and that either side can start and successfully go through the pairing process.
      
      Reviewers: #kde_connect, mtijink
      
      Reviewed By: #kde_connect, mtijink
      
      Subscribers: mtijink, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17789
      97551d09
  13. 29 Dec, 2018 1 commit
  14. 25 Dec, 2018 4 commits
  15. 24 Dec, 2018 2 commits
  16. 23 Dec, 2018 1 commit
  17. 21 Dec, 2018 1 commit
    • Jun Bo Bi's avatar
      [mpriscontrol] add primitive windows support · f4c7e12e
      Jun Bo Bi authored
      Summary: Added primitive support for the mpriscontrol plugin on Windows by simulating VK_MEDIA key presses. I took a look into `ISystemMediaTransportControls`, but there doesn't seem to query it since it's per app. Leaving simulating key presses our only option for now. Completes T10000
      
      Reviewers: kdeconnect, #kde_connect, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka
      
      Tags: #kde_connect, #windows
      
      Maniphest Tasks: T10000
      
      Differential Revision: https://phabricator.kde.org/D17702
      f4c7e12e
  18. 18 Dec, 2018 1 commit
  19. 17 Dec, 2018 1 commit
    • Simon Redman's avatar
      [SMS App] Improve filter · 5b213e61
      Simon Redman authored
      Summary:
      - Allow filter box to handle keystrokes passed to the ListView
       - This is a little cheesy, but fixes T8341
      
      - Pin filter box to always be visible
      
      - Clear filter on Esc
      
      Test Plan:
      - Try typing a contact you would like to search for
       - Before: Every time you type a new letter, the filter box would lose focus and you would have to click it to give it focus again
       - Now: You can type smoothly
      
      - Try scrolling the list
       - Before: The filter box disappeared off the top of the screen
       - Now: The filter box is always visible
      
      - Try pressing escape
       - Before: Nothing
       - Now: Filter clears
      
      - Bonus: When using the arrow keys to navigate, before the filter was manually handling those and the view would not loop. Now, the view loops if you try to select an item past the beginning or end (Easiest to see with highlighting from D17612)
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T8341
      
      Differential Revision: https://phabricator.kde.org/D17614
      5b213e61
  20. 16 Dec, 2018 1 commit
  21. 14 Dec, 2018 2 commits
  22. 13 Dec, 2018 3 commits
    • Simon Redman's avatar
      [SMS App] Allow scrolling up to load and display older messages · 2c35c1af
      Simon Redman authored
      Summary:
      Scroll up to show older messages
      
      Newly received messages will not force the view to the bottom unless the new message is being added "very close" to the visible area
      
      Test Plan:
      Message History:
       - Open conversation
       - Scroll/Drag up to load older messages
      
      New Message:
       - Open conversation
       - Scroll to bottom
       - Verify that a newly-received or newly-sent message is added to the GUI
       - Scroll up
       - Verify that sending/receiving a message does not disturb the view
       - Scroll back to verify that the new message was indeed added to the list
      
      Reviewers: #kde_connect, apol
      
      Reviewed By: #kde_connect, apol
      
      Subscribers: apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Maniphest Tasks: T9556
      
      Differential Revision: https://phabricator.kde.org/D15979
      2c35c1af
    • Simon Redman's avatar
    • Simon Redman's avatar
      [SMS App] Make requestMoreMessages asynchronous, blocking, and caching · 019e8d6a
      Simon Redman authored
      Summary:
      The most serious change from this patch is to move the asynchronous replying to a request from the app for more messages to a newly-spawned, self-destructing thread. Within that thread, we block until the remote device replies with the requested messages.
      
      All gotten messages are cached in the ConversationDbusInterface, so all future requests are fast and don't hit the remote device.
      
      Test Plan: After applying this diff, the messaging app should show 10 messages every time it is opened
      
      Reviewers: #kde_connect, nicolasfella, albertvaka
      
      Reviewed By: #kde_connect, albertvaka
      
      Subscribers: albertvaka, apol, nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D16475
      019e8d6a
  23. 12 Dec, 2018 1 commit
    • Simon Redman's avatar
      [Desktop] Change ThreadID to long · 5cdfb9b0
      Simon Redman authored
      Summary: Change ThreadID to long
      
      Test Plan:
      Messages should send and receive as before. Additionally, if your device has assigned extremely large ThreadIDs, the SMS plugin should no longer crash.
      
      This patch corresponds to the Android-side revision D17517
      
      Reviewers: #kde_connect, nicolasfella
      
      Reviewed By: #kde_connect, nicolasfella
      
      Subscribers: nicolasfella, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17516
      5cdfb9b0
  24. 11 Dec, 2018 1 commit
  25. 07 Dec, 2018 2 commits
  26. 06 Dec, 2018 1 commit
    • Nicolas Fella's avatar
      Don't use kcmshell5 for opening the KCM · d26d2ada
      Nicolas Fella authored
      Summary:
      kcmshell5 depends on plasma-workspace. By using our own tiny wrapper for opening the KCM we avoid pulling
      in plasma-workspace and everything that comes with it on non-Plasma systems.
      
      Test Plan: kdeconnect-settings shows the KCM
      
      Reviewers: #kde_connect, sredman
      
      Reviewed By: #kde_connect, sredman
      
      Subscribers: sredman, kdeconnect
      
      Tags: #kde_connect
      
      Differential Revision: https://phabricator.kde.org/D17383
      d26d2ada
  27. 04 Dec, 2018 1 commit