Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Dolphin Dolphin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SystemSystem
  • DolphinDolphin
  • Repository
Switch branch/tag
  • dolphin
  • src
  • kitemviews
  • kfileitemmodel.cpp
Find file BlameHistoryPermalink
  • Martin Tobias Holmedahl Sandsmark's avatar
    Fix crashing on starting and quitting · 35b4c6d4
    Martin Tobias Holmedahl Sandsmark authored Apr 07, 2020
    QCollator (especially with Qt 5.14 and ICU 65.1) is very unhappy with
    threads.
    
    To avoid having to lock and unlock the mutex everywhere (and ensure it
    is unlocked before calling other things that might lock it, etc.), we do
    it as locally as possible. Even if for some reason Qt and ICU make
    QCollator threadsafe in the future locking here should have minimal
    impact.
    
    BUG: 419585
    
    Differential Revision: https://phabricator.kde.org/D28659
    35b4c6d4