• Andreas Krutzler's avatar
    Fix scrolling during inline renaming causes rename of wrong file · 5bee1889
    Andreas Krutzler authored
    Summary:
    Scrolling during inline renaming accepts the renaming now, like if one would hit Return for example. I chose this approach because it seems the easiest way to fix this.
    This also fixes the “possible” Ui glitch where the renaming KTextField doesn’t move along with the list item. Possible glitch, because I don’t know if this is intentional, but for me it looks broken.
    
    BUG: 378786
    Fixes T7443
    
    Test Plan:
    * Enable "Rename inline" in dolphin settings
    * Go to a folder where you have to scroll through items (many files, big zoom,…)
    * Start to rename a file (context menu, F2, …)
    * Scroll with mouse wheel
    * Rename  accepted -> file is renamed
    
    Reviewers: ngraham, rkflx, #dolphin, elvisangelaccio
    
    Reviewed By: ngraham, rkflx, #dolphin, elvisangelaccio
    
    Subscribers: anthonyfieroni, elvisangelaccio, #dolphin
    
    Maniphest Tasks: T7443
    
    Differential Revision: https://phabricator.kde.org/D8822
    5bee1889
kstandarditemlistwidget.cpp 53.6 KB