Skip to content
  • Anton Kreuzkamp's avatar
    KItemListWidget: Use initStyleOption · 037d2c99
    Anton Kreuzkamp authored
    Instead of using QStyleOption::initFrom, let's use
    QGraphicsWidget::initStyleOption, which is made for exactly the purpose
    of KItemListWidget. This is especially important since, according to the
    docs of QGraphicsItem::paint "The widget argument is optional. [...]
    For cached painting, widget is always 0.". Even though currently no code
    in dolphin does cached painting, for the sake of modularity one should
    not rely on widget to be non-null. Using QStyleOption::initFrom does
    assume that, though.
    
    In fact, GammaRay asks the items to do cached painting when attaching it
    to the application, causing it to crash.
    037d2c99