Commit 14f0cd52 authored by Nate Graham's avatar Nate Graham
Browse files

Don't show "Open With" menu items for empty directories

Any app that registers itself as able to open directories generally can't do anything
useful with an empty directory. So, don't show the {nav Open With} menu items for them.

Test Plan:
Before: {F6759793}

After: {F6759794}

The {nav Open With} items still appear for non-empty directories.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: trmdi, kfm-devel

Tags: #dolphin

Differential Revision:
parent dbc5e571
......@@ -351,7 +351,12 @@ void DolphinContextMenu::openViewportContextMenu()
KFileItemActions fileItemActions;
// Don't show "Open With" menu items if the current dir is empty, because there's
// generally no app that can do anything interesting with an empty directory
if (view->itemsCount() != 0) {
// Insert 'New Window' and 'New Tab' entries. Don't use "open_in_new_window" and
// "open_in_new_tab" here, as the current selection should get ignored.
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment