Commit 3dd49a85 authored by Felix Ernst's avatar Felix Ernst 🇺🇦
Browse files

[dolphinview] Disconnect modelChanged when destructing

Deleting DolphinView deletes KItemListContainer, which deletes
KItemListController, which emits modelChanged, which causes a
signal delivery to the already destroyed DolphinView

This is never good, and in Qt6 causes an assert
(https://codereview.qt-project.org/c/qt/qtbase/+/381860

).

Co-authored-by: Nicolas Fella's avatarNicolas Fella <nicolas.fella@gmx.de>
parent 8ff021ca
Pipeline #232426 passed with stage
in 17 minutes and 10 seconds
......@@ -235,6 +235,7 @@ DolphinView::DolphinView(const QUrl& url, QWidget* parent) :
DolphinView::~DolphinView()
{
disconnect(m_container->controller(), &KItemListController::modelChanged, this, &DolphinView::slotModelChanged);
}
QUrl DolphinView::url() const
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment