Commit 4c923a53 authored by Nate Graham's avatar Nate Graham
Browse files

Restore former position of "Create New" menu item in viewport context menu

Summary:
I've seem various complaints from users about the fact that the {nav Create New...} menu
item in the viewport context menu is now below {nav Open With} item. All the other
changes to menus seem to have been well-received but this one has garnered criticism.
Looking through D23757 and D11884, I can't actually see that this was intentional, so
it might even be a bug.

Either way, this patch restores the old position of the {nav Create New} menu items at
the top of the Viewport context menu.

BUG: 417640
FIXED-IN: 20.04.0

Test Plan: {F8093605}

Reviewers: #vdg, #dolphin, elvisangelaccio, ndavis

Reviewed By: #vdg, ndavis

Subscribers: asturmlechner, markuss, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D27267
parent 402f7f30
......@@ -342,12 +342,6 @@ void DolphinContextMenu::openViewportContextMenu()
fileItemActions.setParentWidget(m_mainWindow);
fileItemActions.setItemListProperties(baseUrlProperties);
// Don't show "Open With" menu items if the current dir is empty, because there's
// generally no app that can do anything interesting with an empty directory
if (view->itemsCount() != 0) {
addOpenWithActions(fileItemActions);
}
// Set up and insert 'Create New' menu
KNewFileMenu* newFileMenu = m_mainWindow->newFileMenu();
newFileMenu->setViewShowsHiddenFiles(view->hiddenFilesShown());
......@@ -355,6 +349,12 @@ void DolphinContextMenu::openViewportContextMenu()
newFileMenu->setPopupFiles(QList<QUrl>() << m_baseUrl);
addMenu(newFileMenu->menu());
// Don't show "Open With" menu items if the current dir is empty, because there's
// generally no app that can do anything interesting with an empty directory
if (view->itemsCount() != 0) {
addOpenWithActions(fileItemActions);
}
QAction* pasteAction = createPasteAction();
addAction(pasteAction);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment