Commit 57cdee59 authored by Felix Ernst's avatar Felix Ernst 🇺🇦 Committed by Felix Ernst
Browse files

Change the full row highlight checkbox to radiobuttons

This commit changes how the setting to switch between full row
highlight and the old way of only having the icons and names be
activatable in details mode is presented on the settings page.

Before this commit a singular checkbox is used that talks about
the highlight effect.

But the highlight effect isn't actually what users should be
interested in. They mostly care how much of the area can be used to
activate an item. To make this clear this commit uses radio buttons
instead that give a distinctive choice between activation areas.
parent a4fc7b0b
......@@ -101,8 +101,17 @@ ViewSettingsTab::ViewSettingsTab(Mode mode, QWidget* parent) :
m_expandableFolders = new QCheckBox(i18nc("@option:check", "Expandable"));
topLayout->addRow(i18nc("@label:checkbox", "Folders:"), m_expandableFolders);
m_highlightEntireRow = new QCheckBox(i18nc("@option:check", "Highlight entire row"));
topLayout->addRow(i18nc("@label:checkbox", "Selection effect:"), m_highlightEntireRow);
// Item activation area
m_entireRow = new QRadioButton(i18nc("@option:radio how files/folders are opened", "By clicking anywhere on the row"));
m_iconAndNameOnly = new QRadioButton(i18nc("@option:radio how files/folders are opened", "By clicking on icon or name"));
auto itemActivationAreaGroup = new QButtonGroup(this);
// i18n: Users can choose here if items are opened by clicking on their name/icon or by clicking in the row.
topLayout->addRow(i18nc("@title:group", "Open files and folders:"), m_entireRow);
topLayout->addRow(QString(), m_iconAndNameOnly);
#ifndef Q_OS_WIN
......@@ -165,7 +174,7 @@ ViewSettingsTab::ViewSettingsTab(Mode mode, QWidget* parent) :
connect(m_widthBox, &QComboBox::currentIndexChanged, this, &ViewSettingsTab::changed);
case DetailsMode:
connect(m_highlightEntireRow, &QCheckBox::toggled, this, &ViewSettingsTab::changed);
connect(m_entireRow, &QCheckBox::toggled, this, &ViewSettingsTab::changed);
connect(m_expandableFolders, &QCheckBox::toggled, this, &ViewSettingsTab::changed);
#ifndef Q_OS_WIN
connect(m_recursiveDirectorySizeLimit, &QSpinBox::valueChanged, this, &ViewSettingsTab::changed);
......@@ -202,20 +211,20 @@ void ViewSettingsTab::applySettings()
case DetailsMode:
// We need side-padding when the full row is a click target to still be able to not click items.
// So here the default padding is enabled when the full row highlight is enabled.
if (m_highlightEntireRow->isChecked() && !DetailsModeSettings::highlightEntireRow()) {
if (m_entireRow->isChecked() && !DetailsModeSettings::highlightEntireRow()) {
auto detailsModeSettings = DetailsModeSettings::self();
const bool usedDefaults = detailsModeSettings->useDefaults(true);
const int defaultSidePadding = detailsModeSettings->sidePadding();
const uint defaultSidePadding = detailsModeSettings->sidePadding();
if (DetailsModeSettings::sidePadding() < defaultSidePadding) {
} else if (!m_highlightEntireRow->isChecked() && DetailsModeSettings::highlightEntireRow()) {
} else if (!m_entireRow->isChecked() && DetailsModeSettings::highlightEntireRow()) {
// The full row click target is disabled so now most of the view area can be used to interact
// with the view background. Having an extra side padding has no usability benefit in this case.
#ifndef Q_OS_WIN
......@@ -259,7 +268,8 @@ void ViewSettingsTab::loadSettings()
case DetailsMode:
#ifndef Q_OS_WIN
if (DetailsModeSettings::directorySizeCount()) {
......@@ -56,7 +56,8 @@ private:
DolphinFontRequester* m_fontRequester;
QComboBox* m_widthBox;
QComboBox* m_maxLinesBox;
QCheckBox* m_highlightEntireRow;
QRadioButton* m_entireRow;
QRadioButton* m_iconAndNameOnly;
QCheckBox* m_expandableFolders;
QRadioButton* m_numberOfItems;
QRadioButton* m_sizeOfContents;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment