Commit b6ec4b1c authored by Alexander Lohnau's avatar Alexander Lohnau 💬
Browse files

Remove code path for loading deprecated VSC plugins

In case there are custom, old plugin lying around they can't be loaded
anyways, because the version does not match. In case that gets fixed one
could just port the plugin to JSON metadata.

Also the mechanism that is used is about to be deprecated.
parent 9fc92e7b
Pipeline #63655 passed with stage
in 5 minutes and 7 seconds
......@@ -297,27 +297,6 @@ void VersionControlObserver::initPlugins()
// Deprecated: load plugins using KService. This mechanism will be removed with KF6
const KService::List pluginServices = KServiceTypeTrader::self()->query(QStringLiteral("FileViewVersionControlPlugin"));
for (KService::List::ConstIterator it = pluginServices.constBegin(); it != pluginServices.constEnd(); ++it) {
if (loadedPlugins.contains((*it)->property("Name", QVariant::String).toString())) {
if (enabledPlugins.contains((*it)->name())) {
KPluginLoader pluginLoader(*(*it));
// Need to cast to int, because pluginVersion() returns -1 as
// an unsigned int for plugins without versions.
if (int(pluginLoader.pluginVersion()) < 2) {
qCWarning(DolphinDebug) << "Can't load old plugin" << (*it)->name();
KVersionControlPlugin* plugin = (*it)->createInstance<KVersionControlPlugin>(this);
if (plugin) {
for (auto &plugin : qAsConst(m_plugins)) {
connect(plugin, &KVersionControlPlugin::itemVersionsChanged,
this, &VersionControlObserver::silentDirectoryVerification);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment