Commit d094c8ff authored by Frank Reininghaus's avatar Frank Reininghaus

DolphinContextMenu: Do not check if the clicked folder is in the Places

This prevents that the setup of the PlacesItemModel queries Solid for
the available devices, which can take some time.

Places can be added multiple times now using the context menu, but this
has always been possible with drag and drop anyway.

See for a dicsussion
on this topic.

REVIEW: 126904
parent 2257b94e
......@@ -427,16 +427,11 @@ void DolphinContextMenu::addShowMenuBarAction()
bool DolphinContextMenu::placeExists(const QUrl& url) const
PlacesItemModel model;
const int count = model.count();
for (int i = 0; i < count; ++i) {
const QUrl placeUrl = model.placesItem(i)->url();
if (placeUrl.matches(url, QUrl::StripTrailingSlash)) {
return true;
// Creating up a PlacesItemModel to find out if 'url' is one of the Places
// can be expensive because the model asks Solid for the devices which are
// available, which can take some time.
// TODO: Consider restoring this check if the handling of Places and devices
// will be decoupled in the future.
return false;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment