Commit d863dd9a authored by Nate Graham's avatar Nate Graham
Browse files

Elide tab titles left so key information at the end of the string doesn't get cut off

Tab Titles currently elide right. Generally the more useful information is at the right
side of the string--even more so when full paths are being used.

BUG: 406569
FIXED-IN: 19.04.2

Test Plan:
- No change when tab titles don't get elided
- When tabs show the full path and titles are elided, they're now useful: {F6782447}
- When tabs don't show the full path and are elided, they're elided on the other side which seems maybe a tiny bit better, but at least no worse: {F6782448}

Reviewers: #dolphin, #vdg, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: ndavis, elvisangelaccio, kneckermcknacksack, filipf, kfm-devel

Tags: #dolphin

Differential Revision:
parent f3e966e0
......@@ -19,6 +19,7 @@
#include "dolphintabwidget.h"
#include "dolphin_generalsettings.h"
#include "dolphintabbar.h"
#include "dolphintabpage.h"
#include "dolphinviewcontainer.h"
......@@ -114,6 +115,14 @@ void DolphinTabWidget::readProperties(const KConfigGroup& group)
void DolphinTabWidget::refreshViews()
// Left-elision is better when showing full paths, since you care most
// about the current directory which is on the right
if (GeneralSettings::showFullPathInTitlebar()) {
} else {
const int tabCount = count();
for (int i = 0; i < tabCount; ++i) {
tabBar()->setTabText(i, tabName(tabPageAt(i)));
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment