Commit fde79c09 authored by luz paz's avatar luz paz
Browse files

Fix various typos

Found via `codespell -q 3 -S *.desktop,*.xml`
parent 73e919a4
Pipeline #106060 passed with stage
in 4 minutes and 49 seconds
......@@ -57,7 +57,7 @@ public:
* This method should preferably only be called when:
* - Split view is activated in the active tab
* OR
* - A switch to a tab that is already in split view mode is occuring
* - A switch to a tab that is already in split view mode is occurring
*/
void createSecondaryUrlNavigator();
......@@ -92,7 +92,7 @@ protected:
* this method always returns the same widget and reparents it.
* You normally don't have to use this method directly because
* QWidgetAction::requestWidget() is used to obtain the navigatorsWidget
* and to steal it from whereever it was prior.
* and to steal it from wherever it was prior.
* @param parent the new parent of the navigatorsWidget.
*/
QWidget *createWidget(QWidget *parent) override;
......
......@@ -46,7 +46,7 @@ public:
*
* @param enabled If true, creates a secondary viewContainer in this tab.
* Otherwise deletes it.
* @param animated Decides wether the effects of this method call should
* @param animated Decides whether the effects of this method call should
* happen instantly or be transitioned to smoothly.
* @param secondaryUrl If \p enabled is true, the new viewContainer will be opened at this
* parameter. The default value will set the Url of the new viewContainer
......
......@@ -41,7 +41,7 @@ public Q_SLOTS:
private:
/**
* @return wether the places selector of DolphinUrlNavigators should be visible.
* @return whether the places selector of DolphinUrlNavigators should be visible.
*/
static bool placesSelectorVisible();
......
......@@ -126,7 +126,7 @@ public:
void connectUrlNavigator(DolphinUrlNavigator *urlNavigator);
/**
* Disconnects the navigator that is currently controling the view.
* Disconnects the navigator that is currently controlling the view.
* This method completely reverses connectUrlNavigator().
*/
void disconnectUrlNavigator();
......
......@@ -2241,7 +2241,7 @@ QHash<QByteArray, qreal> KItemListView::preferredColumnWidths(const KItemRangeLi
widths.insert(visibleRole, headerWidth);
}
// Calculate the preferred column withs for each item and ignore values
// Calculate the preferred column widths for each item and ignore values
// smaller than the width for showing the headline unclipped.
const KItemListWidgetCreatorBase* creator = widgetCreator();
int calculatedItemCount = 0;
......
......@@ -597,7 +597,7 @@ private:
/**
* Resizes the column-widths of m_headerWidget based on the preferred widths
* and the vailable view-size.
* and the available view-size.
*/
void applyAutomaticColumnWidths();
......@@ -873,7 +873,7 @@ qreal KItemListWidgetCreator<T>::preferredRoleColumnWidth(const QByteArray& role
* @brief Base class for creating KItemListGroupHeaders.
*
* It is recommended that applications simply use the KItemListGroupHeaderCreator-template class.
* For a custom implementation the methods create() and recyle() must be reimplemented.
* For a custom implementation the methods create() and recycle() must be reimplemented.
* The intention of the group-header creator is to prevent repetitive and expensive instantiations and
* deletions of KItemListGroupHeaders by recycling existing header instances.
*/
......
......@@ -251,7 +251,7 @@ void KItemListHeaderWidget::mouseMoveEvent(QGraphicsSceneMouseEvent* event)
case NoRoleOperation:
if ((event->pos() - m_pressedMousePos).manhattanLength() >= QApplication::startDragDistance()) {
// A role gets dragged by the user. Create a pixmap of the role that will get
// synchronized on each furter mouse-move-event with the mouse-position.
// synchronized on each further mouse-move-event with the mouse-position.
m_roleOperation = MoveRoleOperation;
const int roleIndex = roleIndexAt(m_pressedMousePos);
m_movingRole.index = roleIndex;
......
......@@ -55,7 +55,7 @@ void KItemListKeyboardSearchManager::addKeys(const QString& keys)
const bool searchFromNextItem = (!m_isSearchRestarted && newSearch) || sameKey;
// to remember not to searchFromNextItem if selection was deselected
// loosing keyboard search context basically
// losing keyboard search context basically
m_isSearchRestarted = false;
Q_EMIT changeCurrentItem(sameKey ? firstKey : m_searchedString, searchFromNextItem);
......
......@@ -520,7 +520,7 @@ void KFileItemModelTest::testExpandItems()
// Test expanding subfolders in a folder with the items "a/", "a/a/", "a/a/1", "a/a-1/", "a/a-1/1".
// Besides testing the basic item expansion functionality, the test makes sure that
// KFileItemModel::expansionLevelsCompare(const KFileItem& a, const KFileItem& b)
// yields the correct result for "a/a/1" and "a/a-1/", whis is non-trivial because they share the
// yields the correct result for "a/a/1" and "a/a-1/", which is non-trivial because they share the
// first three characters.
QSet<QByteArray> originalModelRoles = m_model->roles();
QSet<QByteArray> modelRoles = originalModelRoles;
......
......@@ -458,7 +458,7 @@ Q_SIGNALS:
/** Is emitted if the 'grouped sorting' property has been changed. */
void groupedSortingChanged(bool groupedSorting);
/** Is emmited in reaction to a requestStatusBarText() call.
/** Is emitted in reaction to a requestStatusBarText() call.
* @see requestStatusBarText() */
void statusBarTextChanged(QString statusBarText);
......
......@@ -142,8 +142,8 @@ public:
virtual QString fileName() const = 0;
/**
* Returns the path of the local repository root for the versionned directory
* Returns an emtpy QString when directory is not part of a working copy
* Returns the path of the local repository root for the versioned directory
* Returns an empty QString when directory is not part of a working copy
*/
virtual QString localRepositoryRoot(const QString& directory) const;
......
......@@ -135,7 +135,7 @@ void VersionControlObserver::slotItemsChanged(const KItemRangeList& itemRanges,
{
Q_UNUSED(itemRanges)
// Because "version" role is emitted by VCS plugin (ourselfs) we don't need to
// Because "version" role is emitted by VCS plugin (ourselves) we don't need to
// analyze it and update directory item states information. So lets check if
// there is only "version".
if ( !(roles.count() == 1 && roles.contains("version")) ) {
......@@ -163,7 +163,7 @@ void VersionControlObserver::verifyDirectory()
// by an immediate verification.
m_dirVerificationTimer->setInterval(500);
} else {
// View was versionned but should not be anymore
// View was versioned but should not be anymore
updateItemStates();
}
} else if ((m_plugin = searchPlugin(rootItem.url()))) {
......
......@@ -95,7 +95,7 @@ private Q_SLOTS:
/**
* Is invoked if the thread m_updateItemStatesThread has been finished
* and applys the item states.
* and applies the item states.
*/
void slotThreadFinished();
......
  • remote: Audit failure - Commit fde79c09cb9ae5991d6b36c7c1d125628f2c7914 - Email address using a blocked domain: luzpaz@users.noreply.github.com
    remote: Should the audit failures above mention issues regarding your name, please ensure that your Git username has been set to your full name.
    remote: Please see https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup for more details on ensuring Git has been fully configured.
    remote: In the event that your full name has been set and is shown above as being rejected, please file a Sysadmin ticket at https://go.kde.org/systickets
  • I talked about this commit creating issues in the KDE developement chat:

    Felix Ernst
    There is a commit (link) from someone using a blocked eMail domain in Dolphin master. This is quite problematic because contributors can't even rebase their MRs to current because of this. Should I contact SysAdmin about this or can this be fixed by anyone with a dev account?

    Nate Graham
    I filed a sysadmin ticket about it and so far what I heard back was "use work branches", which does indeed work as a workaround
    dunno how it can be fixed for personal fork users

    tsdgeos@tsdgeos:kde.org
    they can use work branches in their personal fork too
    ?

    Nate Graham
    oh maybe

    Felix Ernst
    Are they working on fixing it? Will it work as normal again eventually? Our get involved/developement tutorial doesn't work anymore currently.

    Nate Graham
    ouch, that's bad. Not sure about the current status

  • New forks of the repository will be unaffected by this issue.

    It is only existing forks that are now broken and require a hook exception to allow them to be rebased as the fork lacks the tainted commits.

  • So how does that happen? Is it something you need to do?

  • It is already done, all opened MR where rebased by Ben. Those concerned will need to checkout their distant branch.

    Basically you need to start from a branch where fde79c09 is already part of the server known git history for your branch.

  • Tom Lin @tomlin

    mentioned in merge request !278 (merged)

    ·

    mentioned in merge request !278 (merged)

    Toggle commit list
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment