1. 12 Nov, 2020 2 commits
  2. 10 Nov, 2020 1 commit
  3. 09 Nov, 2020 10 commits
    • Felix Ernst's avatar
      Adress the third round of Angelaccio's review comments · 63f4981f
      Felix Ernst authored
      Additionally remove some redundant code concerning UrlNavigator visuals.
      63f4981f
    • Felix Ernst's avatar
      Adress most of the second round of Angelaccio's review comments · 2d4d2ce9
      Felix Ernst authored
      This commit applies most suggestions which were made on the MR.
      Most notably the DolphinUrlNavigator class is split up which leads to
      the creation of a DolphinUrlNavigatorsController class.
      
      Additionally some minor coding style and const correctness changes are
      included.
      
      The error value of cached integers is changed from -1 to INT_MIN
      because situations could come up in which -1 would be a valid value.
      2d4d2ce9
    • Felix Ernst's avatar
      Apply Méven Car's suggestions · 42023831
      Felix Ernst authored
      42023831
    • Felix Ernst's avatar
      Fix a crash and extract unrelated changes · a418d622
      Felix Ernst authored
      The secondary UrlNavigator is now created when and only when:
      - split view mode is activated for the active tab
      OR
      - switching to a tab that has split view already enabled.
      This fixes a crash that occurs when the setting to always start in
      split view mode is enabled.
      
      An animation for activating split view is also removed from this and
      moved into a separate MR. Another unrelated name change left over from
      a previous commit (viewContainers() -> activeViewContainers()) is
      dropped.
      a418d622
    • Felix Ernst's avatar
      Make UrlNavigators in the toolbar the only option · 37327c9b
      Felix Ernst authored
      The UrlNavigators will be automatically added to the toolbar. The Sort By
      action is removed from the default toolbar to make space.
      
      Remove all options to have UrlNavigators outside the toolbar and remove
      those code paths.
      
      Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
      in split view mode. Spacing was also added to align these UrlNavigators
      with the ViewContainers when enough space is available.
      
      Force the toolbar to be either at the top or bottom of the window.
      
      Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
      in KUrlNavigator in the future.
      
      This commit also contains a changes which should be moved to a separate
      merge requests before this gets merged:
      - Add an expansion animation when split view is enabled by the user
      37327c9b
    • Felix Ernst's avatar
      Add the UrlNavigator to the toolbar automatically if needed · 6151a7ae
      Felix Ernst authored
      This commit adds the DolphinUrlNavigatorWidgetAction::addToToolbarAndSave()
      method which changes the users toolbar configuration to contain an
      Url Navigator. This way the user doesn't need to do anything manually.
      
      Aside from that a bunch of minor fixes like renaming and reordering
      6151a7ae
    • Felix Ernst's avatar
      Adress the first round of Angelaccio's review comments · b6fc58c3
      Felix Ernst authored
      - Split the viewContainers(bool includeInActive) into two methods
          without parameters
      - Prevent users from accidently hiding all Url Navigators by
          preventing the dangerous action and then displaying a helpful
          message instead
      Unrelated to review comments: Remove a useless line of code
      b6fc58c3
    • Felix Ernst's avatar
      trailing whitespaces · 00abc6d2
      Felix Ernst authored
      00abc6d2
    • Felix Ernst's avatar
      Add an option to use an UrlNavigator in the toolbar instead · ad5d3367
      Felix Ernst authored
      This commit adds a locationInToolbar KToggleAction to switch between
      using a location bar to navigate or using a new custom QWidgetAction
      in the toolbar.
      
      A big portion of this MR is refactoring because until now the
      UrlNavigator was tightly intertwined with the DolphinViewContainer.
      With this MR an UrlNavigator for controlling a View can be freely
      connected or disconnected with a single method call.
      
      A DolphinUrlNavigator class is created in the process which contains all
      Dolphin-specific UrlNavigator code which did previously reside in the
      DolphinViewContainer class. Other application parts that belong to
      UrlNavigator-management are also moved here.
      ad5d3367
    • Méven Car's avatar
  4. 08 Nov, 2020 3 commits
  5. 07 Nov, 2020 2 commits
  6. 05 Nov, 2020 2 commits
    • Elvis Angelaccio's avatar
      Add support for KUserFeedback · 465e0613
      Elvis Angelaccio authored
      This commit introduces KUserFeedback in dolphin with some basic data
      sources and with a settings page to configure the telemetry values.
      
      There are also a couple custom data sources as proof of concept: a bunch
      of settings and the count of available network shares as listed by Solid.
      
      The settings page is shown only if the user feedback framework is
      enabled, but currently in Plasma we don't have a global kill switch to
      disable it.
      
      At the moment we never show an encouragement message. We need to connect
      to the `Provider::showEncouragementMessage()` signal, but first we
      should agree to a common way to show a non-annoying message to the users.
      465e0613
    • Méven Car's avatar
      Details view: display empty text instead of unknown for sizeless dirs · 61bf84c1
      Méven Car authored
      BUG: 420037
      BUG: 420040
      FIXED-IN: 20.12
      61bf84c1
  7. 04 Nov, 2020 13 commits
  8. 03 Nov, 2020 4 commits
  9. 02 Nov, 2020 1 commit
  10. 01 Nov, 2020 2 commits