1. 12 Nov, 2020 1 commit
    • Alexander Lohnau's avatar
      Fix qrc icon · 1208f866
      Alexander Lohnau authored
      Apparently the icon was not null, because the mimetype was known.
      But there was no icon associated with it and we got an
      icon which is not null, but has a null pixmap.
      1208f866
  2. 04 Nov, 2020 1 commit
  3. 01 Nov, 2020 2 commits
  4. 23 Oct, 2020 2 commits
  5. 14 Oct, 2020 1 commit
    • Elvis Angelaccio's avatar
      Port away from QList::toSet() · 3bf2922e
      Elvis Angelaccio authored
      The QSet range constructor requires Qt 5.14.
      
      In `DolphinView::slotHeaderContextMenuRequested()` the conversion from
      QList to QSet was pointless, so we just use a QList now.
      3bf2922e
  6. 30 Aug, 2020 1 commit
  7. 25 Aug, 2020 1 commit
  8. 12 Jul, 2020 2 commits
  9. 23 Jun, 2020 1 commit
  10. 29 May, 2020 1 commit
    • Elvis Angelaccio's avatar
      Port away from deprecated QFontMetrics::width() · b65576a1
      Elvis Angelaccio authored
      While the documention says to port to QFontMetrics::horizontalAdvance(),
      what we actually need is not the horizontal advance, but the width of
      the text. So we need to port to QFontMetrics::boundingRect().width().
      
      Quoting from https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/:
      
      "Since it was not clear from the confusingly named function QFontMetrics::width()
      that it actually returned the horizontal advance, instead of the bounding width,
      this method is now obsolete.
      You must port to either QFontMetrics::horizontalAdvance() or QFontMetrics::boundingRect().width().
      
      Please make sure you are aware of the difference, and do not port
      blindly. I am pretty sure that in most cases
      QFontMetrics::boundingRect() is what you want, unless you are writing
      custom text shaping/layouting code. Using the wrong function can cause
      clipped text or text that suddenly wraps to the next line despite
      calculating the width that it needs."
      b65576a1
  11. 28 May, 2020 2 commits
  12. 18 May, 2020 1 commit
  13. 09 Nov, 2019 1 commit
  14. 16 Sep, 2019 1 commit
  15. 08 Sep, 2019 1 commit
  16. 24 Aug, 2019 1 commit
    • Nate Graham's avatar
      Middle-elide file/folder labels so the extension is always visible · 97f49347
      Nate Graham authored
      Summary:
      This ensures that the filename extension is always visible, and also is just a
      nicer way to elide file and folder names in general.
      
      BUG: 404955
      FIXED-IN: 19.12.0
      
      Test Plan:
      Details view: {F6648784}
      Icons view with limited label height: {F6648785}
      
      Reviewers: #dolphin, #vdg, elvisangelaccio, GB_2
      
      Reviewed By: #dolphin, #vdg, elvisangelaccio, GB_2
      
      Subscribers: GB_2, ndavis, rooty, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19471
      97f49347
  17. 12 May, 2019 1 commit
  18. 24 Oct, 2018 1 commit
  19. 10 Sep, 2018 1 commit
  20. 05 Sep, 2018 1 commit
  21. 04 Sep, 2018 1 commit
    • Kai Uwe Broulik's avatar
      Don't use QIcon::Selected state for selected icon · b734386c
      Kai Uwe Broulik authored
      This causes selected monochrome Breeze icons to turn white as this state is meant for when the icon is actually painted ontop of
      e.g. a blue highlighted area in a menu
      Since the advanced icon configuration (where you could choose a custom hint color and other effects) has been removed in Plasma 5.13
      and more importantly the fact that Dolphin always tints the icon in the highlight color disregarding any custom icon effects settings
      this is an acceptable change.
      
      CHANGELOG: Fixed monochrome icons turning invisible when selected
      
      BUG: 398014
      FIXED-IN: 18.08.2
      
      Differential Revision: https://phabricator.kde.org/D15255
      b734386c
  22. 11 Jul, 2018 1 commit
  23. 29 Mar, 2018 2 commits
    • Scott Harvey's avatar
      Fix alignment of icons in Places panel and Compact view mode · e0f7fe87
      Scott Harvey authored
      Summary:
      Adjust calculation of icon pixmap Y value; now based off center of text label bounding rectangle. Previously, icons appeared top-aligned when text size was larger than icon size.
      
      Centering is done by obtaining the center point of the text frame (`m_textRect.center().y()`) and setting the top `Y` point of the icon to one-half of the scaled icon height (`m_scaled_PixmapSize.height()`)  Division is done by `2.0`, to ensure calculations are done with floating-point math, in keeping with `QPointF`, which returns floating-point values.
      
      Also includes an adjustment named `midlineShift` (contributed by @zzag), which takes into account the font's midline in respect to the center of the text frame. Certain fonts (i.e. Noto Sans) can have a slightly offset midline, resulting in imperfect alignment of the icon. This small adjustment resolves that potential issue.
      
      See before and after screenshots.
      {F5764918}
      Before, showing misalignment (with and without debugging wireframes)
      
      {F5764920}
      After, showing correction
      
      BUG: 390771
      
      Test Plan:
      -- Compile Dolphin with patch
      -- Increase system font size by several points (i.e. 15pt)
      -- Check that Places panel icons remain centered with the text label
      -- Select Compact View mode
      -- Adjust icon size slider to minimum
      -- Ensure that icons also remain centered in file listing
      -- Check several combinations of icon size & font size to ensure centering is consistent
      
      Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: zzag, elvisangelaccio, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D11650
      e0f7fe87
    • Elvis Angelaccio's avatar
      Fix enum-compare-switch clang warnings · 8d1cc850
      Elvis Angelaccio authored
      We were comparing a value of type `KStandardItemListView::ItemLayout`
      with values of type `KStandardItemListWidget::Layout`.
      8d1cc850
  24. 04 Mar, 2018 1 commit
  25. 03 Mar, 2018 1 commit
  26. 05 Feb, 2018 1 commit
  27. 11 Jan, 2018 1 commit
  28. 21 Nov, 2017 1 commit
  29. 19 Nov, 2017 2 commits
    • Andreas Krutzler's avatar
      Fix scrolling during inline renaming causes rename of wrong file · af27d573
      Andreas Krutzler authored
      Summary:
      Scrolling during inline renaming accepts the renaming now, like if one would hit Return for example. I chose this approach because it seems the easiest way to fix this.
      This also fixes the “possible” Ui glitch where the renaming KTextField doesn’t move along with the list item. Possible glitch, because I don’t know if this is intentional, but for me it looks broken.
      
      BUG: 378786
      Fixes T7443
      
      Test Plan:
      * Enable "Rename inline" in dolphin settings
      * Go to a folder where you have to scroll through items (many files, big zoom,…)
      * Start to rename a file (context menu, F2, …)
      * Scroll with mouse wheel
      * Rename  accepted -> file is renamed
      
      Reviewers: ngraham, rkflx, #dolphin, elvisangelaccio
      
      Reviewed By: ngraham, rkflx, #dolphin, elvisangelaccio
      
      Subscribers: anthonyfieroni, elvisangelaccio, #dolphin
      
      Maniphest Tasks: T7443
      
      Differential Revision: https://phabricator.kde.org/D8822
      af27d573
    • Andreas Krutzler's avatar
      Fix scrolling during inline renaming causes rename of wrong file · 5bee1889
      Andreas Krutzler authored
      Summary:
      Scrolling during inline renaming accepts the renaming now, like if one would hit Return for example. I chose this approach because it seems the easiest way to fix this.
      This also fixes the “possible” Ui glitch where the renaming KTextField doesn’t move along with the list item. Possible glitch, because I don’t know if this is intentional, but for me it looks broken.
      
      BUG: 378786
      Fixes T7443
      
      Test Plan:
      * Enable "Rename inline" in dolphin settings
      * Go to a folder where you have to scroll through items (many files, big zoom,…)
      * Start to rename a file (context menu, F2, …)
      * Scroll with mouse wheel
      * Rename  accepted -> file is renamed
      
      Reviewers: ngraham, rkflx, #dolphin, elvisangelaccio
      
      Reviewed By: ngraham, rkflx, #dolphin, elvisangelaccio
      
      Subscribers: anthonyfieroni, elvisangelaccio, #dolphin
      
      Maniphest Tasks: T7443
      
      Differential Revision: https://phabricator.kde.org/D8822
      5bee1889
  30. 06 Feb, 2017 1 commit
  31. 13 May, 2016 1 commit
    • Marco Martin's avatar
      use selected icon state for selected sidebar item · 4453d62f
      Marco Martin authored
      Since now the breeze icons can be recolored by kiconloader
      with svg stylesheets, use this feature to recolor the
      currently selected icon in the sidebar and in the
      details view (not the icon view)
      look wouldn't change if used with icon themes that
      don't support this feature
      This makes it look more in line with the breeze style
      
      REVIEW:127877
      4453d62f
  32. 26 Apr, 2016 1 commit
    • Wolfgang Bauer's avatar
      Specify a fallback icon to QIcon::fromTheme() · 44d4d2ea
      Wolfgang Bauer authored
      The default fallback of QIcon::fromTheme() is QIcon(), i.e. a null icon.
      Set the generic "unknown" icon as fallback to prevent missing icons for
      filetypes that specify an icon name that doesn't exist.
      
      This also gets rid of "QPixmap::scaled: Pixmap is a null pixmap"
      warnings in that case.
      
      BUG: 358958
      BUG: 361034
      FIXED-IN: 16.04.1
      REVIEW: 127713
      44d4d2ea
  33. 16 Mar, 2016 1 commit
  34. 27 Mar, 2015 1 commit