1. 27 Jan, 2020 1 commit
    • George Vogiatzis's avatar
      Change drop indicator color · 178eb592
      George Vogiatzis authored and Nate Graham's avatar Nate Graham committed
      Change drop indicator color form highlight to text.
      This makes more visible, when indicator is adjacent to a highlight
      item, of a list.
      BUG: 415010
      Test Plan:
      Before vs After
      Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham
      Reviewed By: #dolphin, #vdg, ngraham
      Subscribers: meven, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D26936
  2. 13 Jan, 2020 1 commit
  3. 11 Jan, 2020 1 commit
    • Piotr Henryk Dabrowski's avatar
      Hide tooltip instantly on filter change · f729f6f5
      Piotr Henryk Dabrowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Instantly hide tooltip shown over an element when filter bar changes.
      Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely.
      The tooltip also continues to cover much of the window - hiding the new filtering results from user.
      This is an enhancement to D22512
      Test Plan:
      1. place the mouse pointer over a file to show the tooltip
      2. press "/" to activate filter bar
      3. type in filter phrase
      Reviewers: #dolphin, elvisangelaccio, ngraham
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D26576
  4. 06 Jan, 2020 1 commit
  5. 05 Jan, 2020 1 commit
  6. 21 Dec, 2019 1 commit
    • Nate Graham's avatar
      Improve scroll wheel speed by basing it on label height, not icon height · 403de19d
      Nate Graham authored
      Dolphin currently scrolls by the height of three items at a time per "step" when
      using a scroll wheel. Because item height is highly variable, this leads to scroll
      speed being inconsistent between views, and generally far too fast when using
      icon view with icons larger than 22px size.
      This patch makes the size of the scroll step based on the text label rather than the
      icon size just like D25683, ensuring that the scroll speed does not vary and become
      super fast when using large icons in particular.
      It also reverts 90beb4a5, which is no longer needed.
      BUG: 386379
      FIXED-IN: 19.12.1
      Test Plan:
      Use a mouse with a scroll wheel and scroll in Dolphin item views with list view,
      details view, icon view, etc, using different item sizes. Speed should be
      consistent in all views now, and also feel consistent with other KDE apps.
      Also try with multiple scale factors to make sure the behavior does not change.
      No change with high-resolution two-finger touchpad scrolling.
      Reviewers: #dolphin, elvisangelaccio
      Reviewed By: #dolphin, elvisangelaccio
      Subscribers: ahiemstra, lots0logs, anthonyfieroni, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D19190
  7. 09 Dec, 2019 2 commits
  8. 06 Dec, 2019 1 commit
  9. 05 Dec, 2019 2 commits
  10. 28 Nov, 2019 2 commits
    • Ismael Asensio's avatar
      fix(search): Fix baloo searchString parsing · 6776fbc9
      Ismael Asensio authored
      Fix the parsing of Baloo query `searchString` to represent its parameters properly
      in the search box:
      # Baloo terms (`rating`, `modified`) are added to the user search text: {F7575590}
      # Extra quotes are added to the search text: https://bugs.kde.org/show_bug.cgi?id=412952
      This revision supersedes D24422, by making the fixes on the new dolphin query model,
      instead of directly on the UI.
      BUG: 412952
      FIXED IN: 19.11.90
      Test Plan:
        - `bin/dolphinquerytest` passes without `XFAIL`s
        - Dolphin search box is not garbled by search terms or quotes
      Reviewers: elvisangelaccio, bruns, ngraham, #dolphin
      Reviewed By: elvisangelaccio
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25260
    • Elvis Angelaccio's avatar
      Force dbus introspection on the Dolphin_1 object · 089a05b4
      Elvis Angelaccio authored
      QtDBus caches known interfaces when passing a non-empty interface name
      to the QDbusInterface constructor. This is an issue when calling the
      FileManager1 methods more than once, because `preferred` could be a
      valid interface from the cache, but it would later fail to call the
      `openFiles`/`openDirectories` methods on the main window.
      By passing an empty interface name, we prevent QtDBus from using the
      cache so that we always get an invalid interface when calling the
      FileManager1 methods on a daemonized dolphin process (that doesn't have
      the Dolphin_1 dbus object).
      BUG: 414402
      FIXED-IN: 19.12.0
      Test Plan:
      1. dolphin --daemon
      2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
      3. Close the dolphin window that was just opened.
      4. Start a normal dolphin process
      5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
      6. Close again the dolphin window
      7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25510
  11. 26 Nov, 2019 1 commit
  12. 24 Nov, 2019 1 commit
  13. 23 Nov, 2019 1 commit
  14. 17 Nov, 2019 1 commit
  15. 14 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      test(search): Add test case for baloo parsing model · 0ba9e8bb
      Ismael Asensio authored
      Adds a new test unit for the model which parses baloo search URLs
      14/19 tests are set to `XFAIL` on current implementation, as they will be fixed in a final revision.
      Supersedes D25135.
      Depends on: D25257
      Test Plan: `bin/dolphinquerytest`
      Reviewers: elvisangelaccio, bruns, #dolphin
      Reviewed By: elvisangelaccio, bruns, #dolphin
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25258
  16. 13 Nov, 2019 3 commits
    • Ismael Asensio's avatar
      fix(search): Allow to set empty type · adfc098a
      Ismael Asensio authored
      This small patch allows to set and empty `type` to the extended options, which will set the `Any Type` option (index 0).
      It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches.
      Test Plan:
      No behavior changes with current code.
      Calling `setFacetsType(QString())` actually sets the first option (`Any Type`)
      Reviewers: elvisangelaccio, #dolphin
      Reviewed By: elvisangelaccio, #dolphin
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25255
    • Elvis Angelaccio's avatar
      DolphinQuery: drop DOLPHIN_EXPORT · fc5546d0
      Elvis Angelaccio authored
      DOLPHIN_EXPORT is only used by classes in the `dolphinprivate` target,
      while DolphinQuery is part of `dolphinstatic`.
      This should fix the failing Windows build on the CI.
    • Ismael Asensio's avatar
      refactor(search): De-couple baloo URL parsing logic from UI · 8d92c8be
      Ismael Asensio authored
      Extracts the logic that parses `baloosearch:` urls into a new model class. The parser logic itself is kept as is.
      The search box UI is later updated using the model fields.
      This refactor has been proposed by @bruns in the review of D24422, as it largely simplifies the unit tests and further expansion/improvements.
      Test Plan:
      No behavior changes.
      Test case is added in the follow-up revision: D25258
      Reviewers: #dolphin, elvisangelaccio, bruns
      Reviewed By: #dolphin, elvisangelaccio, bruns
      Subscribers: ngraham, bruns, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25257
  17. 11 Nov, 2019 1 commit
  18. 10 Nov, 2019 3 commits
  19. 09 Nov, 2019 5 commits
  20. 07 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      Make the search box more compact · 7949aee2
      Ismael Asensio authored
      Reduce the spacing between widgets and remove the content margins on the extended search options to have a more compact and space-saving layout.
      Currently, some widgets are not even aligned.
      This will be even more important if we remove the toggle button for 'More Options'.
      CCBUG: 386754
      Test Plan:
      BEFORE: {F7681182}
      AFTER: {F7681184}
      Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
      Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25028
  21. 03 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      Get rid of search "More Options" toggle button · 54bd267e
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages).
      These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled.
      For some nicer aesthetics D25029 should be also applied.
      CCBUG: 386754
      Test Plan:
      Current: {F7681182}
      After: {F7687380}
      Along with D25029: {F7687385}
      Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
      Reviewed By: ngraham, #vdg
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25057
  22. 30 Oct, 2019 1 commit
  23. 29 Oct, 2019 1 commit
  24. 28 Oct, 2019 3 commits
  25. 27 Oct, 2019 2 commits
    • Ismael Asensio's avatar
      New design for extended search options · 1c50de3b
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Replace the arrays of radiobuttons in dolphin search box to more simple dropdown boxes.
      This provides a leaner look, saving a lot user space on the main view and it is more consistent with the 'Search tools' in the most known sites (Google, DuckDuckGo, etc.)
      There is room for improvement, as `QComboBox` doesn't match perfectly with the tool buttons used avobe, but I think it is an improvement over the current situation.
      Test Plan: Same behavior with different aesthetics
      Reviewers: elvisangelaccio, #dolphin, #vdg
      Subscribers: ndavis, ngraham, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D24602
    • David Hallas's avatar
      Unmounting busy device doesn't tell who is blocking · c3b914a7
      David Hallas authored
      Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount.
      Test Plan:
      Mount a USB stick using Dolphin
      Open a file from the USB stick
      Unmount the USB stick using Dolphin
      Observe the new error message.
      FEATURE: 189302
      Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven
      Reviewed By: #dolphin, elvisangelaccio, meven
      Subscribers: meven, davidedmundson, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D19989
  26. 26 Oct, 2019 1 commit
    • Méven Car's avatar
      When the selection is deselected, restart the keyboard search from the beginning · a5ce798f
      Méven Car authored
      BUG: 411538
      FIXED-IN: 19.12
      Test Plan:
      Open a directory with 3 files starting with the same letter.
      1. Press this letter key twice
      2. The second file is selected
      3. Deselect the file with the mouse or using Esc
      4. Wait 1 second
      5. Press the same key again
      The third file gets selected
      The first file get selected
      Reviewers: #dolphin, elvisangelaccio, ngraham
      Reviewed By: #dolphin, elvisangelaccio, ngraham
      Subscribers: ngraham, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D23716