1. 20 Jan, 2020 1 commit
  2. 19 Jan, 2020 1 commit
    • Ismael Asensio's avatar
      (search) Fix searching tags with spaces · 5778099e
      Ismael Asensio authored
      Summary:
      Tags containing blank spaces were not handled properly in the search widget.
      Now we enclose them in quotes and strip the quotes before setting them to the widget.
      
      {F7854247}
      
      Test Plan:
      No artifacts when searching tags containing spaces
      Added test cases to `bin/dolphinquerytest`
      
      Reviewers: #dolphin, elvisangelaccio, ngraham, meven
      
      Reviewed By: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26369
      5778099e
  3. 13 Jan, 2020 2 commits
    • Nate Graham's avatar
      Use more conventional "Add to Places" text for that action · 897ce848
      Nate Graham authored
      Summary:
      I originally implemented this to show "Add <current folder> to Places" to make the menu
      item more clear when invoked from the file menu or the viewport context menu because I
      thought it wasn't totally clear that the action would be referring to the folder for the
      visible view.
      
      However I think in retrospect that this was a mistake. No other items in the file menu
      or the viewport context menu name the current folder like this, so clearly there wasn't
      a problem. And then the item's text doesn't match the text for other items.
      
      Thie patch removes that behavior and makes the name match the style of all the other menu
      item text.
      
      BUG: 416064
      FIXED-IN: 20.04.0
      
      Reviewers: #dolphin, #vdg, meven
      
      Reviewed By: #dolphin, meven
      
      Subscribers: elvisangelaccio, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26590
      897ce848
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 2fd2f621
      Script Kiddy authored
      2fd2f621
  4. 12 Jan, 2020 1 commit
    • Ismael Asensio's avatar
      Get rid of -Wdeprecated-copy warning · a8dd6998
      Ismael Asensio authored
      Summary:
      Remove the explicit copy constructor of `KItemListStyleOption`, since it does not
      add any logic to what the implicit copy constructor does, but triggers a compiler
      warning if we don't overload `operator=` too.
      
      Test Plan:
      Compiles without `-Wdeprecated-copy` warning
      No behavior changes
      
      Reviewers: elvisangelaccio, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26585
      a8dd6998
  5. 11 Jan, 2020 4 commits
    • Robert Hoffmann's avatar
      Add only canonical paths to dirWatcher · 17e127ed
      Robert Hoffmann authored
      Summary: KDirWatch only works correctly with canonical paths, i.e. symbolic links resolved.
      
      Test Plan:
      1. Create dirs:
      $ mkdir test1
      $ mkdir test1/subdir
      $ ln -s test1 test2
      
      2. Start dolphin, navigate to test2/subdir, then in terminal:
      $ echo test > test2/subdir/test
      
      Without the patch, test2/subdir/test won't be shown automatically, only after reload (F5).
      With the patch applied, test2/subdir/test will be shown automatically.
      
      3. Restart dolphin, navigate to test2/subdir, then in terminal:
      $ echo test >> test2/subdir/test
      
      Without the patch, the increased size of test2/subdir/test won't be shown automatically,
      only after reload (F5). With the patch applied, it will be shown automatically.
      
      4. Restart dolphin, navigate to test2/subdir, then in terminal:
      $ rm test2/subdir/test
      
      Without the patch, test2/subdir/test stays visible, will only disappear after reload (F5).
      With the patch applied, it will disappear automatically.
      
      Reviewers: dfaure, #dolphin, elvisangelaccio
      
      Reviewed By: dfaure, #dolphin, elvisangelaccio
      
      Subscribers: ngraham, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25732
      17e127ed
    • Nate Graham's avatar
      "Use newly-upstreamed rename dialog from KIO"" · 09e215be
      Nate Graham authored
      This reverts commit 41105103.
      
      KIO's version was just bumped to 5.67, so this can land now without
      breaking the CI.
      09e215be
    • Elvis Angelaccio's avatar
      Merge branch 'release/19.12' · 10d65563
      Elvis Angelaccio authored
      10d65563
    • Piotr Henryk Dabrowski's avatar
      Hide tooltip instantly on filter change · f729f6f5
      Piotr Henryk Dabrowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Instantly hide tooltip shown over an element when filter bar changes.
      
      Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely.
      The tooltip also continues to cover much of the window - hiding the new filtering results from user.
      
      This is an enhancement to D22512
      
      Test Plan:
      1. place the mouse pointer over a file to show the tooltip
      2. press "/" to activate filter bar
      3. type in filter phrase
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26576
      f729f6f5
  6. 06 Jan, 2020 5 commits
  7. 05 Jan, 2020 1 commit
  8. 29 Dec, 2019 1 commit
    • Ismael Asensio's avatar
      Clean-up DolphinFacetsWidget · c331d706
      Ismael Asensio authored
      Summary:
      Small refactor patch to clean-up some logic on setter and getter:
      - Search terms are previously splitted and set separately, so no need
        for extra splitting and `foreach` loop
      - Return search terms on a `QStringList` rather than join first
      
      Depends on: D26029
      
      Test Plan: No behavior changes
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26150
      c331d706
  9. 26 Dec, 2019 3 commits
  10. 24 Dec, 2019 2 commits
  11. 23 Dec, 2019 1 commit
  12. 21 Dec, 2019 4 commits
    • Piotr Henryk Dabrowski's avatar
      Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal() · 6cb4d81a
      Piotr Henryk Dabrowski authored and Nate Graham's avatar Nate Graham committed
      Reviewers: ngraham, elvisangelaccio, #dolphin
      
      Reviewed By: ngraham, elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26140
      6cb4d81a
    • Nate Graham's avatar
      Merge branch 'release/19.12' · 08049836
      Nate Graham authored
      08049836
    • Nate Graham's avatar
      Improve scroll wheel speed by basing it on label height, not icon height · 403de19d
      Nate Graham authored
      Summary:
      Dolphin currently scrolls by the height of three items at a time per "step" when
      using a scroll wheel. Because item height is highly variable, this leads to scroll
      speed being inconsistent between views, and generally far too fast when using
      icon view with icons larger than 22px size.
      
      This patch makes the size of the scroll step based on the text label rather than the
      icon size just like D25683, ensuring that the scroll speed does not vary and become
      super fast when using large icons in particular.
      
      It also reverts 90beb4a5, which is no longer needed.
      
      BUG: 386379
      FIXED-IN: 19.12.1
      
      Test Plan:
      Use a mouse with a scroll wheel and scroll in Dolphin item views with list view,
      details view, icon view, etc, using different item sizes. Speed should be
      consistent in all views now, and also feel consistent with other KDE apps.
      
      Also try with multiple scale factors to make sure the behavior does not change.
      
      No change with high-resolution two-finger touchpad scrolling.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: ahiemstra, lots0logs, anthonyfieroni, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19190
      403de19d
    • Ismael Asensio's avatar
      fix(search): Correctly parse filename and/or content search · 616d4e6b
      Ismael Asensio authored
      Summary:
      Currently, the search url parsing does not detect if the search is based on Content or Filename, and it just keeps the last selection which can be inconsistent with the actual search.
      
      This patch add such detection, and since an advanced user can combine filename and content search (using the keyword `filename:`), now the parsing detects both items and handles the four possible cases:
      
      | Content | Filename | Search text | Search type |
      |---|---|------------------------|------------------|
      | T | T | abc filename:"xyz"  | Content          |
      | T | F | abc                           | Content          |
      | F | T | xyz                           | Filename         |
      | F | F |                                  | do not set       |
      
      Depends on: D25260
      
      Test Plan: `bin/dolphinquerytest`: Added new test cases for searches with content text and/or filename
      
      Reviewers: elvisangelaccio, bruns, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25416
      616d4e6b
  13. 20 Dec, 2019 1 commit
  14. 19 Dec, 2019 1 commit
  15. 16 Dec, 2019 2 commits
  16. 15 Dec, 2019 2 commits
    • Ismael Asensio's avatar
      [dolphin/search] Search by (multiple) tags · 8e80c1d6
      Ismael Asensio authored
      Summary:
      Adds a tag selector in the extended filters of the search box.
      Selected tag or tags are added to the search query along with the other filters (type, date, rating).
      
      FEATURE: 412564
      CCBUG: 356062
      
      Test Plan:
      - Menu shows the user tags
      - Picking any tag/s filters the search to that specific tag/s
      
      {F7727909}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T9094
      
      Differential Revision: https://phabricator.kde.org/D25130
      8e80c1d6
    • Nate Graham's avatar
      Don't overload the word "Properties" to mean multiple things · f6229562
      Nate Graham authored
      Summary:
      Generally "Properties" refers to information about a selected file. However Dolphin also
      uses the word "Properties" in the phrase "View Properties", which refers to the display
      style of the view. Since "properties" is a fairly esoteric and technical term to most
      users, it would probably be wise to avoid using it in multiple contexts.
      
      Accordingly, this patch changes "view properties" to "view display style".
      
      Test Plan: Look at the settings window, hamburger menu, view menu, and docbook
      
      Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio
      
      Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio
      
      Subscribers: ndavis, kfm-devel, kde-doc-english
      
      Tags: #dolphin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D25987
      f6229562
  17. 10 Dec, 2019 1 commit
  18. 09 Dec, 2019 3 commits
  19. 06 Dec, 2019 3 commits
  20. 05 Dec, 2019 1 commit
    • Nate Graham's avatar
      Add action for focusing Terminal Panel · 69838a1c
      Nate Graham authored
      Summary:
      Add an action for focusing and de-focusing the Terminal Panel.
      
      FEATURE: 185096
      FIXED-IN 20.04.0
      
      Test Plan:
      - Hit {key Ctrl Shift F4} or click {nav Tools > Focus Terminal Panel} or {nav Control > Tools > Focus Terminal Panel}
      - If the Terminal Panel was closed, it opens and gains focus
      - If the Terminal Panel was open but unfocused, it gains focus
      - If the Terminal Panel was open and focused, focus returns to the view
      
      {F6630289, size=full}
      
      Reviewers: #dolphin, elvisangelaccio, rominf
      
      Reviewed By: #dolphin, elvisangelaccio, rominf
      
      Subscribers: kfm-devel, elvisangelaccio, rkflx, ngraham, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D10959
      69838a1c