1. 14 Oct, 2020 2 commits
  2. 25 Aug, 2020 1 commit
  3. 05 May, 2020 1 commit
  4. 04 May, 2020 1 commit
    • Méven Car's avatar
      [Details mode] Allow to fill the column size of directories with actual size · e6ea3ab4
      Méven Car authored
      Summary:
      Allow to compute the recursive size of directories to fill the details view size column.
      A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting.
      
      When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered.
      
      KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated.
      KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin.
      
      FIXED-IN: 20.08
      BUG: 190580
      BUG: 158090
      
      Test Plan:
      With some recursion allowed:
      {F8267580}
      
      Without any recursion allowed (default):
      {F8267581}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin
      
      Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25335
      e6ea3ab4
  5. 12 Apr, 2020 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Fix crashing on starting and quitting · 35b4c6d4
      Martin Tobias Holmedahl Sandsmark authored
      QCollator (especially with Qt 5.14 and ICU 65.1) is very unhappy with
      threads.
      
      To avoid having to lock and unlock the mutex everywhere (and ensure it
      is unlocked before calling other things that might lock it, etc.), we do
      it as locally as possible. Even if for some reason Qt and ICU make
      QCollator threadsafe in the future locking here should have minimal
      impact.
      
      BUG: 419585
      
      Differential Revision: https://phabricator.kde.org/D28659
      35b4c6d4
  6. 28 Jan, 2020 1 commit
    • George Vogiatzis's avatar
      Add natural sorting and case-insensitive sorting for all role-types · 9e3418bd
      George Vogiatzis authored and Nate Graham's avatar Nate Graham committed
      Summary:
       Add natural sorting and case-insensitive sorting, for all role-types
      that benefit from.
      
      BUG: 406296
      FIXED-IN: 19.12.2
      
      Test Plan:
      Sort by any role type specified in `isRoleValueNatural()`
      Before: Sorting is always case sensitive
      After: Sorting according to 'Sorting mode' in configuration.
      
      Reviewers: #dolphin, nicolasfella, meven, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, meven, elvisangelaccio, ngraham
      
      Subscribers: cfeck, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25741
      9e3418bd
  7. 06 Dec, 2019 1 commit
  8. 19 Nov, 2019 1 commit
  9. 09 Nov, 2019 1 commit
  10. 08 Sep, 2019 1 commit
  11. 01 Sep, 2019 1 commit
  12. 27 Aug, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Always periodically dispatch pending items · f4a1d1b0
      Kai Uwe Broulik authored
      "Local" URLs can also be slow.
      This might jeopardize loading large local directories where a resorting could take place but imho it's better than leaving the user
      wondering when files will finally show up. However, it takes some time for KDirLister to initially signal items having been added,
      and only then our 2 second timer starts.
      Also, stop the timer when loading has completed.
      
      Differential Revision: https://phabricator.kde.org/D23460
      f4a1d1b0
  13. 28 Jul, 2019 3 commits
  14. 12 May, 2019 1 commit
  15. 05 May, 2019 1 commit
  16. 30 Mar, 2019 1 commit
  17. 27 Mar, 2019 1 commit
  18. 10 Mar, 2019 1 commit
  19. 09 Mar, 2019 1 commit
    • Elvis Angelaccio's avatar
      Fix context for QDateTime::toString() translations · 1a325946
      Elvis Angelaccio authored
      Summary:
      The documentation of QDateTime::toString() says that:
      
          Any sequence of characters that are enclosed in single
          quotes will be treated as text and not be used as an expression.
      
      This means that translators cannot replace single quotes with other
      characters such as «...». This is now described in the context of the
      affected strings.
      
      We also check that the translated string contains exactly 2 single
      quotes, and we use the untraslated string otherwise.
      
      BUG: 401382
      
      Reviewers: lueck, aacid, cfeck
      
      Subscribers: ltoscano, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D18769
      1a325946
  20. 11 Jan, 2019 1 commit
  21. 01 Dec, 2018 1 commit
    • Thomas Surrel's avatar
      Do not sort twice when changing role and order at the same time · b714604a
      Thomas Surrel authored
      Summary:
      When using the list header to change the role and order, if one
      changes the order to descending and then changes role, dolphin
      also changes the order back to ascending. This results in sorting
      the list of files twice in a row. This patch removes the first
      (useless) sort.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17111
      b714604a
  22. 21 Nov, 2018 1 commit
  23. 10 Oct, 2018 2 commits
    • Thomas Surrel's avatar
      Update hidden state correctly · 200e0d1f
      Thomas Surrel authored
      Summary:
      When renaming a file from '.hidden' to 'not_hidden', the file
      would still be displayed like a hidden file with a semi-transparent
      icon and a grey text.
      
      BUG: 399599
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16115
      200e0d1f
    • Thomas Surrel's avatar
      Update hidden state correctly · 105fe62e
      Thomas Surrel authored
      Summary:
      When renaming a file from '.hidden' to 'not_hidden', the file
      would still be displayed like a hidden file with a semi-transparent
      icon and a grey text.
      
      BUG: 399599
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16115
      105fe62e
  24. 20 Aug, 2018 1 commit
  25. 26 Jul, 2018 1 commit
  26. 14 Jul, 2018 2 commits
    • Jaime Torres Amate's avatar
      Speedup sort · 23c5fce7
      Jaime Torres Amate authored
      Summary:
      Uses a reference to the collator instead of copying and reinitializing it again and again. This is the reason for the speedup.
      
      Changing the implementation from a Functor class to a Lambda removes some boilerplate code, but is not relevant for performance.
      
      This requires a workaround for https://bugreports.qt.io/browse/QTBUG-69361
      Just a single comparison to force the clean state of QCollator.
      
      Test Plan:
      Sorting in a directory with 82874 images:
      [TIME] Sorting: 19883  (before)
      [TIME] Sorting: 4198 (after)
      
      kfileitemmodelbenchmark before: ..............   Passed   29.36 sec
      kfileitemmodelbenchmark after:    ..............   Passed   20.39 sec
      
      Reviewers: #dolphin, #frameworks, markg, elvisangelaccio, bruns
      
      Reviewed By: #dolphin, markg, elvisangelaccio
      
      Subscribers: elvisangelaccio, apol, bruns, markg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D13814
      23c5fce7
    • Jaime Torres Amate's avatar
      Revert to change the commit message. · ec89af67
      Jaime Torres Amate authored
      Summary: This reverts commit 765cc968.
      
      Test Plan: revert-hammer
      
      Reviewers:
      
      Subscribers:
      ec89af67
  27. 13 Jul, 2018 1 commit
    • Jaime Torres Amate's avatar
      Speedup sort · 765cc968
      Jaime Torres Amate authored
      Summary:
      Use a lambda function to use only one QCollator initialized only once.
      
      This requires a workaround for https://bugreports.qt.io/browse/QTBUG-69361
      Just a single comparison to force the clean state of QCollator.
      
      Test Plan:
      Sorting in a directory with 82874 images:
      [TIME] Sorting: 19883  (before)
      [TIME] Sorting: 4198 (after)
      
      kfileitemmodelbenchmark before: ..............   Passed   29.36 sec
      kfileitemmodelbenchmark after:    ..............   Passed   20.39 sec
      
      Reviewers: #dolphin, #frameworks, markg, elvisangelaccio, bruns
      
      Reviewed By: #dolphin, markg, elvisangelaccio
      
      Subscribers: elvisangelaccio, apol, bruns, markg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D13814
      765cc968
  28. 07 Jul, 2018 1 commit
  29. 06 Jul, 2018 1 commit
    • Jaime Torres Amate's avatar
      Speedup sort · 63825de8
      Jaime Torres Amate authored
      Summary:
      Use a lambda function instead of a class.
      This way the member QCollator is not copied and initialized several times.
      
      Test Plan:
      Sorting in a directory with 82874 images:
      [TIME] Sorting: 19883  (before)
      [TIME] Sorting: 4198 (after)
      
      kfileitemmodelbenchmark before: ..............   Passed   29.36 sec
      kfileitemmodelbenchmark after:    ..............   Passed   20.39 sec
      
      Reviewers: #dolphin, #frameworks, markg, elvisangelaccio
      
      Reviewed By: #dolphin, markg, elvisangelaccio
      
      Subscribers: elvisangelaccio, apol, bruns, markg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D13814
      63825de8
  30. 04 Jul, 2018 1 commit
  31. 22 May, 2018 1 commit
  32. 01 Apr, 2018 1 commit
    • Julian Schraner's avatar
      Split Image Size into Width/Height · 1441fefc
      Julian Schraner authored and Nate Graham's avatar Nate Graham committed
      Summary:
      This patch splits the single property "Image Size" into "Width" and "Height", providing more fine-tuned control for power users.
      
      FEATURE: 374559
      
      Test Plan:
      - Sorting works correctly
      - No real change, only exposed differently
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: ngraham, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D11816
      1441fefc
  33. 10 Mar, 2018 1 commit
  34. 05 Mar, 2018 1 commit
  35. 04 Mar, 2018 1 commit