1. 12 Nov, 2020 1 commit
  2. 01 Nov, 2020 1 commit
  3. 25 Aug, 2020 1 commit
  4. 05 May, 2020 1 commit
  5. 03 May, 2020 1 commit
    • Alexander Lohnau's avatar
      Dolphin Service Menu Installer: Launch certain scripts in Konsole · d34559d1
      Alexander Lohnau authored
      Summary:
      In general the issue with installers/uninstallers for the dolphin plugin is
      that a lot of the scripts are intended to be run manually in a terminal.
      For instance if a script uses `sudo make install` the user can't type in the password.
      
      With this patch scripts that are executed without arg variants are
      executed in konsole (if available).
      
      Test Plan:
      Tests still pass. Try to install the "Jetbrains Dolphin Plugin" tar.gz file from the kde store.
      If you have the required dependencies etc. the konsole window should close.
      If the install script fails (type in wrong admin password a couple of times) you
      should have a shell opened.
      
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio, meven
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29089
      d34559d1
  6. 21 Apr, 2020 1 commit
    • Alexander Lohnau's avatar
      Dolphin Service Installer: Run uninstall scripts, rename methods · 5bbdf66f
      Alexander Lohnau authored
      Summary:
      Now scripts starting with `uninstall` are being executed.
      Addtionally the `runInstallerScriptOnce` method has been renamed, because it is used to run the install/uninstall scripts.
      Same for `runInstallerScript`.
      Depends on D28801
      
      Test Plan: Compile, run tests. Try to uninstall a dolphin service which has a uninstall.sh script.
      
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: cfeck, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28836
      5bbdf66f
  7. 17 Apr, 2020 1 commit
    • Alexander Lohnau's avatar
      Dolphin Service Menu installer cleanup · 76f9d9a5
      Alexander Lohnau authored
      Summary:
      This patch contains some smaller formatting/coding style changes
      to avoid unrelated changes in other patches.
      
      - Use {} instead of QStringList{} consistently
      - Use parehthesese in `UncompressCommand({})` consistently
      - Use `QStringList name = {}` instead of `auto name = QStringList{}`
      - Add one qAsConst, remove qAsConst if value is already const
      
      Test Plan: Compile, install and run tests
      
      Reviewers: #dolphin, ngraham, nicolasfella
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28801
      76f9d9a5
  8. 13 Apr, 2020 1 commit
    • Alexander Lohnau's avatar
      Dolphin Services: Launch Deb/Rpm archives with QDesktopServices · 514d9c8f
      Alexander Lohnau authored
      Summary:
      When you are inside the services store and you choose to install a deb/rpm package
      they open in the default application (mostlikely a package installer utility like discover).
      
      PS: I have written some ideas/questions, maybe you can comment on them :-) ?
      
      Test Plan:
      Tests still pass, try out what was described in the summary.
      A product which has a deb/rpm package is for example: `Jetbrains Dolphin Plugin`
      
      Reviewers: #dolphin, elvisangelaccio, ngraham, aspotashev
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28795
      514d9c8f
  9. 09 Nov, 2019 1 commit
  10. 28 Oct, 2019 1 commit
  11. 21 Jul, 2019 1 commit
  12. 16 Jul, 2019 1 commit
  13. 15 Jul, 2019 1 commit
  14. 14 Jul, 2019 1 commit