1. 15 Apr, 2020 1 commit
    • Antonio Prcela's avatar
      Do not display full path in the title of the tab · 26f8e688
      Antonio Prcela authored
      Summary:
      Displays the full path only in the window title, not in the tab title.
      
      Screenshot for comparison: ( Dolphin on the right is without D28815 , Dolphin on left has both D28815 and this patch)
      
      {F8240079}
      
      Reviewers: #vdg, #dolphin, ngraham, meven
      
      Reviewed By: #vdg, #dolphin, ngraham, meven
      
      Subscribers: ngraham, elvisangelaccio, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28857
      26f8e688
  2. 05 Apr, 2020 1 commit
  3. 16 Mar, 2020 1 commit
  4. 15 Mar, 2020 2 commits
    • Nate Graham's avatar
      Add Duplicate feature · 158d12ac
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      158d12ac
    • Nate Graham's avatar
      Add Duplicate feature · 405dd624
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      405dd624
  5. 13 Jan, 2020 1 commit
    • Nate Graham's avatar
      Use more conventional "Add to Places" text for that action · 897ce848
      Nate Graham authored
      Summary:
      I originally implemented this to show "Add <current folder> to Places" to make the menu
      item more clear when invoked from the file menu or the viewport context menu because I
      thought it wasn't totally clear that the action would be referring to the folder for the
      visible view.
      
      However I think in retrospect that this was a mistake. No other items in the file menu
      or the viewport context menu name the current folder like this, so clearly there wasn't
      a problem. And then the item's text doesn't match the text for other items.
      
      Thie patch removes that behavior and makes the name match the style of all the other menu
      item text.
      
      BUG: 416064
      FIXED-IN: 20.04.0
      
      Reviewers: #dolphin, #vdg, meven
      
      Reviewed By: #dolphin, meven
      
      Subscribers: elvisangelaccio, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26590
      897ce848
  6. 06 Dec, 2019 1 commit
  7. 05 Dec, 2019 1 commit
    • Nate Graham's avatar
      Add action for focusing Terminal Panel · 69838a1c
      Nate Graham authored
      Summary:
      Add an action for focusing and de-focusing the Terminal Panel.
      
      FEATURE: 185096
      FIXED-IN 20.04.0
      
      Test Plan:
      - Hit {key Ctrl Shift F4} or click {nav Tools > Focus Terminal Panel} or {nav Control > Tools > Focus Terminal Panel}
      - If the Terminal Panel was closed, it opens and gains focus
      - If the Terminal Panel was open but unfocused, it gains focus
      - If the Terminal Panel was open and focused, focus returns to the view
      
      {F6630289, size=full}
      
      Reviewers: #dolphin, elvisangelaccio, rominf
      
      Reviewed By: #dolphin, elvisangelaccio, rominf
      
      Subscribers: kfm-devel, elvisangelaccio, rkflx, ngraham, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D10959
      69838a1c
  8. 24 Nov, 2019 1 commit
    • Elvis Angelaccio's avatar
      Fix accessibility regression on the Dolphin Control button · 82e366f0
      Elvis Angelaccio authored
      9cd042a8 removed the text from the Control button without setting an
      accessibleName property, which is a regression for screen-reader users.
      
      This breaks the 19.12 string freeze, but since it's the same string we
      were translating before 9cd042a8, hopefully it's not going to be too
      much of a burden for translators.
      
      CCBUG: 414271
      CCMAIL: kde-i18n-doc@kde.org
      82e366f0
  9. 17 Nov, 2019 1 commit
    • Piotr Henryk Dabrowski's avatar
      [Dolphin] Open Preferred Search Tool action · 537dc786
      Piotr Henryk Dabrowski authored
      Summary:
      Added "Open Preferred Search Tool" action to Tools menu.
      
      It runs preferred (topmost) external search tool as configured in the "More Search Tools" menu.
      
      By default Ctrl+Shift+F shortcut is assigned to this action.
      
      FEATURE: 384798
      FIXED-IN: 20.03.80
      
      {F7134238}
      {F7134240}
      {F7134242}
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: pkloc, kfm-devel, kde-doc-english
      
      Tags: #dolphin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D22594
      537dc786
  10. 10 Nov, 2019 1 commit
  11. 20 Oct, 2019 1 commit
    • Alex Miranda's avatar
      Fix a bug where "Add to Places" remains disabled · e3f1d50b
      Alex Miranda authored
      Summary:
      Fix a bug where "Add to Places" doesn't get re-enabled in the context
      and file menus when nothing is selected after previously selecting a
      single file that is not a directory or multiple files.
      
      Test Plan: Verify the action remains enabled when appropiate
      
      Reviewers: #dolphin, elvisangelaccio, meven
      
      Reviewed By: meven
      
      Subscribers: meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24690
      e3f1d50b
  12. 13 Oct, 2019 1 commit
    • Alex Miranda's avatar
      Add actions for switching to a specific tab · e04ec860
      Alex Miranda authored
      Summary:
      Add actions to switch to each of the first 9 tabs and another action to
      switch to the last tab.
      
      This feature makes it much easier to quickly switch between tabs just
      like you normally would be able to when using a web browser or other
      applications.
      
      Reviewers: #vdg, #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #vdg, #dolphin, ngraham
      
      Subscribers: meven, ngraham, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24353
      e04ec860
  13. 03 Oct, 2019 1 commit
    • David Hallas's avatar
      Fix missing setDefaultShortcuts call · c71c1c94
      David Hallas authored
      Summary:
      The commit eec49bc3 cased a warning to
      be emitted when starting Dolphin:
      
      KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action  "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.
      
      The fix is to call
      actionCollection()->setDefaultShortcuts(m_forwardAction, m_forwardAction->shortcuts());
      so that the default shortcuts are setup.
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24342
      c71c1c94
  14. 01 Oct, 2019 3 commits
  15. 29 Sep, 2019 1 commit
    • David Hallas's avatar
      Add navigation history to forward/back buttons · eec49bc3
      David Hallas authored
      Summary:
      Adds navigation history to forward/back buttons in the toolbar. This
      changes the forward/back buttons in the toolbar to use the
      KToolBarPopupAction class which provides access to a drop down menu.
      
      Test Plan:
      Browse some folders
      Click the back drop down menu and navigate somewhere
      Click the forward drop down menu and navigate somewhere
      
      FEATURE: 157819
      FIXED-IN: 19.12.0
      
      Reviewers: #dolphin, ngraham, elvisangelaccio, #vdg
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio, #vdg
      
      Subscribers: felixernst, nerdopolist, mart, richardl, ognarb, david.fontanals, abetts, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19311
      eec49bc3
  16. 15 Sep, 2019 1 commit
    • Nate Graham's avatar
      Clean up hamburger menu and viewport and single-folder context menus · 0303df09
      Nate Graham authored
      Summary:
      Dolphin's hamburger and context menus have grown organically over time,
      becoming a bit messy and somewhat visually overwhelming. This makes them
      harder to parse and more intimidating to use.
      
      This patch cleans up the hamburger menu and viewport and single-folder context
      menus to group items more logically, and remove items that aren't actually relevant
      to the context.
      
      The hamburger menu part of the patch is fairly significant, and draws from the
      principle of only showing actions with a global scope that are not already accessible
      from another visible method (e.g. via the default toolbar). In the end, it manages to be
      shorter than the current hamburger menu with expose actions that are more relevant.
      
      A visible method to display context-specific actions should be explored separately
      (see https://bugs.kde.org/show_bug.cgi?id=411500).
      
      Depends on D23945
      
      Test Plan:
      Before, hamburger menu: {F7334178}
      After, hamburger menu: {F7350958}
      
      Before, viewport: {F7324802}
      After, viewport: {F7330109}
      
      Before, one folder selected: {F7324798}
      After, one folder selected: {F7341163}
      
      No change for the context menus shown when selecting a single item, multiple items, or multiple folders
      
      Reviewers: #vdg, #dolphin, meven, elvisangelaccio, GB_2
      
      Reviewed By: #vdg, #dolphin, meven, elvisangelaccio, GB_2
      
      Subscribers: GB_2, mmustac, elvisangelaccio, meven, ndavis, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23757
      0303df09
  17. 14 Sep, 2019 3 commits
  18. 10 Sep, 2019 1 commit
  19. 05 Sep, 2019 1 commit
  20. 04 Sep, 2019 1 commit
  21. 02 Sep, 2019 2 commits
  22. 01 Sep, 2019 2 commits
    • Nate Graham's avatar
      Add "Add to Places" action to file menu · 7cad80b2
      Nate Graham authored
      Summary:
      It's recommended that actions available in context menus be available in the main menu
      as well for discoverability's sake. This patch does so for the "Add to Places" action.
      
      The action is moved over to the main window, and accessed in the context menu via the
      actionCollection it lives in.
      
      BUG: 390757
      FIXED-IN: 19.08.0
      
      Test Plan:
      - Action still works
      - Action still appears in context menu when relevant
      - Action in the File menu only becomes enabled when only a single directory is selected or nothing is selected
      
      {F7143876}
      
      {F7143877}
      
      {F7143878}
      
      {F7143879}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22149
      7cad80b2
    • Ismael Asensio's avatar
      [dolphin] Add an action to toggle the searchbar · 3a758690
      Ismael Asensio authored
      Summary:
      Make search action toggle the searchbar instead of just launching it.
      
      The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
      This behavior in inconsistent with other dolphin actions which toggle panels or tools.
      
      BEFORE:
      {F7256652}
      
      AFTER:
      {F7256862}
      
      BUG: 344617
      FIXED-IN: 19.12.0
      Closes T8473
      
      Depends on D23075
      
      Test Plan:
      - Enable the search mode: the searchbar appears and the toolbar button gets checked
      - Press the search button again, and it goes back to normal mode.
      - The search button state is coherent with the searchbox
      - Coherence is kept when changing to a split view or different tab
      - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.
      
      Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8473
      
      Differential Revision: https://phabricator.kde.org/D23232
      3a758690
  23. 25 Aug, 2019 1 commit
    • Simon Krull's avatar
      Change default Dolphin toolbar layout · 9cd042a8
      Simon Krull authored
      Summary:
      {F7205836}
      
      Use a default toolbar layout that looks better and makes more sense for new users.
      
      Test Plan: Open Dolphin (with the default toolbar)
      
      Reviewers: #dolphin, #vdg, ngraham, GB_2, elvisangelaccio
      
      Reviewed By: #dolphin, #vdg, ngraham, GB_2
      
      Subscribers: iasensio, filipf, meven, elvisangelaccio, felixernst, GB_2, ndavis, ngraham, kfm-devel, #vdg, #dolphin
      
      Tags: #dolphin, #vdg
      
      Differential Revision: https://phabricator.kde.org/D23075
      9cd042a8
  24. 24 Aug, 2019 1 commit
  25. 11 Aug, 2019 1 commit
    • Andrey Yashkin's avatar
      Fix an issue with focus lost after closing terminal panel · ec1a0c25
      Andrey Yashkin authored
      Summary:
      After leaving terminal with Ctrl-D or exit commands the input focus isn't set back to the folder view.
      The problem appears, because `TerminalPanel::isHiddenInVisibleWindow` returns not what it supposed to return,
      since when the terminal process exits, `m_terminal` is set to nullptr.
      
      I moved unwanted checks from it inside `TerminalPanel::dockVisibilityChanged`
      
      This change also exposes a crash in `DolphinMainWindow::slotTerminalPanelVisibilityChanged()`,
      which was previously working only by luck.
      Now we check whether `m_activeViewContainer` is not null before using it.
      
      BUG: 407979
      FIXED-IN: 19.11.80
      
      Test Plan:
      1. Open Dolphin
      2. Press F4 to open the terminal panel
      3. Type exit<Enter> or press Ctrl-D
      4. Check current focus widget
      
      Reviewers: #dolphin
      
      Subscribers: ngraham, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22420
      ec1a0c25
  26. 25 Jun, 2019 1 commit
  27. 24 Jun, 2019 1 commit
  28. 23 Jun, 2019 1 commit
    • Felix Ernst's avatar
      Add "What's This?" to nearly everything in the main window · bd788a3f
      Felix Ernst authored
      Summary:
      This commit adds "What's This?" help to nearly everything in the
      Dolphin main window (panels, views, buttons, ...). It adds the "?"
      to the title bar so this help can easily be called.
      
      For links in those help texts to work the WhatsThisClickedEvents are
      handled in the main window class. This doesn't work for menus because
      events from them aren't forwarded to the main window for some
      reason so EventFilters are installed for the Control button menus.
      
      Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
      can be installed in the menubar. Therefore help texts without links
      are provided for the menubar.
      
      Test Plan:
      Check if the event handling might make any problems.
      Check for any big mistakes in the help messages.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20471
      bd788a3f
  29. 07 Jun, 2019 1 commit
  30. 30 May, 2019 1 commit
    • Alexander Saoutkin's avatar
      Open externally called files/directories in new tabs · 27e3907a
      Alexander Saoutkin authored
      Summary:
      FEATURE: 183429
      FIXED-IN: 19.08.0
      GUI: new cli argument --new-window
      
      Externally called files/directories are opened in a a new tab of an instance of Dolphin that already exists. If any of the given URIs are already open in a tab, then those tabs are activated instead of a new tab being opened.  If there is no instance then the files/directories are opened in a new window. The newly opened file/directory has its tab activated, and consequently, the window is also activated.
      
      When the user clicks "Open In New Window" or "Detach Tab", the files/directories are opened in a new window.
      
      Test Plan:
      [Manual]
      Before testing, set the default file manager in system settings as the newly built Dolphin executable.
      One must also include the new dolphin executable in the $PATH, otherwise some functions will attempt to open the system dolphin instead of the new one.
      
      Furthermore, running two different versions of Dolphin (in particular, where one does not have this patch included) can result in bugs appearing, in particular, new tabs not opening as old instances will not recognise the DBus commands sent to it. However, I see no reason why a user will have two different versions of Dolphin (apart from people like us :D).
      
      Open directories with the help of auxillary programs (i.e. a browser). The files/directories should appear in a new window if an instance does not exist. If an existence already exists, then a new tab should be opened and activated in that instance and the window activated.
      Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems methods in org.freedesktop.FileManager1 of the Dolphin instance.
      When a user chooses to "Open In New Window"/"Detach Tab" then the files/directories should be opened in a new window.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16648
      27e3907a
  31. 13 May, 2019 1 commit
    • David Hallas's avatar
      Add Bookmark Handling · 2fac50f5
      David Hallas authored
      Summary:
      Add Bookmark Handling. Adds complete bookmark support as provided by
      other KDE applications like Konsole and Konqueror. This allows you to
      bookmark individual folders, create bookmark folders and open them.
      
      Test Plan:
      Go -> Bookmark -> Add Bookmark
      Go -> Bookmark -> [Open the bookmark you selected]
      
      FEATURE: 171366
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: ognarb, meven, loh.tar, cfeck, hein, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T5408
      
      Differential Revision: https://phabricator.kde.org/D19926
      2fac50f5
  32. 05 May, 2019 1 commit
  33. 22 Apr, 2019 1 commit